You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2015/11/09 15:45:13 UTC
[GitHub] incubator-brooklyn pull request: Move dependant OSGi projects out ...
GitHub user neykov opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1012
Move dependant OSGi projects out of resources
Move OSGi test projects from `src/test/resources/dependencies` to `src/test/dependencies`.
The projects' sources shouldn't be on the classpath, only the build artifacts are used for tests. Also Eclipse gives errors, trying to compile them when in resources.
The projects' `outputDirectory` was using a relative path to `src/test/dependencies` anyway so now they will go to the correct destination when installed.
@hzbarcea, @CMoH, wdyt?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neykov/incubator-brooklyn dependencies-are-not-resources
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/1012.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1012
----
commit fe156744fa13c76b9fe2b626ee76769d35ec6deb
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2015-11-09T14:39:22Z
Move dependant OSGi projects out of resources
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Move dependant OSGi projects out ...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1012#issuecomment-155085062
nobody likes these nested projects but they still seem to be the least bad option. this seems to me a good cleanup.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Move dependant OSGi projects out ...
Posted by hzbarcea <gi...@git.apache.org>.
Github user hzbarcea commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1012#issuecomment-155272760
Sounds reasonable. I think there are a couple of tests failing in ./usage/camp.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Move dependant OSGi projects out ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1012
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---