[GitHub] [incubator-gobblin] jack-moseley commented on a change in pull request #2663: [GOBBLIN-796] Add support partial updates for flowConfig

[GitBox <gi...@apache.org>]

jack-moseley commented on a change in pull request #2663: [GOBBLIN-796] Add support partial updates for flowConfig
URL: https://github.com/apache/incubator-gobblin/pull/2663#discussion_r302690643
 
 

 ##########
 File path: gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigsV2Resource.java
 ##########
 @@ -119,6 +121,20 @@ public UpdateResponse update(ComplexResourceKey<FlowId, FlowStatusId> key, FlowC
     return this.getFlowConfigResourceHandler().updateFlowConfig(flowId, flowConfig);
   }
 
+  /**
+   * Partial update the flowConfig specified
+   * @param key composite key containing group name and flow name that identifies the flow to update
+   * @param flowConfigPatch patch describing what fields to change
+   * @return {@link UpdateResponse}
+   */
+  @Override
+  public UpdateResponse update(ComplexResourceKey<FlowId, FlowStatusId> key, PatchRequest<FlowConfig> flowConfigPatch) {
+    String flowGroup = key.getKey().getFlowGroup();
 
 Review comment:
   I think we can just add features to V2 from now on, there isn't really any reason to add every feature to both versions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services