You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/05/13 14:52:35 UTC

[GitHub] [incubator-mxnet] bartekkuncer opened a new pull request #20268: [operator] Add logsigmoid activation function

bartekkuncer opened a new pull request #20268:
URL: https://github.com/apache/incubator-mxnet/pull/20268


   ## Description ##
   Add new activation function available in recently updated version of oneDNN to mxnet. 
   
   ## Checklist ##
   ### Changes ###
   - [x] Add native implementation
   - [x] Integrate oneDNN implementation
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20268: [operator] Add logsigmoid activation function

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20268:
URL: https://github.com/apache/incubator-mxnet/pull/20268#issuecomment-845118897


   @mxnet-bot run ci [website, centos-gpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20268: [operator] Add logsigmoid activation function

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20268:
URL: https://github.com/apache/incubator-mxnet/pull/20268#issuecomment-845118996


   Jenkins CI successfully triggered : [website, centos-gpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha merged pull request #20268: [operator] Add logsigmoid activation function

Posted by GitBox <gi...@apache.org>.
szha merged pull request #20268:
URL: https://github.com/apache/incubator-mxnet/pull/20268


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20268: [operator] Add logsigmoid activation function

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20268:
URL: https://github.com/apache/incubator-mxnet/pull/20268#issuecomment-844222674


   @mxnet-bot run ci [website]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20268: [operator] Add logsigmoid activation function

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on a change in pull request #20268:
URL: https://github.com/apache/incubator-mxnet/pull/20268#discussion_r636725411



##########
File path: src/operator/tensor/elemwise_unary_op_basic.cc
##########
@@ -196,6 +196,23 @@ MXNET_OPERATOR_REGISTER_BINARY(_backward_softsign)
 .set_attr<FCompute>("FCompute<cpu>", ElemwiseBinaryOp::Compute<cpu,
   unary_bwd<mshadow_op::softsign_grad> >);
 
+// log_sigmoid

Review comment:
       Sure, can do that.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bgawrych commented on a change in pull request #20268: [operator] Add logsigmoid activation function

Posted by GitBox <gi...@apache.org>.
bgawrych commented on a change in pull request #20268:
URL: https://github.com/apache/incubator-mxnet/pull/20268#discussion_r636722450



##########
File path: src/operator/nn/mkldnn/mkldnn_act.cc
##########
@@ -83,6 +84,8 @@ mkldnn::algorithm GetMKLDNNActAlgo(const ActivationParam& param) {
       return mkldnn::algorithm::eltwise_relu;
     case activation::kSigmoid:
       return mkldnn::algorithm::eltwise_logistic;
+    case activation::kLogSigmoid:

Review comment:
       This function is used with oneDNN subgraphs also, can you add tests in test_fc_subgraph.py and test_conv_subgraph.py

##########
File path: src/operator/tensor/elemwise_unary_op_basic.cc
##########
@@ -196,6 +196,23 @@ MXNET_OPERATOR_REGISTER_BINARY(_backward_softsign)
 .set_attr<FCompute>("FCompute<cpu>", ElemwiseBinaryOp::Compute<cpu,
   unary_bwd<mshadow_op::softsign_grad> >);
 
+// log_sigmoid

Review comment:
       Maybe move this fragment of code below sigmoid registration?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20268: [operator] Add logsigmoid activation function

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20268:
URL: https://github.com/apache/incubator-mxnet/pull/20268#issuecomment-845883245


   @mxnet-bot run ci [windows-cpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20268: [operator] Add logsigmoid activation function

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20268:
URL: https://github.com/apache/incubator-mxnet/pull/20268#issuecomment-844222742


   Jenkins CI successfully triggered : [website]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20268: [operator] Add logsigmoid activation function

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on a change in pull request #20268:
URL: https://github.com/apache/incubator-mxnet/pull/20268#discussion_r636732021



##########
File path: src/operator/nn/mkldnn/mkldnn_act.cc
##########
@@ -83,6 +84,8 @@ mkldnn::algorithm GetMKLDNNActAlgo(const ActivationParam& param) {
       return mkldnn::algorithm::eltwise_relu;
     case activation::kSigmoid:
       return mkldnn::algorithm::eltwise_logistic;
+    case activation::kLogSigmoid:

Review comment:
       Will do




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha commented on pull request #20268: [operator] Add logsigmoid activation function

Posted by GitBox <gi...@apache.org>.
szha commented on pull request #20268:
URL: https://github.com/apache/incubator-mxnet/pull/20268#issuecomment-846047874


   Merged. Thanks for the change @bartekkuncer


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20268: [operator] Add logsigmoid activation function

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20268:
URL: https://github.com/apache/incubator-mxnet/pull/20268#issuecomment-845883295


   Jenkins CI successfully triggered : [windows-cpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20268: [operator] Add logsigmoid activation function

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20268:
URL: https://github.com/apache/incubator-mxnet/pull/20268#issuecomment-844888943


   @mxnet-bot run ci [website, windows-cpu, windows-gpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20268: [operator] Add logsigmoid activation function

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20268:
URL: https://github.com/apache/incubator-mxnet/pull/20268#issuecomment-845695520


   @mxnet-bot run ci [unix-cpu, centos-gpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20268: [operator] Add logsigmoid activation function

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20268:
URL: https://github.com/apache/incubator-mxnet/pull/20268#issuecomment-840614906


   Hey @bartekkuncer , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [unix-cpu, windows-gpu, edge, windows-cpu, clang, miscellaneous, sanity, centos-cpu, unix-gpu, website, centos-gpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20268: [operator] Add logsigmoid activation function

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on a change in pull request #20268:
URL: https://github.com/apache/incubator-mxnet/pull/20268#discussion_r636732021



##########
File path: src/operator/nn/mkldnn/mkldnn_act.cc
##########
@@ -83,6 +84,8 @@ mkldnn::algorithm GetMKLDNNActAlgo(const ActivationParam& param) {
       return mkldnn::algorithm::eltwise_relu;
     case activation::kSigmoid:
       return mkldnn::algorithm::eltwise_logistic;
+    case activation::kLogSigmoid:

Review comment:
       Done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20268: [operator] Add logsigmoid activation function

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20268:
URL: https://github.com/apache/incubator-mxnet/pull/20268#issuecomment-845695578


   Jenkins CI successfully triggered : [unix-cpu, centos-gpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20268: [operator] Add logsigmoid activation function

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20268:
URL: https://github.com/apache/incubator-mxnet/pull/20268#issuecomment-845943114


   Jenkins CI successfully triggered : [windows-cpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20268: [operator] Add logsigmoid activation function

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20268:
URL: https://github.com/apache/incubator-mxnet/pull/20268#issuecomment-845943058


   @mxnet-bot run ci [windows-cpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20268: [operator] Add logsigmoid activation function

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20268:
URL: https://github.com/apache/incubator-mxnet/pull/20268#issuecomment-844889042


   Jenkins CI successfully triggered : [website, windows-cpu, windows-gpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org