[jira] [Commented] (ZOOKEEPER-1994) Backup config files.

["Hongchao Deng (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082426#comment-14082426 ] 

Hongchao Deng commented on ZOOKEEPER-1994:
------------------------------------------

Just to clarify, this issue contains two parts:
1. Backup static config. It happens twice 
{quote}
once when removing the ensemble definitions, at which point a dynamic file doesn't exist yet, and once when removing clientPort information
{quote}

2. Backup dynamic file. It happens when a new dynamic is created on reconfig.

[~shralex]
Your options are applied to dynamic files. I think it also applies to static files. I prefer sequence number (we can save the zxid in file).

One questions: where should those backup stay? What about creating a new directory in "data/"?

> Backup config files.
> --------------------
>
>                 Key: ZOOKEEPER-1994
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1994
>             Project: ZooKeeper
>          Issue Type: Improvement
>    Affects Versions: 3.5.0
>            Reporter: Hongchao Deng
>            Assignee: Hongchao Deng
>             Fix For: 3.5.0
>
>
> We should create a backup file for a static or dynamic configuration file before changing the file. 
> Since the static file is changed at most twice (once when removing the ensemble definitions, at which point a dynamic file doesn't exist yet, and once when removing clientPort information) its probably fine to back up the static file independently from the dynamic file. 
> To track backup history:
> Option 1: we could have a .bakXX extention for backup where XX is a  sequence number. 
> Option 2: have the configuration version be part of the file name for dynamic configuration files (instead of in the file like now). Such as zoo_replicated1.cfg.dynamic.1000000 then on reconfiguration simply create a new dynamic file (with new version) and update the link in the static file to point to the new dynamic one.



--
This message was sent by Atlassian JIRA
(v6.2#6252)