[jira] [Created] (OFBIZ-5770) Fix a regression introduced with OFBIZ-4794

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

Jacques Le Roux created OFBIZ-5770:
--------------------------------------

             Summary: Fix a regression introduced with OFBIZ-4794
                 Key: OFBIZ-5770
                 URL: https://issues.apache.org/jira/browse/OFBIZ-5770
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: Trunk, Release Branch 13.07
            Reporter: Jacques Le Roux


With OFBIZ-4794, not seeing that ServiceLocation was tagged threadSafe, by removing the final word on the private location String and using the ServiceLocation.setLocation() method I broke the thread safety of ServiceLocation in ServiceEngine constructor. This has been noticed by Jacopo while working on r1624700, [see this thread|http://markmail.org/message/64ysqsqa5cvjq4m5]

Fortunately this was only a possible problem if you used the -Dportoffset parameter. I never crossed issue personnaly and the official stable demo is running with it for few months w/o noticed issues.

I propose the attached patch to fix this issue. The ServiceLocation will no longer be thread safe but that should not be a problem. There are maybe better solutions which would keep the thread safety but I found none.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)