You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/08/01 04:21:20 UTC
[GitHub] [apisix-dashboard] Baoyuantop opened a new pull request #2022: fix(route): add operators
Baoyuantop opened a new pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
support all operators in route vars field .
**Related issues**
fix #2014
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#issuecomment-890447240
π· Deploy Preview for *apisix-dashboard* processing.
π¨ Explore the source changes: 48591b92f8f8545f26ebf0a28fba904bfadb302e
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/610d3817fcbfd0000735b7de](https://app.netlify.com/sites/apisix-dashboard/deploys/610d3817fcbfd0000735b7de?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#issuecomment-890447240
π· Deploy Preview for *apisix-dashboard* processing.
π¨ Explore the source changes: 24b476e013cfb5e1fb0720b52160a7caaa1d48ea
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/610cdd383dfed00007e09387](https://app.netlify.com/sites/apisix-dashboard/deploys/610cdd383dfed00007e09387?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#issuecomment-890447240
π· Deploy Preview for *apisix-dashboard* processing.
π¨ Explore the source changes: a626a9e001cf14d0234a09edfd7169c422556f80
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/6107a379d5b8d200085d8598](https://app.netlify.com/sites/apisix-dashboard/deploys/6107a379d5b8d200085d8598?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#issuecomment-890447240
βοΈ Deploy Preview for *apisix-dashboard* ready!
π¨ Explore the source changes: 24b476e013cfb5e1fb0720b52160a7caaa1d48ea
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/610cdd383dfed00007e09387](https://app.netlify.com/sites/apisix-dashboard/deploys/610cdd383dfed00007e09387?utm_source=github&utm_campaign=bot_dl)
π Browse the preview: [https://deploy-preview-2022--apisix-dashboard.netlify.app/](https://deploy-preview-2022--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#issuecomment-890447240
βοΈ Deploy Preview for *apisix-dashboard* ready!
π¨ Explore the source changes: a626a9e001cf14d0234a09edfd7169c422556f80
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/6107a379d5b8d200085d8598](https://app.netlify.com/sites/apisix-dashboard/deploys/6107a379d5b8d200085d8598?utm_source=github&utm_campaign=bot_dl)
π Browse the preview: [https://deploy-preview-2022--apisix-dashboard.netlify.app/](https://deploy-preview-2022--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#discussion_r684232124
##########
File path: web/src/pages/Route/locales/zh-CN.ts
##########
@@ -26,7 +26,10 @@ export default {
'page.route.greaterThan': 'ε€§δΊοΌ>οΌ',
'page.route.lessThan': 'ε°δΊοΌ<οΌ',
'page.route.regexMatch': 'ζ£εεΉι
οΌο½ο½οΌ',
+ 'page.route.caseInsensitiveRegexMatch': 'δΈεΊεε€§ε°εηζ£εεΉι
(~*)',
Review comment:
```suggestion
'page.route.caseInsensitiveRegexMatch': 'δΈεΊεε€§ε°εηζ£εεΉι
οΌ~*οΌ',
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#issuecomment-890447240
π· Deploy Preview for *apisix-dashboard* processing.
π¨ Explore the source changes: ef5387e5e323d4260f0d1c4345fa0b93239aeba1
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/61094d5656076500078d66db](https://app.netlify.com/sites/apisix-dashboard/deploys/61094d5656076500078d66db?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#issuecomment-890449462
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2022](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (326481b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/33c735ec314a82d5c8d67e8fb61ea5e8450ff9ce?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33c735e) will **decrease** coverage by `4.08%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2022 +/- ##
==========================================
- Coverage 67.92% 63.83% -4.09%
==========================================
Files 182 122 -60
Lines 6972 3172 -3800
Branches 753 758 +5
==========================================
- Hits 4736 2025 -2711
+ Misses 1949 1147 -802
+ Partials 287 0 -287
```
| Flag | Coverage Ξ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `63.83% <50.00%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...pages/Route/components/Step1/MatchingRulesView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL01hdGNoaW5nUnVsZXNWaWV3LnRzeA==) | `47.89% <31.25%> (-5.38%)` | :arrow_down: |
| [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `65.82% <100.00%> (+0.21%)` | :arrow_up: |
| [web/src/components/Plugin/UI/limit-req.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1yZXEudHN4) | `100.00% <100.00%> (ΓΈ)` | |
| [web/src/components/Plugin/UI/plugin.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wbHVnaW4udHN4) | `82.60% <100.00%> (ΓΈ)` | |
| [web/src/components/Upstream/components/Type.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVHlwZS50c3g=) | `100.00% <100.00%> (ΓΈ)` | |
| [api/cmd/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC92ZXJzaW9uLmdv) | | |
| [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | | |
| [api/cmd/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9zZXJ2aWNlLmdv) | | |
| [...pi/internal/handler/plugin\_config/plugin\_config.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX2NvbmZpZy9wbHVnaW5fY29uZmlnLmdv) | | |
| [api/internal/handler/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbWlncmF0ZS9taWdyYXRlLmdv) | | |
| ... and [56 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [446377d...326481b](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#issuecomment-890447240
π· Deploy Preview for *apisix-dashboard* processing.
π¨ Explore the source changes: fac0d6ce592a5439e9be221d6496af0252527f8f
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/61077684cd27270008ca50b6](https://app.netlify.com/sites/apisix-dashboard/deploys/61077684cd27270008ca50b6?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#discussion_r680646385
##########
File path: web/src/pages/Route/components/Step1/MatchingRulesView.tsx
##########
@@ -245,30 +258,48 @@ const MatchingRulesView: React.FC<RouteModule.Step1PassProps> = ({
rules={[
{
required: true,
- message: `${formatMessage({ id: 'component.global.pleaseChoose' })} ${formatMessage({
- id: 'page.route.operationalCharacter',
- })}`,
+ message: `${formatMessage({ id: 'component.global.pleaseChoose' })} ${formatMessage(
+ {
+ id: 'page.route.operationalCharacter',
+ },
+ )}`,
},
]}
>
- <Select onChange={(e: string) => {
- switch (e) {
- case "IN":
- setOperatorValueSample(formatMessage({ id: 'page.route.advanced-match.operator.sample.IN' }))
- break
- case "~~":
- setOperatorValueSample(formatMessage({ id: 'page.route.advanced-match.operator.sample.~~' }))
- break
- default:
- setOperatorValueSample("")
- }
- }}>
+ <Select
+ onChange={(e: string) => {
+ switch (e) {
+ case 'IN':
+ setOperatorValueSample(
+ formatMessage({ id: 'page.route.advanced-match.operator.sample.IN' }),
+ );
+ break;
+ case '~~':
+ setOperatorValueSample(
+ formatMessage({ id: 'page.route.advanced-match.operator.sample.~~' }),
+ );
+ break;
+ case '~*':
+ setOperatorValueSample(
+ formatMessage({ id: 'page.route.advanced-match.operator.sample.~~' }),
+ );
Review comment:
```suggestion
case '~~':
case '~*':
setOperatorValueSample(
formatMessage({ id: 'page.route.advanced-match.operator.sample.~~' }),
);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#discussion_r680814518
##########
File path: web/src/pages/Route/components/Step1/MatchingRulesView.tsx
##########
@@ -88,6 +88,18 @@ const MatchingRulesView: React.FC<RouteModule.Step1PassProps> = ({
});
};
+ const OperatorRenderText = {
+ '==': 'page.route.equal',
Review comment:
Not a good idea to use `key` here directly, I would prefer keeping the `formatMessage(xxx)` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#issuecomment-890447240
βοΈ Deploy Preview for *apisix-dashboard* ready!
π¨ Explore the source changes: d05318897d6427969595f77de748de5bcb1f68af
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/610cc280c75c590009a1e714](https://app.netlify.com/sites/apisix-dashboard/deploys/610cc280c75c590009a1e714?utm_source=github&utm_campaign=bot_dl)
π Browse the preview: [https://deploy-preview-2022--apisix-dashboard.netlify.app/](https://deploy-preview-2022--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Baoyuantop commented on a change in pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on a change in pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#discussion_r680676199
##########
File path: web/src/pages/Route/components/Step1/MatchingRulesView.tsx
##########
@@ -136,9 +136,18 @@ const MatchingRulesView: React.FC<RouteModule.Step1PassProps> = ({
case '~~':
renderText = formatMessage({ id: 'page.route.regexMatch' });
break;
+ case '~*':
+ renderText = formatMessage({ id: 'page.royte.caseInsensitiveRegexMatch' });
+ break;
case 'IN':
renderText = formatMessage({ id: 'page.route.in' });
break;
+ case 'HAS':
Review comment:
Think it's good, let me try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#issuecomment-890447240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Baoyuantop commented on a change in pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on a change in pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#discussion_r680816730
##########
File path: web/src/pages/Route/components/Step1/MatchingRulesView.tsx
##########
@@ -88,6 +88,18 @@ const MatchingRulesView: React.FC<RouteModule.Step1PassProps> = ({
});
};
+ const OperatorRenderText = {
+ '==': 'page.route.equal',
Review comment:
like `'==': formatMessage({ id: page.route.equal })` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#issuecomment-890449462
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2022](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6df0dc9) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/33c735ec314a82d5c8d67e8fb61ea5e8450ff9ce?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33c735e) will **decrease** coverage by `3.50%`.
> The diff coverage is `77.77%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2022 +/- ##
==========================================
- Coverage 67.92% 64.42% -3.51%
==========================================
Files 182 121 -61
Lines 6972 3137 -3835
Branches 753 747 -6
==========================================
- Hits 4736 2021 -2715
+ Misses 1949 1116 -833
+ Partials 287 0 -287
```
| Flag | Coverage Ξ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `64.42% <77.77%> (+0.47%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...pages/Route/components/Step1/MatchingRulesView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL01hdGNoaW5nUnVsZXNWaWV3LnRzeA==) | `64.77% <66.66%> (+11.50%)` | :arrow_up: |
| [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `65.82% <100.00%> (+0.21%)` | :arrow_up: |
| [web/src/components/Plugin/UI/limit-req.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1yZXEudHN4) | `100.00% <100.00%> (ΓΈ)` | |
| [web/src/components/Plugin/UI/plugin.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wbHVnaW4udHN4) | `82.60% <100.00%> (ΓΈ)` | |
| [web/src/components/Upstream/components/Type.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVHlwZS50c3g=) | `100.00% <100.00%> (ΓΈ)` | |
| [web/src/components/RightContent/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1JpZ2h0Q29udGVudC9pbmRleC50c3g=) | `83.33% <0.00%> (-3.34%)` | :arrow_down: |
| [api/cmd/remove.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9yZW1vdmUuZ28=) | | |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | | |
| [api/internal/utils/pid.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3BpZC5nbw==) | | |
| [api/internal/handler/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbWlncmF0ZS9taWdyYXRlLmdv) | | |
| ... and [58 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [446377d...6df0dc9](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#issuecomment-890449462
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2022](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7ab186d) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/33c735ec314a82d5c8d67e8fb61ea5e8450ff9ce?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33c735e) will **decrease** coverage by `3.59%`.
> The diff coverage is `69.44%`.
> :exclamation: Current head 7ab186d differs from pull request most recent head a626a9e. Consider uploading reports for the commit a626a9e to get more accurate results
[](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2022 +/- ##
==========================================
- Coverage 67.92% 64.32% -3.60%
==========================================
Files 182 121 -61
Lines 6972 3137 -3835
Branches 753 747 -6
==========================================
- Hits 4736 2018 -2718
+ Misses 1949 1119 -830
+ Partials 287 0 -287
```
| Flag | Coverage Ξ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `64.32% <69.44%> (+0.37%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [web/src/components/RightContent/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1JpZ2h0Q29udGVudC9pbmRleC50c3g=) | `83.33% <ΓΈ> (-3.34%)` | :arrow_down: |
| [...pages/Route/components/Step1/MatchingRulesView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL01hdGNoaW5nUnVsZXNWaWV3LnRzeA==) | `61.36% <54.16%> (+8.09%)` | :arrow_up: |
| [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `65.82% <100.00%> (+0.21%)` | :arrow_up: |
| [web/src/components/Plugin/UI/limit-req.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1yZXEudHN4) | `100.00% <100.00%> (ΓΈ)` | |
| [web/src/components/Plugin/UI/plugin.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wbHVnaW4udHN4) | `82.60% <100.00%> (ΓΈ)` | |
| [web/src/components/Upstream/components/Type.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVHlwZS50c3g=) | `100.00% <100.00%> (ΓΈ)` | |
| [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | | |
| [api/cmd/install.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9pbnN0YWxsLmdv) | | |
| [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | | |
| [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | | |
| ... and [57 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [446377d...a626a9e](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#issuecomment-890449462
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2022](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (48591b9) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/af855915896562c488c2b4669e24883cd140cfb5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (af85591) will **increase** coverage by `0.44%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2022 +/- ##
==========================================
+ Coverage 63.52% 63.96% +0.44%
==========================================
Files 121 121
Lines 3213 3194 -19
Branches 779 773 -6
==========================================
+ Hits 2041 2043 +2
+ Misses 1172 1151 -21
```
| Flag | Coverage Ξ | |
|---|---|---|
| frontend-e2e-test | `63.96% <100.00%> (+0.44%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...pages/Route/components/Step1/MatchingRulesView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL01hdGNoaW5nUnVsZXNWaWV3LnRzeA==) | `64.77% <100.00%> (+11.50%)` | :arrow_up: |
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `72.13% <0.00%> (+3.27%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [af85591...48591b9](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#issuecomment-890447240
π· Deploy Preview for *apisix-dashboard* processing.
π¨ Explore the source changes: d05318897d6427969595f77de748de5bcb1f68af
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/610cc280c75c590009a1e714](https://app.netlify.com/sites/apisix-dashboard/deploys/610cc280c75c590009a1e714?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#discussion_r680650807
##########
File path: web/src/pages/Route/components/Step1/MatchingRulesView.tsx
##########
@@ -136,9 +136,18 @@ const MatchingRulesView: React.FC<RouteModule.Step1PassProps> = ({
case '~~':
renderText = formatMessage({ id: 'page.route.regexMatch' });
break;
+ case '~*':
+ renderText = formatMessage({ id: 'page.royte.caseInsensitiveRegexMatch' });
+ break;
case 'IN':
renderText = formatMessage({ id: 'page.route.in' });
break;
+ case 'HAS':
Review comment:
How about try to use a cont object or enum to define the the relationship between the operator and its show name? this can also be reused in https://github.com/apache/apisix-dashboard/pull/2022/files#diff-a55e5a5bd491758bf28203f2e3eb5ada3d01944348e00c2cafb6671e79621bc3R288-R298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#issuecomment-890449462
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2022](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fac0d6c) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/33c735ec314a82d5c8d67e8fb61ea5e8450ff9ce?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33c735e) will **decrease** coverage by `4.15%`.
> The diff coverage is `52.38%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2022 +/- ##
==========================================
- Coverage 67.92% 63.77% -4.16%
==========================================
Files 182 121 -61
Lines 6972 3166 -3806
Branches 753 757 +4
==========================================
- Hits 4736 2019 -2717
+ Misses 1949 1147 -802
+ Partials 287 0 -287
```
| Flag | Coverage Ξ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `63.77% <52.38%> (-0.18%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...pages/Route/components/Step1/MatchingRulesView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL01hdGNoaW5nUnVsZXNWaWV3LnRzeA==) | `48.71% <33.33%> (-4.56%)` | :arrow_down: |
| [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `65.82% <100.00%> (+0.21%)` | :arrow_up: |
| [web/src/components/Plugin/UI/limit-req.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1yZXEudHN4) | `100.00% <100.00%> (ΓΈ)` | |
| [web/src/components/Plugin/UI/plugin.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wbHVnaW4udHN4) | `82.60% <100.00%> (ΓΈ)` | |
| [web/src/components/Upstream/components/Type.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVHlwZS50c3g=) | `100.00% <100.00%> (ΓΈ)` | |
| [web/src/components/RightContent/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1JpZ2h0Q29udGVudC9pbmRleC50c3g=) | `83.33% <0.00%> (-3.34%)` | :arrow_down: |
| [api/internal/core/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9taWdyYXRlLmdv) | | |
| [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | | |
| [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | | |
| [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | | |
| ... and [57 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [446377d...fac0d6c](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#issuecomment-890447240
βοΈ Deploy Preview for *apisix-dashboard* ready!
π¨ Explore the source changes: 6df0dc908ce37f1e2dd7fb5b6f055b31d7c1ec1b
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/61094f322f78870008b732b8](https://app.netlify.com/sites/apisix-dashboard/deploys/61094f322f78870008b732b8?utm_source=github&utm_campaign=bot_dl)
π Browse the preview: [https://deploy-preview-2022--apisix-dashboard.netlify.app/](https://deploy-preview-2022--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#discussion_r681410433
##########
File path: web/src/pages/Route/components/Step1/MatchingRulesView.tsx
##########
@@ -88,6 +88,18 @@ const MatchingRulesView: React.FC<RouteModule.Step1PassProps> = ({
});
};
+ const OperatorRenderText = {
+ '==': 'page.route.equal',
Review comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#issuecomment-890711694
It would be better to add a test case to verify whether we have covered add the operators
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#issuecomment-890447240
βοΈ Deploy Preview for *apisix-dashboard* ready!
π¨ Explore the source changes: 326481b4d374916d84bd49b17307482749e6acbf
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/610621375c3e3700081692a6](https://app.netlify.com/sites/apisix-dashboard/deploys/610621375c3e3700081692a6?utm_source=github&utm_campaign=bot_dl)
π Browse the preview: [https://deploy-preview-2022--apisix-dashboard.netlify.app/](https://deploy-preview-2022--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#issuecomment-890449462
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2022](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (790b08c) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/af855915896562c488c2b4669e24883cd140cfb5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (af85591) will **increase** coverage by `0.37%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 790b08c differs from pull request most recent head 24b476e. Consider uploading reports for the commit 24b476e to get more accurate results
[](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2022 +/- ##
==========================================
+ Coverage 63.52% 63.90% +0.37%
==========================================
Files 121 121
Lines 3213 3194 -19
Branches 779 773 -6
==========================================
Hits 2041 2041
+ Misses 1172 1153 -19
```
| Flag | Coverage Ξ | |
|---|---|---|
| frontend-e2e-test | `63.90% <100.00%> (+0.37%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...pages/Route/components/Step1/MatchingRulesView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL01hdGNoaW5nUnVsZXNWaWV3LnRzeA==) | `64.77% <100.00%> (+11.50%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [af85591...24b476e](https://codecov.io/gh/apache/apisix-dashboard/pull/2022?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#issuecomment-890447240
π· Deploy Preview for *apisix-dashboard* processing.
π¨ Explore the source changes: 326481b4d374916d84bd49b17307482749e6acbf
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/610621375c3e3700081692a6](https://app.netlify.com/sites/apisix-dashboard/deploys/610621375c3e3700081692a6?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#issuecomment-890447240
βοΈ Deploy Preview for *apisix-dashboard* ready!
π¨ Explore the source changes: 48591b92f8f8545f26ebf0a28fba904bfadb302e
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/610d3817fcbfd0000735b7de](https://app.netlify.com/sites/apisix-dashboard/deploys/610d3817fcbfd0000735b7de?utm_source=github&utm_campaign=bot_dl)
π Browse the preview: [https://deploy-preview-2022--apisix-dashboard.netlify.app/](https://deploy-preview-2022--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Baoyuantop commented on pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#issuecomment-890746169
> It would be better to add a test case to verify whether we have covered add the operators
I am supplementing the test part
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#issuecomment-890447240
βοΈ Deploy Preview for *apisix-dashboard* ready!
π¨ Explore the source changes: fac0d6ce592a5439e9be221d6496af0252527f8f
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/61077684cd27270008ca50b6](https://app.netlify.com/sites/apisix-dashboard/deploys/61077684cd27270008ca50b6?utm_source=github&utm_campaign=bot_dl)
π Browse the preview: [https://deploy-preview-2022--apisix-dashboard.netlify.app/](https://deploy-preview-2022--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on pull request #2022: fix(route): add operators
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on pull request #2022:
URL: https://github.com/apache/apisix-dashboard/pull/2022#issuecomment-894125849
LGTM! cc @liuxiran @iamayushdas please have a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org