You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jackrabbit.apache.org by mr...@apache.org on 2005/04/15 15:41:53 UTC

svn commit: r161456 - in incubator/jackrabbit/trunk/src: java/org/apache/jackrabbit/core/query/QueryImpl.java test/org/apache/jackrabbit/test/api/query/SaveTest.java

Author: mreutegg
Date: Fri Apr 15 06:41:53 2005
New Revision: 161456

URL: http://svn.apache.org/viewcvs?view=rev&rev=161456
Log:
- Update to spec 0.16.4: Query.save() has been replaced by Query.storeAsNode() and does not automatically save the created Node.

Modified:
    incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/query/QueryImpl.java
    incubator/jackrabbit/trunk/src/test/org/apache/jackrabbit/test/api/query/SaveTest.java

Modified: incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/query/QueryImpl.java
URL: http://svn.apache.org/viewcvs/incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/query/QueryImpl.java?view=diff&r1=161455&r2=161456
==============================================================================
--- incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/query/QueryImpl.java (original)
+++ incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/query/QueryImpl.java Fri Apr 15 06:41:53 2005
@@ -186,8 +186,6 @@
             // set properties
             queryNode.setProperty(QueryConstants.JCR_LANGUAGE.toJCRName(resolver), language);
             queryNode.setProperty(QueryConstants.JCR_STATEMENT.toJCRName(resolver), statement);
-            // todo this should be changed in the spec some time!
-            queryNode.getParent().save();
             node = queryNode;
             return node;
         } catch (MalformedPathException e) {

Modified: incubator/jackrabbit/trunk/src/test/org/apache/jackrabbit/test/api/query/SaveTest.java
URL: http://svn.apache.org/viewcvs/incubator/jackrabbit/trunk/src/test/org/apache/jackrabbit/test/api/query/SaveTest.java?view=diff&r1=161455&r2=161456
==============================================================================
--- incubator/jackrabbit/trunk/src/test/org/apache/jackrabbit/test/api/query/SaveTest.java (original)
+++ incubator/jackrabbit/trunk/src/test/org/apache/jackrabbit/test/api/query/SaveTest.java Fri Apr 15 06:41:53 2005
@@ -189,6 +189,7 @@
         } catch (LockException e) {
             // expected behaviour
         } finally {
+            readWrite.logout();
             lockable.unlock();
         }
     }