You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/09/22 08:53:19 UTC
[GitHub] [iceberg] nastra opened a new pull request, #5827: Build: Apply spotless on integration modules as well
nastra opened a new pull request, #5827:
URL: https://github.com/apache/iceberg/pull/5827
This was unintentionally forgotten and usually spotless is able to infer
all java files from the source sets. However, the way we defined the
source sets doesn't seem working with spotless and so
we were defining relevant modules via `target`.
Additional details:
Spotless requires all source sets to be part of the current module being
evaluated, which isn't the case for the hive module:
```
> Spotless error! All target files must be within the project dir.
project dir: /home/nastra/Development/workspace/iceberg/hive3
target: /home/nastra/Development/workspace/iceberg/mr/src/test/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandlerTestUtils.java
```
And this is how the sourceSets are defined in `iceberg-hive3` which
cause issues:
```
project(':iceberg-hive3') {
// run the tests in iceberg-mr with Hive3 dependencies
sourceSets {
test {
java.srcDirs = ['../mr/src/test/java', 'src/test/java']
resources.srcDirs = ['../mr/src/test/resources', 'src/test/resources']
}
}
...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #5827: Build: Apply spotless on integration modules as well
Posted by GitBox <gi...@apache.org>.
rdblue merged PR #5827:
URL: https://github.com/apache/iceberg/pull/5827
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #5827: Build: Apply spotless on integration modules as well
Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #5827:
URL: https://github.com/apache/iceberg/pull/5827#issuecomment-1255274605
Thanks, @nastra!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org