You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "Roiocam (via GitHub)" <gi...@apache.org> on 2024/02/03 16:51:24 UTC
[I] super-high cost when searching for documents [incubator-pekko]
Roiocam opened a new issue, #1097:
URL: https://github.com/apache/incubator-pekko/issues/1097
<!--
Please report issues regarding specific projects in their respective issue trackers, e.g.:
- Pekko HTTP: https://github.com/apache/incubator-pekko-http/issues
- Pekko Connectors: https://github.com/apache/incubator-pekko-connectors/issues
- Pekko Persistence Cassandra Plugin: https://github.com/apache/incubator-pekko-persistence-cassandra/issues
- ...
Please explain your issue precisely, and if possible provide a reproducer snippet (this helps resolve issues much quicker).
Thanks for contributing!
-->
## Reproduce
Just search from https://pekko.apache.org/docs/pekko/current//index.html
<img width="1667" alt="截屏2024-02-04 00 43 51" src="https://github.com/apache/incubator-pekko/assets/26020358/301723b8-9a46-466c-af6d-65098ad4fd5c">
<img width="706" alt="截屏2024-02-04 00 49 34" src="https://github.com/apache/incubator-pekko/assets/26020358/cfea3c1d-6460-49ce-bd48-30dd7804f72e">
<img width="611" alt="截屏2024-02-04 00 50 09" src="https://github.com/apache/incubator-pekko/assets/26020358/20f7c77b-da19-4908-bc26-8803b7cab4df">
## Performance Profile
[Trace-20240204T004355.json](https://github.com/apache/incubator-pekko/files/14152202/Trace-20240204T004355.json)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] super-high cost when searching for documents [incubator-pekko]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on issue #1097:
URL: https://github.com/apache/incubator-pekko/issues/1097#issuecomment-1925428356
After some digging, I just found the issue caused by a very large search_index.json, it will load when the user clicks the search input box.
<img width="930" alt="截屏2024-02-04 02 34 49" src="https://github.com/apache/incubator-pekko/assets/26020358/1c33d9e5-315c-419c-b14f-d408dddf2400">
This javascript file comes from the upstream repo: https://github.com/squidfunk/mkdocs-material, in the latest documentation website of them, it will pre-loaded search index, and the index file size is only 200kb.
Then I checked the content of pekko search index file, which is very large json array.
<img width="815" alt="截屏2024-02-04 02 48 11" src="https://github.com/apache/incubator-pekko/assets/26020358/a2d1451a-0765-4505-a5e3-46ac3a7655a6">
Finally, I decided to look up the answer in the upstream repo, and I found this: https://github.com/squidfunk/mkdocs-material/issues/904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] super-high cost when searching for documents [incubator-pekko]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on issue #1097:
URL: https://github.com/apache/incubator-pekko/issues/1097#issuecomment-1925593515
> IIRC, it was using the algolia for indexing and searching
I don't think so, only akka uses algolia, we use paradox-material-theme which depends on mkdocs-material
> Maybe, we should look at trying to offload the search to Google instead of using our own search with its own JSON file.
I am using Docusaurus at work, they use the same way to implement offline search but won't stuck UI thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] super-high cost when searching for documents [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #1097:
URL: https://github.com/apache/incubator-pekko/issues/1097#issuecomment-1925434713
It is Paradox that builds this json file. I'm not sure what we can do in the short term. Maybe, we should look at trying to offload the search to Google instead of using our own search with its own JSON file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] super-high cost when searching for documents [incubator-pekko]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on issue #1097:
URL: https://github.com/apache/incubator-pekko/issues/1097#issuecomment-1925860792
> I will try to handle this issue via an update paradox-material-theme.
I tried to upgrade to the latest mkdocs-material and found that the way it was built changed after the 5.x version, and only up-to 5.x version can avoid search blocking the main thread, and it seems that the implementation is through the need to precompile a search index file.
I think this upgrade is no less difficult than rewriting upstream https://github.com/sbt/sbt-paradox-material-theme. We should consider replacing the search implementation to solve this ISSUE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] super-high cost when searching for documents [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #1097:
URL: https://github.com/apache/incubator-pekko/issues/1097#issuecomment-1943679358
@Roiocam sbt-paradox-theme has been ported over to the sbt org/package and 0.7.0 has just been [published](https://github.com/sbt/sbt-paradox-material-theme/actions/runs/7901103220/job/21564226923) so you are now free to make changes against [sbt-paradox-theme](https://github.com/sbt/sbt-paradox-material-theme).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] super-high cost when searching for documents [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #1097:
URL: https://github.com/apache/incubator-pekko/issues/1097#issuecomment-1925435247
An example Google search
`actor site:pekko.apache.org`
https://www.google.com/search?q=actor+site%3Apekko.apache.org
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] super-high cost when searching for documents [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on issue #1097:
URL: https://github.com/apache/incubator-pekko/issues/1097#issuecomment-1925477932
IIRC, it was using the algolia for indexing and searching
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] super-high cost when searching for documents [incubator-pekko]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on issue #1097:
URL: https://github.com/apache/incubator-pekko/issues/1097#issuecomment-1925605295
I will try to handle this issue via an update paradox-material-theme.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] super-high cost when searching for documents [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #1097:
URL: https://github.com/apache/incubator-pekko/issues/1097#issuecomment-1925606098
> I will try to handle this issue via an update paradox-material-theme.
Note that [sbt-paradox-material-theme](https://github.com/sbt/sbt-paradox-material-theme) was just transferred to the sbt org/community and we are currently in the process of making the necessary changes so it may take a bit of time before we can get to deploying the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] super-high cost when searching for documents [incubator-pekko]
Posted by "squidfunk (via GitHub)" <gi...@apache.org>.
squidfunk commented on issue #1097:
URL: https://github.com/apache/incubator-pekko/issues/1097#issuecomment-1926190208
Author of Material for MkDocs here. v5.x is from 2020, so pretty old. We made [significant improvements on search](https://squidfunk.github.io/mkdocs-material/blog/2021/09/13/search-better-faster-smaller/) in [9.x](https://squidfunk.github.io/mkdocs-material/changelog/#9.0.0), which should be twice as fast and significantly cut down on index size, and will be replacing it with an entirely new implementation that will be much faster and more powerful in the near future. Related:
- https://github.com/squidfunk/mkdocs-material/issues/6307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org