You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shiro.apache.org by ka...@apache.org on 2012/02/04 19:26:09 UTC

svn commit: r1240578 - /shiro/trunk/support/openid4j/src/main/java/org/apache/shiro/openid4j/realm/RelyingPartyRealm.java

Author: kaosko
Date: Sat Feb  4 18:26:09 2012
New Revision: 1240578

URL: http://svn.apache.org/viewvc?rev=1240578&view=rev
Log:
Incomplete - SHIRO-21: Add OpenId as an authentication mechanism
- change RelyingPartyRealm to extend AuthenticatingRealm only, openid isn't an authorization protocol

Modified:
    shiro/trunk/support/openid4j/src/main/java/org/apache/shiro/openid4j/realm/RelyingPartyRealm.java

Modified: shiro/trunk/support/openid4j/src/main/java/org/apache/shiro/openid4j/realm/RelyingPartyRealm.java
URL: http://svn.apache.org/viewvc/shiro/trunk/support/openid4j/src/main/java/org/apache/shiro/openid4j/realm/RelyingPartyRealm.java?rev=1240578&r1=1240577&r2=1240578&view=diff
==============================================================================
--- shiro/trunk/support/openid4j/src/main/java/org/apache/shiro/openid4j/realm/RelyingPartyRealm.java (original)
+++ shiro/trunk/support/openid4j/src/main/java/org/apache/shiro/openid4j/realm/RelyingPartyRealm.java Sat Feb  4 18:26:09 2012
@@ -21,10 +21,8 @@ package org.apache.shiro.openid4j.realm;
 import org.apache.shiro.authc.AuthenticationException;
 import org.apache.shiro.authc.AuthenticationInfo;
 import org.apache.shiro.authc.AuthenticationToken;
-import org.apache.shiro.authz.AuthorizationInfo;
 import org.apache.shiro.openid4j.OpenIdService;
-import org.apache.shiro.realm.AuthorizingRealm;
-import org.apache.shiro.subject.PrincipalCollection;
+import org.apache.shiro.realm.AuthenticatingRealm;
 
 /**
  * A {@code Realm} implementation that performs OpenID authentication by acting as the "Relying Party"
@@ -32,7 +30,7 @@ import org.apache.shiro.subject.Principa
  *
  * @since 1.2
  */
-public class RelyingPartyRealm extends AuthorizingRealm {
+public class RelyingPartyRealm extends AuthenticatingRealm {
 
     private OpenIdService openIdService;
 
@@ -48,17 +46,6 @@ public class RelyingPartyRealm extends A
         this.openIdService = openIdService;
     }
 
-    /**
-     * Returns {@code null} always because OpenId does not support authorization operations.
-     *
-     * @param principals the primary identifying principals of the AuthorizationInfo that should be retrieved.
-     * @return {@code null} always because OpenId does not support authorization operations.
-     */
-    @Override
-    protected AuthorizationInfo doGetAuthorizationInfo(PrincipalCollection principals) {
-        return null;
-    }
-
     @Override
     protected AuthenticationInfo doGetAuthenticationInfo(AuthenticationToken token) throws AuthenticationException {