You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by no...@apache.org on 2020/12/29 12:52:07 UTC
[buildstream] branch 239-use-pylint-for-linting created (now
9ab3274)
This is an automated email from the ASF dual-hosted git repository.
not-in-ldap pushed a change to branch 239-use-pylint-for-linting
in repository https://gitbox.apache.org/repos/asf/buildstream.git.
at 9ab3274 Fix bugs and style issues with pylint
This branch includes the following new commits:
new 0595b6a Add pylint to CI
new 6044a88 Add pylint exceptions
new 9ab3274 Fix bugs and style issues with pylint
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[buildstream] 03/03: Fix bugs and style issues with pylint
Posted by no...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
not-in-ldap pushed a commit to branch 239-use-pylint-for-linting
in repository https://gitbox.apache.org/repos/asf/buildstream.git
commit 9ab3274393bda6c25e27c84210a97444cd4d4be4
Author: Tristan Maat <tr...@codethink.co.uk>
AuthorDate: Thu Feb 8 18:15:13 2018 +0000
Fix bugs and style issues with pylint
---
.gitlab-ci.yml | 3 ---
buildstream/_pipeline.py | 2 +-
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 953ede7..ca297a4 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -72,10 +72,7 @@ linting:
variables:
PYTEST_ADDOPTS: "--color=yes"
script:
- - cd dist && ./unpack.sh && cd buildstream
- python3 setup.py test --addopts '--no-cov --pylint --pep8 -m "pep8 or pylint"'
- dependencies:
- - source_dist
# Run premerge commits
#
diff --git a/buildstream/_pipeline.py b/buildstream/_pipeline.py
index 9ce97ce..85c3574 100644
--- a/buildstream/_pipeline.py
+++ b/buildstream/_pipeline.py
@@ -687,7 +687,7 @@ class Pipeline():
if workspace_dir is None:
raise PipelineError("Workspace '{}' is currently not defined"
- .format(target.name + " - " + str(source_index)))
+ .format(target.name))
self.close_workspace(True)
[buildstream] 02/03: Add pylint exceptions
Posted by no...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
not-in-ldap pushed a commit to branch 239-use-pylint-for-linting
in repository https://gitbox.apache.org/repos/asf/buildstream.git
commit 6044a88a398a8603013c2324056336f6727e738a
Author: Tristan Maat <tr...@codethink.co.uk>
AuthorDate: Thu Feb 8 18:15:06 2018 +0000
Add pylint exceptions
---
buildstream/_fuse/fuse.py | 2 ++
buildstream/_plugincontext.py | 4 ++--
buildstream/_signals.py | 4 ++--
buildstream/plugin.py | 2 +-
buildstream/sandbox/_sandboxchroot.py | 2 +-
5 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/buildstream/_fuse/fuse.py b/buildstream/_fuse/fuse.py
index 89173ba..58febcb 100644
--- a/buildstream/_fuse/fuse.py
+++ b/buildstream/_fuse/fuse.py
@@ -19,6 +19,8 @@
# ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
# OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+# pylint: skip-file
+
from __future__ import print_function, absolute_import, division
from ctypes import *
diff --git a/buildstream/_plugincontext.py b/buildstream/_plugincontext.py
index 0e1231e..53821cf 100644
--- a/buildstream/_plugincontext.py
+++ b/buildstream/_plugincontext.py
@@ -93,7 +93,7 @@ class PluginContext():
raise PluginError("Failed to load {} plugin '{}': {}"
.format(self.base_type.__name__, kind, e)) from e
location = package.dist.get_resource_filename(
- pkg_resources._manager,
+ pkg_resources._manager, # pylint: disable=no-member
package.module_name.replace('.', os.sep) + '.py'
)
@@ -101,7 +101,7 @@ class PluginContext():
# may need to extract the file.
try:
defaults = package.dist.get_resource_filename(
- pkg_resources._manager,
+ pkg_resources._manager, # pylint: disable=no-member
package.module_name.replace('.', os.sep) + '.yaml'
)
except KeyError:
diff --git a/buildstream/_signals.py b/buildstream/_signals.py
index ee27190..dfefd22 100644
--- a/buildstream/_signals.py
+++ b/buildstream/_signals.py
@@ -70,7 +70,7 @@ def terminator_handler(signal, frame):
#
@contextmanager
def terminator(terminate_func):
- global terminator_stack
+ global terminator_stack # pylint: disable=global-statement
outermost = False if terminator_stack else True
@@ -130,7 +130,7 @@ def suspend_handler(sig, frame):
#
@contextmanager
def suspendable(suspend_callback, resume_callback):
- global suspendable_stack
+ global suspendable_stack # pylint: disable=global-statement
outermost = False if suspendable_stack else True
suspender = Suspender(suspend_callback, resume_callback)
diff --git a/buildstream/plugin.py b/buildstream/plugin.py
index cd0895f..f4b4444 100644
--- a/buildstream/plugin.py
+++ b/buildstream/plugin.py
@@ -654,7 +654,7 @@ def _plugin_lookup(unique_id):
# No need for unregister, WeakValueDictionary() will remove entries
# in itself when the referenced plugins are garbage collected.
def _plugin_register(plugin):
- global __PLUGINS_UNIQUE_ID
+ global __PLUGINS_UNIQUE_ID # pylint: disable=global-statement
__PLUGINS_UNIQUE_ID += 1
__PLUGINS_TABLE[__PLUGINS_UNIQUE_ID] = plugin
return __PLUGINS_UNIQUE_ID
diff --git a/buildstream/sandbox/_sandboxchroot.py b/buildstream/sandbox/_sandboxchroot.py
index 584f0e1..eedef07 100644
--- a/buildstream/sandbox/_sandboxchroot.py
+++ b/buildstream/sandbox/_sandboxchroot.py
@@ -284,7 +284,7 @@ class SandboxChroot(Sandbox):
# Since the exit stack has already registered a mount
# for this path, we do not need to register another
# umount call.
- root_mount.__enter__()
+ root_mount.__enter__() # pylint: disable=no-member
yield
[buildstream] 01/03: Add pylint to CI
Posted by no...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
not-in-ldap pushed a commit to branch 239-use-pylint-for-linting
in repository https://gitbox.apache.org/repos/asf/buildstream.git
commit 0595b6a973f39bb1385883c9e5c83d45f54c3979
Author: Tristan Maat <tr...@codethink.co.uk>
AuthorDate: Thu Feb 8 14:41:15 2018 +0000
Add pylint to CI
---
.gitlab-ci.yml | 12 ++
.pylintrc | 517 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
setup.cfg | 4 +-
setup.py | 1 +
4 files changed, 532 insertions(+), 2 deletions(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 1e44fc7..953ede7 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -21,6 +21,8 @@ before_script:
- adduser -m buildstream
- chown -R buildstream:buildstream .
+ - pip3 install pytest-pylint
+
#####################################################
# Prepare stage #
#####################################################
@@ -65,6 +67,16 @@ source_dist:
# Test stage #
#####################################################
+linting:
+ stage: test
+ variables:
+ PYTEST_ADDOPTS: "--color=yes"
+ script:
+ - cd dist && ./unpack.sh && cd buildstream
+ - python3 setup.py test --addopts '--no-cov --pylint --pep8 -m "pep8 or pylint"'
+ dependencies:
+ - source_dist
+
# Run premerge commits
#
linux-tests:
diff --git a/.pylintrc b/.pylintrc
new file mode 100644
index 0000000..d1efccd
--- /dev/null
+++ b/.pylintrc
@@ -0,0 +1,517 @@
+[MASTER]
+
+# A comma-separated list of package or module names from where C extensions may
+# be loaded. Extensions are loading into the active Python interpreter and may
+# run arbitrary code
+extension-pkg-whitelist=
+
+# Add files or directories to the blacklist. They should be base names, not
+# paths.
+ignore=CVS,tests,doc
+
+# Add files or directories matching the regex patterns to the blacklist. The
+# regex matches against base names, not paths.
+ignore-patterns=
+
+# Python code to execute, usually for sys.path manipulation such as
+# pygtk.require().
+#init-hook=
+
+# Use multiple processes to speed up Pylint.
+jobs=1
+
+# List of plugins (as comma separated values of python modules names) to load,
+# usually to register additional checkers.
+load-plugins=
+
+# Pickle collected data for later comparisons.
+persistent=yes
+
+# Specify a configuration file.
+#rcfile=
+
+# Allow loading of arbitrary C extensions. Extensions are imported into the
+# active Python interpreter and may run arbitrary code.
+unsafe-load-any-extension=no
+
+
+[MESSAGES CONTROL]
+
+# Only show warnings with the listed confidence levels. Leave empty to show
+# all. Valid levels: HIGH, INFERENCE, INFERENCE_FAILURE, UNDEFINED
+confidence=
+
+# Disable the message, report, category or checker with the given id(s). You
+# can either give multiple identifiers separated by comma (,) or put this
+# option multiple times (only on the command line, not in the configuration
+# file where it should appear only once).You can also use "--disable=all" to
+# disable everything first and then reenable specific checks. For example, if
+# you want to run only the similarities checker, you can use "--disable=all
+# --enable=similarities". If you want to run only the classes checker, but have
+# no Warning level messages displayed, use"--disable=all --enable=classes
+# --disable=W"
+
+# We have two groups of disabled messages:
+#
+# 1) Messages that are of no use to us
+# This is either because we don't follow the convention
+# (missing-docstring and protected-access come to mind), or because
+# it's not very useful in CI (too-many-arguments, for example)
+#
+# 2) Messages that we would like to enable at some point
+# We introduced linting quite late into the project, so there are
+# some issues that just grew out of control. Resolving these would
+# be nice, but too much work atm.
+#
+
+disable=#####################################
+ # Messages that are of no use to us #
+ #####################################
+ ,
+ fixme,
+ missing-docstring,
+ no-self-use,
+ no-else-return,
+ protected-access,
+ too-few-public-methods,
+ too-many-arguments,
+ too-many-boolean-expressions,
+ too-many-branches,
+ too-many-instance-attributes,
+ too-many-lines,
+ too-many-locals,
+ too-many-nested-blocks,
+ too-many-public-methods,
+ too-many-statements,
+ too-many-return-statements,
+
+ #######################################################
+ # Messages that we would like to enable at some point #
+ #######################################################
+ attribute-defined-outside-init,
+
+ # Overriden methods don't actually override but redefine
+ arguments-differ,
+
+ duplicate-code,
+
+ # Some invalid names are alright, we should configure pylint
+ # to accept them, and curb the others
+ invalid-name,
+
+ unused-argument,
+ unused-import,
+ unused-variable,
+
+ ###############################################################
+ # Messages that report things that I think should be fixed as #
+ # part of this branch #
+ ###############################################################
+
+ anomalous-backslash-in-string,
+ bad-continuation,
+ bare-except,
+ broad-except,
+ consider-merging-isinstance,
+ dangerous-default-value,
+ global-statement,
+ len-as-condition,
+ logging-format-interpolation,
+
+ no-member,
+
+ # We use assert(<>), which should perhaps be assert <>
+ superfluous-parens,
+
+ # Some of us like type() - should be discouraged
+ unidiomatic-typecheck,
+
+ # We aren't fully compliant with pep8 import order yet
+ wrong-import-order,
+ wrong-import-position,
+ ungrouped-imports,
+ unnecessary-pass,
+
+ # These are hard to spot without linting, but easy to fix
+ redefined-argument-from-local,
+ redefined-builtin,
+ redefined-outer-name,
+
+ simplifiable-if-statement,
+
+ # These messages occur when excepting a GError - these should
+ # be individually marked
+ # bad-exception-context,
+ # catching-non-exception
+
+
+# Enable the message, report, category or checker with the given id(s). You can
+# either give multiple identifier separated by comma (,) or put this option
+# multiple time (only on the command line, not in the configuration file where
+# it should appear only once). See also the "--disable" option for examples.
+enable=
+
+[REPORTS]
+
+# Python expression which should return a note less than 10 (10 is the highest
+# note). You have access to the variables errors warning, statement which
+# respectively contain the number of errors / warnings messages and the total
+# number of statements analyzed. This is used by the global evaluation report
+# (RP0004).
+evaluation=10.0 - ((float(5 * error + warning + refactor + convention) / statement) * 10)
+
+# Template used to display messages. This is a python new-style format string
+# used to format the message information. See doc for all details
+#msg-template=
+
+# Set the output format. Available formats are text, parseable, colorized, json
+# and msvs (visual studio).You can also give a reporter class, eg
+# mypackage.mymodule.MyReporterClass.
+output-format=colorized
+
+# Tells whether to display a full report or only the messages
+reports=no
+
+# Activate the evaluation score.
+score=yes
+
+
+[REFACTORING]
+
+# Maximum number of nested blocks for function / method body
+max-nested-blocks=5
+
+
+[TYPECHECK]
+
+# List of decorators that produce context managers, such as
+# contextlib.contextmanager. Add to this list to register other decorators that
+# produce valid context managers.
+contextmanager-decorators=contextlib.contextmanager
+
+# List of members which are set dynamically and missed by pylint inference
+# system, and so shouldn't trigger E1101 when accessed. Python regular
+# expressions are accepted.
+generated-members=
+
+# Tells whether missing members accessed in mixin class should be ignored. A
+# mixin class is detected if its name ends with "mixin" (case insensitive).
+ignore-mixin-members=yes
+
+# This flag controls whether pylint should warn about no-member and similar
+# checks whenever an opaque object is returned when inferring. The inference
+# can return multiple potential results while evaluating a Python object, but
+# some branches might not be evaluated, which results in partial inference. In
+# that case, it might be useful to still emit no-member and other checks for
+# the rest of the inferred objects.
+ignore-on-opaque-inference=yes
+
+# List of class names for which member attributes should not be checked (useful
+# for classes with dynamically set attributes). This supports the use of
+# qualified names.
+ignored-classes=optparse.Values,thread._local,_thread._local
+
+# List of module names for which member attributes should not be checked
+# (useful for modules/projects where namespaces are manipulated during runtime
+# and thus existing member attributes cannot be deduced by static analysis. It
+# supports qualified module names, as well as Unix pattern matching.
+ignored-modules=
+
+# Show a hint with possible names when a member name was not found. The aspect
+# of finding the hint is based on edit distance.
+missing-member-hint=yes
+
+# The minimum edit distance a name should have in order to be considered a
+# similar match for a missing member name.
+missing-member-hint-distance=1
+
+# The total number of similar names that should be taken in consideration when
+# showing a hint for a missing member.
+missing-member-max-choices=1
+
+
+[BASIC]
+
+# Naming hint for argument names
+argument-name-hint=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$
+
+# Regular expression matching correct argument names
+argument-rgx=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$
+
+# Naming hint for attribute names
+attr-name-hint=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$
+
+# Regular expression matching correct attribute names
+attr-rgx=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$
+
+# Bad variable names which should always be refused, separated by a comma
+bad-names=foo,bar,baz,toto,tutu,tata
+
+# Naming hint for class attribute names
+class-attribute-name-hint=([A-Za-z_][A-Za-z0-9_]{2,30}|(__.*__))$
+
+# Regular expression matching correct class attribute names
+class-attribute-rgx=([A-Za-z_][A-Za-z0-9_]{2,30}|(__.*__))$
+
+# Naming hint for class names
+class-name-hint=[A-Z_][a-zA-Z0-9]+$
+
+# Regular expression matching correct class names
+class-rgx=[A-Z_][a-zA-Z0-9]+$
+
+# Naming hint for constant names
+const-name-hint=(([A-Z_][A-Z0-9_]*)|(__.*__))$
+
+# Regular expression matching correct constant names
+const-rgx=(([A-Z_][A-Z0-9_]*)|(__.*__))$
+
+# Minimum line length for functions/classes that require docstrings, shorter
+# ones are exempt.
+docstring-min-length=-1
+
+# Naming hint for function names
+function-name-hint=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$
+
+# Regular expression matching correct function names
+function-rgx=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$
+
+# Good variable names which should always be accepted, separated by a comma
+good-names=i,j,k,ex,Run,_,e,f
+
+# Include a hint for the correct naming format with invalid-name
+include-naming-hint=no
+
+# Naming hint for inline iteration names
+inlinevar-name-hint=[A-Za-z_][A-Za-z0-9_]*$
+
+# Regular expression matching correct inline iteration names
+inlinevar-rgx=[A-Za-z_][A-Za-z0-9_]*$
+
+# Naming hint for method names
+method-name-hint=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$
+
+# Regular expression matching correct method names
+method-rgx=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$
+
+# Naming hint for module names
+module-name-hint=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$
+
+# Regular expression matching correct module names
+module-rgx=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$
+
+# Colon-delimited sets of names that determine each other's naming style when
+# the name regexes allow several styles.
+name-group=
+
+# Regular expression which should only match function or class names that do
+# not require a docstring.
+no-docstring-rgx=^_
+
+# List of decorators that produce properties, such as abc.abstractproperty. Add
+# to this list to register other decorators that produce valid properties.
+property-classes=abc.abstractproperty
+
+# Naming hint for variable names
+variable-name-hint=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$
+
+# Regular expression matching correct variable names
+variable-rgx=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$
+
+
+[VARIABLES]
+
+# List of additional names supposed to be defined in builtins. Remember that
+# you should avoid to define new builtins when possible.
+additional-builtins=
+
+# Tells whether unused global variables should be treated as a violation.
+allow-global-unused-variables=yes
+
+# List of strings which can identify a callback function by name. A callback
+# name must start or end with one of those strings.
+callbacks=cb_,_cb
+
+# A regular expression matching the name of dummy variables (i.e. expectedly
+# not used).
+dummy-variables-rgx=_+$|(_[a-zA-Z0-9_]*[a-zA-Z0-9]+?$)|dummy|^ignored_|^unused_
+
+# Argument names that match this expression will be ignored. Default to name
+# with leading underscore
+ignored-argument-names=_.*|^ignored_|^unused_
+
+# Tells whether we should check for unused import in __init__ files.
+init-import=no
+
+# List of qualified module names which can have objects that can redefine
+# builtins.
+redefining-builtins-modules=six.moves,future.builtins
+
+
+[LOGGING]
+
+# Logging modules to check that the string format arguments are in logging
+# function parameter format
+logging-modules=logging
+
+
+[SPELLING]
+
+# Spelling dictionary name. Available dictionaries: none. To make it working
+# install python-enchant package.
+spelling-dict=
+
+# List of comma separated words that should not be checked.
+spelling-ignore-words=
+
+# A path to a file that contains private dictionary; one word per line.
+spelling-private-dict-file=
+
+# Tells whether to store unknown words to indicated private dictionary in
+# --spelling-private-dict-file option instead of raising a message.
+spelling-store-unknown-words=no
+
+
+[MISCELLANEOUS]
+
+# List of note tags to take in consideration, separated by a comma.
+notes=FIXME,XXX,TODO
+
+
+[SIMILARITIES]
+
+# Ignore comments when computing similarities.
+ignore-comments=yes
+
+# Ignore docstrings when computing similarities.
+ignore-docstrings=yes
+
+# Ignore imports when computing similarities.
+ignore-imports=no
+
+# Minimum lines number of a similarity.
+min-similarity-lines=4
+
+
+[FORMAT]
+
+# Expected format of line ending, e.g. empty (any line ending), LF or CRLF.
+expected-line-ending-format=
+
+# Regexp for a line that is allowed to be longer than the limit.
+ignore-long-lines=^\s*(# )?<?https?://\S+>?$
+
+# Number of spaces of indent required inside a hanging or continued line.
+indent-after-paren=4
+
+# String used as indentation unit. This is usually " " (4 spaces) or "\t" (1
+# tab).
+indent-string=' '
+
+# Maximum number of characters on a single line.
+max-line-length=119
+
+# Maximum number of lines in a module
+max-module-lines=1000
+
+# List of optional constructs for which whitespace checking is disabled. `dict-
+# separator` is used to allow tabulation in dicts, etc.: {1 : 1,\n222: 2}.
+# `trailing-comma` allows a space between comma and closing bracket: (a, ).
+# `empty-line` allows space-only lines.
+no-space-check=trailing-comma,dict-separator
+
+# Allow the body of a class to be on the same line as the declaration if body
+# contains single statement.
+single-line-class-stmt=no
+
+# Allow the body of an if to be on the same line as the test if there is no
+# else.
+single-line-if-stmt=no
+
+
+[IMPORTS]
+
+# Allow wildcard imports from modules that define __all__.
+allow-wildcard-with-all=no
+
+# Analyse import fallback blocks. This can be used to support both Python 2 and
+# 3 compatible code, which means that the block might have code that exists
+# only in one or another interpreter, leading to false positives when analysed.
+analyse-fallback-blocks=no
+
+# Deprecated modules which should not be used, separated by a comma
+deprecated-modules=optparse,tkinter.tix
+
+# Create a graph of external dependencies in the given file (report RP0402 must
+# not be disabled)
+ext-import-graph=
+
+# Create a graph of every (i.e. internal and external) dependencies in the
+# given file (report RP0402 must not be disabled)
+import-graph=
+
+# Create a graph of internal dependencies in the given file (report RP0402 must
+# not be disabled)
+int-import-graph=
+
+# Force import order to recognize a module as part of the standard
+# compatibility libraries.
+known-standard-library=
+
+# Force import order to recognize a module as part of a third party library.
+known-third-party=enchant
+
+
+[DESIGN]
+
+# Maximum number of arguments for function / method
+max-args=5
+
+# Maximum number of attributes for a class (see R0902).
+max-attributes=7
+
+# Maximum number of boolean expressions in a if statement
+max-bool-expr=5
+
+# Maximum number of branch for function / method body
+max-branches=12
+
+# Maximum number of locals for function / method body
+max-locals=15
+
+# Maximum number of parents for a class (see R0901).
+max-parents=7
+
+# Maximum number of public methods for a class (see R0904).
+max-public-methods=20
+
+# Maximum number of return / yield for function / method body
+max-returns=6
+
+# Maximum number of statements in function / method body
+max-statements=50
+
+# Minimum number of public methods for a class (see R0903).
+min-public-methods=2
+
+
+[CLASSES]
+
+# List of method names used to declare (i.e. assign) instance attributes.
+defining-attr-methods=__init__,__new__,setUp
+
+# List of member names, which should be excluded from the protected access
+# warning.
+exclude-protected=_asdict,_fields,_replace,_source,_make
+
+# List of valid names for the first argument in a class method.
+valid-classmethod-first-arg=cls
+
+# List of valid names for the first argument in a metaclass class method.
+valid-metaclass-classmethod-first-arg=mcs
+
+
+[EXCEPTIONS]
+
+# Exceptions that will emit a warning when being caught. Defaults to
+# "Exception"
+overgeneral-exceptions=Exception
diff --git a/setup.cfg b/setup.cfg
index 146f153..4540ae9 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -2,8 +2,8 @@
test=pytest
[tool:pytest]
-addopts = --verbose --basetemp ./tmp --pep8 --cov=buildstream --cov-config .coveragerc
-norecursedirs = integration-cache tmp __pycache__
+addopts = --verbose --basetemp ./tmp --pylint-rcfile=.pylintrc --cov=buildstream --cov-config .coveragerc
+norecursedirs = integration-cache tmp __pycache__ .eggs
python_files = tests/*/*.py
pep8maxlinelength = 119
pep8ignore =
diff --git a/setup.py b/setup.py
index 645ebc6..134a614 100755
--- a/setup.py
+++ b/setup.py
@@ -224,6 +224,7 @@ setup(name='BuildStream',
'pytest-datafiles',
'pytest-env',
'pytest-pep8',
+ 'pytest-pylint',
'pytest-cov',
# Provide option to run tests in parallel, less reliable
'pytest-xdist',