[jira] Commented: (JENA-46) Assembler registration improperly located

["Tim Harsch (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JENA-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12992718#comment-12992718 ] 

Tim Harsch commented on JENA-46:
--------------------------------

Agreed it may not be high on the priorities for your team (you should decide), but I only think of it as style because the class has low cohesiveness.  I file this issue because I am attempting to create a triple store implementation for Jena and figuring out how to register the assemblers is one of the first things I must do.  Having the assembly done in a completely unrelated class made discovering the mechanism by which this happens take much more effort than it should have.  So, this is a case where a "style issue" causes some pain and a style fix may save the next pioneer considerable time...  ( I don't generally concern myself with style issues ).


> Assembler registration improperly located
> -----------------------------------------
>
>                 Key: JENA-46
>                 URL: https://issues.apache.org/jira/browse/JENA-46
>             Project: Jena
>          Issue Type: Improvement
>          Components: TDB
>         Environment: TDB 0.8.9
>            Reporter: Tim Harsch
>            Assignee: Andy Seaborne
>            Priority: Trivial
>              Labels: cleanup
>
> VocabTDB: line 73.  Registers the Assemblers for Dataset and Graph and NodeTable
>   ( NOTE: VocabTDB does this as static initialization, VocabTDB is loaded because AssemblerTDB is loaded because TDB is loaded because FusekiCmd is loaded ) 
> The purpose of VocabTDB should be to define vocabulary and not register assemblers.  As such maybe registering of Assemblers should be moved to the class TDB.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira