[jira] [Commented] (SAMZA-25) Add metrics

["Jakob Homan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13764509#comment-13764509 ] 

Jakob Homan commented on SAMZA-25:
----------------------------------

+1.  I had to look up the implicit field usage.  Not sure if that's my blind spot or if it's an esoteric bit of Scala that should be used with caution.  Most likely the former.
                
> Add metrics
> -----------
>
>                 Key: SAMZA-25
>                 URL: https://issues.apache.org/jira/browse/SAMZA-25
>             Project: Samza
>          Issue Type: Bug
>          Components: container, kafka, kv, metrics, yarn
>    Affects Versions: 0.6.0
>            Reporter: Chris Riccomini
>            Assignee: Chris Riccomini
>             Fix For: 0.7.0
>
>         Attachments: SAMZA-25.0.patch
>
>
> The latest refactor dropped a bunch of metrics. We need to re-add them.
> Classes that need metrics:
> * Add metrics to SamzaContainer/SamzaContainerMetrics
> * Add metrics to TaskInstance/TaskInstanceMetrics
> * Add metrics to TaskStorageManager
> * Add metrics to MessageChooser
> * Add metrics to DefaultChooser
> * Add metrics to SystemConsumers
> * Add metrics to SystemProducers
> * Add metrics to KafkaSystemProducer
> * Add metrics to KafkaSystemConsumer
> * Add metrics to CachedStore
> * Add metrics to LoggedStore
> * Add metrics to KeyValueStorageEngine
> * Add metrics to LevelDbKeyValueStore
> We definitely need msgs/sec, bytes/sec at both the container and task level. We also need reads/sec writes/sec on the stores. A lot more, as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira