You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Maarten Coene <ma...@yahoo.com> on 2008/09/29 09:53:00 UTC
Illegal XML in Maven POM's
(moved discussion from ivy-user mailing-list to here)
Xavier,
I already have a patch ready on my machine (it just needs some cleanup and junit testing).
Shall I finish and commit it?
I
agree with you that the better solution would be that the maven people
only post valid XML files into their repositories, but on the other
hand, I think that we should try to make Ivy as tolerant as maven: if
maven can parse it, Ivy should also be able to parse it too. Otherwise,
people will get into trouble when having such kind of dependencies for
which they don't have any control on the pom... and what with invalid
XML's on public maven repositories outside the "control" of apache?
Maarten
----- Original Message ----
From: Xavier Hanin <xa...@gmail.com>
To: ivy-user@ant.apache.org
Sent: Monday, September 29, 2008 9:03:59 AM
Subject: Re: Illegal XML in Maven POM's
On Fri, Sep 26, 2008 at 9:19 PM, Maarten Coene <ma...@yahoo.com>wrote:
> Please open a new Ivy JIRA issue.
I don't think we should open an issue for that. Well, maybe we can open an
issue for consistency, but mark it as invalid. Indeed I don't think
accepting something which is not valid XML makes any sense, it's just too
much work. And maven guys themselves agree that their poms should be valid
xml, there's already been a discussion on the repository@apache.org list
about that. So I don't see much we can do except loby maven guys to make
sure they publish only valid xml poms.
Xavier
>
>
> Maarten
>
>
>
>
> ----- Original Message ----
> From: Hans Dockter <ma...@dockter.biz>
> To: ivy-user@ant.apache.org
> Sent: Friday, September 26, 2008 4:02:09 PM
> Subject: Illegal XML in Maven POM's
>
> Hi,
>
> Maven seems to generate illegal XML for its pom's. For example if the
> developers have a special character in there name.
>
> Two examples:
>
> http://repo1.maven.org/maven2/qdox/qdox/1.6/qdox-1.6.pom
> http://repo1.maven.org/maven2/org/codehaus/plexus/plexus/1.0.4/
> plexus-1.0.4.pom
>
> I have run lately a couple of times into problems with this. Maven
> itself seems to be happy with that. Ivy definitely not:
>
> [ivy:retrieve] :::: ERRORS
> [ivy:retrieve] The entity "oslash" was referenced, but not declared.
>
> I had no time to check the Maven Jira if this is a known bug. My
> posting is just for pointing this out. I'm not sure how far Ivy wants
> to go with the Maven warts reverse engineering ;)
>
> - Hans
>
> --
> Hans Dockter
> Gradle Project lead
> http://www.gradle.org
>
>
>
>
--
Xavier Hanin - Independent Java Consultant
BordeauxJUG co leader - http://www.bordeauxjug.org/
Blogger - http://xhab.blogspot.com/
Apache Ivy Creator - http://ant.apache.org/ivy/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Illegal XML in Maven POM's
Posted by Xavier Hanin <xa...@gmail.com>.
On Mon, Sep 29, 2008 at 9:53 AM, Maarten Coene <ma...@yahoo.com>wrote:
> (moved discussion from ivy-user mailing-list to here)
>
> Xavier,
>
> I already have a patch ready on my machine (it just needs some cleanup and
> junit testing).
Wow, you're fast!
>
> Shall I finish and commit it?
If you already have done much of the job, it's great, go ahead and commit
it. I thought making Ivy invalid xml compliant would require dropping the
use of an xml parser in favor of a text based processing, which would be too
much work. But if you've found a simpler solution that's really nice, I
guess Ivy users will appreciate it.
Xavier
>
>
> I
> agree with you that the better solution would be that the maven people
> only post valid XML files into their repositories, but on the other
> hand, I think that we should try to make Ivy as tolerant as maven: if
> maven can parse it, Ivy should also be able to parse it too. Otherwise,
> people will get into trouble when having such kind of dependencies for
> which they don't have any control on the pom... and what with invalid
> XML's on public maven repositories outside the "control" of apache?
>
> Maarten
>
>
>
> ----- Original Message ----
> From: Xavier Hanin <xa...@gmail.com>
> To: ivy-user@ant.apache.org
> Sent: Monday, September 29, 2008 9:03:59 AM
> Subject: Re: Illegal XML in Maven POM's
>
> On Fri, Sep 26, 2008 at 9:19 PM, Maarten Coene <maarten_coene@yahoo.com
> >wrote:
>
> > Please open a new Ivy JIRA issue.
>
> I don't think we should open an issue for that. Well, maybe we can open an
> issue for consistency, but mark it as invalid. Indeed I don't think
> accepting something which is not valid XML makes any sense, it's just too
> much work. And maven guys themselves agree that their poms should be valid
> xml, there's already been a discussion on the repository@apache.org list
> about that. So I don't see much we can do except loby maven guys to make
> sure they publish only valid xml poms.
>
> Xavier
>
>
> >
> >
> > Maarten
> >
> >
> >
> >
> > ----- Original Message ----
> > From: Hans Dockter <ma...@dockter.biz>
> > To: ivy-user@ant.apache.org
> > Sent: Friday, September 26, 2008 4:02:09 PM
> > Subject: Illegal XML in Maven POM's
> >
> > Hi,
> >
> > Maven seems to generate illegal XML for its pom's. For example if the
> > developers have a special character in there name.
> >
> > Two examples:
> >
> > http://repo1.maven.org/maven2/qdox/qdox/1.6/qdox-1.6.pom
> > http://repo1.maven.org/maven2/org/codehaus/plexus/plexus/1.0.4/
> > plexus-1.0.4.pom
> >
> > I have run lately a couple of times into problems with this. Maven
> > itself seems to be happy with that. Ivy definitely not:
> >
> > [ivy:retrieve] :::: ERRORS
> > [ivy:retrieve] The entity "oslash" was referenced, but not declared.
> >
> > I had no time to check the Maven Jira if this is a known bug. My
> > posting is just for pointing this out. I'm not sure how far Ivy wants
> > to go with the Maven warts reverse engineering ;)
> >
> > - Hans
> >
> > --
> > Hans Dockter
> > Gradle Project lead
> > http://www.gradle.org
> >
> >
> >
> >
>
>
> --
> Xavier Hanin - Independent Java Consultant
> BordeauxJUG co leader - http://www.bordeauxjug.org/
> Blogger - http://xhab.blogspot.com/
> Apache Ivy Creator - http://ant.apache.org/ivy/
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>
--
Xavier Hanin - Independent Java Consultant
BordeauxJUG co leader - http://www.bordeauxjug.org/
Blogger - http://xhab.blogspot.com/
Apache Ivy Creator - http://ant.apache.org/ivy/