You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "upthewaterspout (GitHub)" <gi...@apache.org> on 2020/03/27 22:18:21 UTC

[GitHub] [geode] upthewaterspout opened pull request #4862: GEODE-7919: Moving membership integration test to geode-membership

Moving MembershipOnlyTest to MembershipIntegrationTest in the geode-membership
module and adding some more tests.


[ Full content available at: https://github.com/apache/geode/pull/4862 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] upthewaterspout commented on pull request #4862: GEODE-7919: Moving membership integration test to geode-membership

Posted by "upthewaterspout (GitHub)" <gi...@apache.org>.
Done

[ Full content available at: https://github.com/apache/geode/pull/4862 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] upthewaterspout commented on pull request #4862: GEODE-7919: Moving membership integration test to geode-membership

Posted by "upthewaterspout (GitHub)" <gi...@apache.org>.
Seems like that would just shift the conditional? I think I'll leave it the way it is for now since we want to get rid of this flag entirely when we fix the membership code.

[ Full content available at: https://github.com/apache/geode/pull/4862 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] bschuchardt commented on pull request #4862: GEODE-7919: Moving membership integration test to geode-membership

Posted by "bschuchardt (GitHub)" <gi...@apache.org>.
This should use LocalHostUtil.getLocalHost()

[ Full content available at: https://github.com/apache/geode/pull/4862 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] Bill commented on pull request #4862: GEODE-7919: Moving membership integration test to geode-membership

Posted by "Bill (GitHub)" <gi...@apache.org>.
do we want to say `twoMembershhipsCanStart…` to be consistent w/ other test names?

[ Full content available at: https://github.com/apache/geode/pull/4862 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] upthewaterspout closed pull request #4862: GEODE-7919: Moving membership integration test to geode-membership

Posted by "upthewaterspout (GitHub)" <gi...@apache.org>.
[ pull request closed by upthewaterspout ]

[ Full content available at: https://github.com/apache/geode/pull/4862 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org