You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/23 10:57:53 UTC
[GitHub] [flink] MartijnVisser opened a new pull request, #21371: [FLINK-30166][Connector/FileSystem] Refactor tests that use the deprecated StreamingFileSink instead of FileSink
MartijnVisser opened a new pull request, #21371:
URL: https://github.com/apache/flink/pull/21371
## What is the purpose of the change
* Refactor multiple tests that use the deprecated StreamingFileSink instead of FileSink
## Brief change log
* Replaced StreamingFileSink with FileSink in tests
* Note: not sure if we already should remove the test from 63409894aac1b021f1d14d912ebab50f3d99aaaa but would like to get some input on that from the reviewer
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #21371: [FLINK-30166][Connector/FileSystem] Refactor tests that use the deprecated StreamingFileSink instead of FileSink
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on PR #21371:
URL: https://github.com/apache/flink/pull/21371#issuecomment-1326097684
Very thanks for the fix! I'll have a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser merged pull request #21371: [FLINK-30166][Connector/FileSystem] Refactor tests that use the deprecated StreamingFileSink instead of FileSink
Posted by GitBox <gi...@apache.org>.
MartijnVisser merged PR #21371:
URL: https://github.com/apache/flink/pull/21371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #21371: [FLINK-30166][Connector/FileSystem] Refactor tests that use the deprecated StreamingFileSink instead of FileSink
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #21371:
URL: https://github.com/apache/flink/pull/21371#discussion_r1030332500
##########
flink-formats/flink-compress/src/test/java/org/apache/flink/formats/compress/CompressionFactoryITCase.java:
##########
@@ -71,8 +72,8 @@ void testWriteCompressedFile(@TempDir java.nio.file.Path tmpDir) throws Exceptio
env.addSource(new FiniteTestSource<>(testData), TypeInformation.of(String.class));
stream.map(str -> str)
- .addSink(
- StreamingFileSink.forBulkFormat(
Review Comment:
This should've removed the related import. It didn't because of references in the class javadoc, which also should be updated. also applies to other classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #21371: [FLINK-30166][Connector/FileSystem] Refactor tests that use the deprecated StreamingFileSink instead of FileSink
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on PR #21371:
URL: https://github.com/apache/flink/pull/21371#issuecomment-1362540900
Hi @MartijnVisser sorry I'm get tightly bounded by some internal affairs in recent weeks, and I'll try to have this PR reviewed in this weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a diff in pull request #21371: [FLINK-30166][Connector/FileSystem] Refactor tests that use the deprecated StreamingFileSink instead of FileSink
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on code in PR #21371:
URL: https://github.com/apache/flink/pull/21371#discussion_r1030390708
##########
flink-formats/flink-compress/src/test/java/org/apache/flink/formats/compress/CompressionFactoryITCase.java:
##########
@@ -71,8 +72,8 @@ void testWriteCompressedFile(@TempDir java.nio.file.Path tmpDir) throws Exceptio
env.addSource(new FiniteTestSource<>(testData), TypeInformation.of(String.class));
stream.map(str -> str)
- .addSink(
- StreamingFileSink.forBulkFormat(
Review Comment:
Thanks, fixed those
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #21371: [FLINK-30166][Connector/FileSystem] Refactor tests that use the deprecated StreamingFileSink instead of FileSink
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #21371:
URL: https://github.com/apache/flink/pull/21371#issuecomment-1349895213
@gaoyunhaii Any luck so far?
@JingsongLi Have you thought about what's needed / can be done to completely remove the remaining StreamingFileSink implementation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org