You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Berenguer Blasi (Jira)" <ji...@apache.org> on 2021/03/18 11:24:00 UTC
[jira] [Comment Edited] (CASSANDRA-16185) Add tests to cover
CommitLog metrics
[ https://issues.apache.org/jira/browse/CASSANDRA-16185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17304052#comment-17304052 ]
Berenguer Blasi edited comment on CASSANDRA-16185 at 3/18/21, 11:23 AM:
------------------------------------------------------------------------
I would like to propose this PR:
https://github.com/apache/cassandra/pull/937
Testing metrics you get a dilemma: Either test every place where that metric is being touched, where it would mean testing all commit logs flavours, or help yourself with mocked classes to make sure metrics changes get 'published'. I went for the 2nd. I hope it's ok but happy to hear otherwise.
was (Author: bereng):
I would like to propose this PR:
https://github.com/apache/cassandra/pull/936
Testing metrics you get a dilemma: Either test every place where that metric is being touched, where it would mean testing all commit logs flavours, or help yourself with mocked classes to make sure metrics changes get 'published'. I went for the 2nd. I hope it's ok but happy to hear otherwise.
> Add tests to cover CommitLog metrics
> ------------------------------------
>
> Key: CASSANDRA-16185
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16185
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
> Reporter: Benjamin Lerer
> Assignee: Yasar Arafath Baigh
> Priority: Normal
> Fix For: 4.0-rc
>
> Attachments: 0001-Unit-Test-cases-for-CommitLogMetrics.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The only metrics that seems to be covered by unit test for the CommitLog metrics is {{oversizedMutations}}. We should add testing the other ones.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org