You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "hust-hhb (via GitHub)" <gi...@apache.org> on 2024/02/26 09:34:47 UTC
[PR] [fix](group_commit) GroupCommitBlockSink shoud not use load_block_queue when creating load task fail [doris]
hust-hhb opened a new pull request, #31416:
URL: https://github.com/apache/doris/pull/31416
## Proposed changes
When creating load task fail, wal write maye be null, so need to check nullptr before use it. And the corresponding load_block_queue should not be used to append block.
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](group_commit) GroupCommitBlockSink shoud not use load_block_queue when creating load task fail [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31416:
URL: https://github.com/apache/doris/pull/31416#issuecomment-1963736376
TeamCity be ut coverage result:
Function Coverage: 35.73% (8548/23925)
Line Coverage: 27.53% (69372/252031)
Region Coverage: 26.67% (35967/134848)
Branch Coverage: 23.48% (18383/78308)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0cf076e8a50a197b3f26d1b18a20dac9890013c4_0cf076e8a50a197b3f26d1b18a20dac9890013c4/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](group_commit) GroupCommitBlockSink shoud not use load_block_queue when creating load task fail [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #31416:
URL: https://github.com/apache/doris/pull/31416#issuecomment-1968070995
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](group_commit) GroupCommitBlockSink shoud not use load_block_queue when creating load task fail [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31416:
URL: https://github.com/apache/doris/pull/31416#issuecomment-1968099251
<details>
<summary>TPC-H: <b>Total hot run time: 37526 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0cf076e8a50a197b3f26d1b18a20dac9890013c4, data reload: false
------ Round 1 ----------------------------------
q1 17718 4128 4013 4013
q2 2037 140 134 134
q3 10581 927 924 924
q4 4649 933 914 914
q5 7621 2877 2957 2877
q6 179 120 117 117
q7 1245 758 746 746
q8 9250 1982 2004 1982
q9 7118 6208 6246 6208
q10 8152 2466 2495 2466
q11 410 217 208 208
q12 804 306 299 299
q13 17916 3184 3193 3184
q14 266 262 255 255
q15 520 493 481 481
q16 494 396 408 396
q17 928 891 876 876
q18 6714 6093 5844 5844
q19 1557 1504 1499 1499
q20 549 277 272 272
q21 6792 3534 3559 3534
q22 799 297 300 297
Total cold run time: 106299 ms
Total hot run time: 37526 ms
----- Round 2, with runtime_filter_mode=off -----
q1 3998 4004 3980 3980
q2 306 217 214 214
q3 2959 2935 2930 2930
q4 1825 1804 1801 1801
q5 5075 5068 5045 5045
q6 196 114 114 114
q7 2152 1673 1746 1673
q8 3096 3161 3194 3161
q9 8251 8206 8222 8206
q10 6080 3643 3632 3632
q11 498 412 425 412
q12 689 566 534 534
q13 9894 3058 3081 3058
q14 268 249 261 249
q15 542 492 489 489
q16 493 461 446 446
q17 1705 1676 1665 1665
q18 7796 7436 7482 7436
q19 1654 1628 1625 1625
q20 2086 1890 1883 1883
q21 4814 4601 4582 4582
q22 527 431 435 431
Total cold run time: 64904 ms
Total hot run time: 53566 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](group_commit) GroupCommitBlockSink shoud not use load_block_queue when creating load task fail [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31416:
URL: https://github.com/apache/doris/pull/31416#issuecomment-1963700015
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](group_commit) GroupCommitBlockSink shoud not use load_block_queue when creating load task fail [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31416:
URL: https://github.com/apache/doris/pull/31416#issuecomment-1963744414
<details>
<summary>TPC-H: <b>Total hot run time: 38136 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0cf076e8a50a197b3f26d1b18a20dac9890013c4, data reload: false
------ Round 1 ----------------------------------
q1 17895 4058 4022 4022
q2 2034 137 130 130
q3 10590 950 921 921
q4 5546 930 939 930
q5 7972 2832 3002 2832
q6 177 124 121 121
q7 1235 773 745 745
q8 9345 1975 2011 1975
q9 7213 6293 6261 6261
q10 8193 2526 2517 2517
q11 409 214 208 208
q12 757 308 318 308
q13 19658 3272 3232 3232
q14 277 281 246 246
q15 543 501 503 501
q16 486 404 410 404
q17 946 905 868 868
q18 7753 6299 6572 6299
q19 2631 1471 1544 1471
q20 918 280 266 266
q21 6967 3588 3613 3588
q22 808 306 291 291
Total cold run time: 112353 ms
Total hot run time: 38136 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4054 3997 4053 3997
q2 549 208 222 208
q3 2954 2922 2902 2902
q4 1798 1794 1817 1794
q5 5069 5064 5110 5064
q6 198 116 119 116
q7 2142 1657 1689 1657
q8 3112 3166 3183 3166
q9 8183 8242 8214 8214
q10 6073 3644 3665 3644
q11 501 425 427 425
q12 678 537 512 512
q13 12416 3066 3007 3007
q14 272 249 268 249
q15 534 484 494 484
q16 500 484 455 455
q17 1678 1662 1678 1662
q18 7885 7446 7409 7409
q19 1837 1632 1625 1625
q20 2097 1927 1899 1899
q21 4763 4584 4578 4578
q22 541 448 437 437
Total cold run time: 67834 ms
Total hot run time: 53504 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](group_commit) GroupCommitBlockSink shoud not use load_block_queue when creating load task fail [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31416:
URL: https://github.com/apache/doris/pull/31416#issuecomment-1963765231
<details>
<summary>TPC-DS: <b>Total hot run time: 168741 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0cf076e8a50a197b3f26d1b18a20dac9890013c4, data reload: false
query1 935 339 335 335
query2 6534 1874 1766 1766
query3 6707 201 204 201
query4 23556 20511 20427 20427
query5 4233 364 357 357
query6 256 169 163 163
query7 4604 303 303 303
query8 264 200 199 199
query9 8515 2170 2176 2170
query10 416 210 222 210
query11 14631 14168 14261 14168
query12 130 82 83 82
query13 1643 429 431 429
query14 8695 6294 6339 6294
query15 209 168 172 168
query16 7090 256 259 256
query17 1037 511 496 496
query18 1894 272 266 266
query19 198 151 148 148
query20 86 77 85 77
query21 192 127 124 124
query22 4911 4757 4363 4363
query23 30470 29921 30054 29921
query24 11783 3049 3052 3049
query25 661 358 345 345
query26 1839 152 160 152
query27 3049 317 336 317
query28 6992 1790 1781 1781
query29 1182 556 558 556
query30 281 133 137 133
query31 869 682 682 682
query32 96 57 55 55
query33 716 224 231 224
query34 1049 480 496 480
query35 844 745 736 736
query36 936 895 852 852
query37 161 65 60 60
query38 3064 3023 3033 3023
query39 1311 1256 1258 1256
query40 282 94 101 94
query41 36 34 36 34
query42 106 95 93 93
query43 450 436 426 426
query44 1074 696 706 696
query45 189 181 173 173
query46 1035 779 791 779
query47 1550 1470 1453 1453
query48 420 339 339 339
query49 1171 303 276 276
query50 775 385 376 376
query51 4299 4308 4278 4278
query52 95 101 86 86
query53 331 268 260 260
query54 293 233 225 225
query55 86 83 79 79
query56 228 199 203 199
query57 960 896 909 896
query58 205 190 193 190
query59 2183 2175 2166 2166
query60 249 217 221 217
query61 81 81 80 80
query62 607 365 359 359
query63 285 257 262 257
query64 6558 2929 3158 2929
query65 3225 3202 3186 3186
query66 1455 324 316 316
query67 14653 14244 14004 14004
query68 4071 583 561 561
query69 521 372 376 372
query70 1269 1216 1185 1185
query71 333 247 251 247
query72 6167 2767 2623 2623
query73 719 347 336 336
query74 6341 6104 6038 6038
query75 3096 2430 2391 2391
query76 2688 1054 1149 1054
query77 337 234 227 227
query78 9006 8527 8322 8322
query79 1577 519 531 519
query80 1034 374 336 336
query81 504 200 195 195
query82 942 86 81 81
query83 223 120 119 119
query84 272 81 76 76
query85 1270 360 341 341
query86 465 299 301 299
query87 3302 3087 3078 3078
query88 2805 2403 2383 2383
query89 382 373 313 313
query90 1921 162 167 162
query91 150 121 124 121
query92 54 48 48 48
query93 1324 514 506 506
query94 1252 178 181 178
query95 437 334 341 334
query96 576 273 271 271
query97 4224 4109 4089 4089
query98 220 222 195 195
query99 1065 651 676 651
Total cold run time: 263467 ms
Total hot run time: 168741 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](group_commit) GroupCommitBlockSink shoud not use load_block_queue when creating load task fail [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31416:
URL: https://github.com/apache/doris/pull/31416#issuecomment-1963681302
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](group_commit) GroupCommitBlockSink shoud not use load_block_queue when creating load task fail [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31416:
URL: https://github.com/apache/doris/pull/31416#issuecomment-1968122098
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 0cf076e8a50a197b3f26d1b18a20dac9890013c4 with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 60 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select: 18.1 seconds inserted 10000000 Rows, about 552K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](group_commit) GroupCommitBlockSink shoud not use load_block_queue when creating load task fail [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31416:
URL: https://github.com/apache/doris/pull/31416#issuecomment-1963782100
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 0cf076e8a50a197b3f26d1b18a20dac9890013c4 with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select: 15.0 seconds inserted 10000000 Rows, about 666K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](group_commit) GroupCommitBlockSink shoud not use load_block_queue when creating load task fail [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31416:
URL: https://github.com/apache/doris/pull/31416#issuecomment-1963775923
<details>
<summary>ClickBench: <b>Total hot run time: 31.2 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0cf076e8a50a197b3f26d1b18a20dac9890013c4, data reload: false
query1 0.04 0.03 0.03
query2 0.06 0.02 0.03
query3 0.23 0.06 0.06
query4 1.66 0.10 0.10
query5 0.52 0.51 0.51
query6 1.22 0.67 0.66
query7 0.02 0.01 0.01
query8 0.04 0.02 0.02
query9 0.56 0.51 0.51
query10 0.56 0.55 0.56
query11 0.13 0.10 0.09
query12 0.12 0.10 0.10
query13 0.63 0.61 0.62
query14 0.78 0.82 0.80
query15 0.84 0.82 0.82
query16 0.36 0.36 0.37
query17 0.97 1.02 0.97
query18 0.26 0.25 0.24
query19 1.79 1.66 1.70
query20 0.01 0.01 0.02
query21 15.40 0.64 0.61
query22 3.61 4.29 1.68
query23 17.36 1.05 1.12
query24 2.08 0.75 0.21
query25 0.42 0.11 0.07
query26 0.19 0.15 0.16
query27 0.06 0.05 0.04
query28 12.05 0.85 0.81
query29 12.64 3.15 3.28
query30 0.54 0.53 0.46
query31 2.79 0.35 0.35
query32 3.35 0.49 0.48
query33 3.20 3.20 3.21
query34 15.35 4.74 4.73
query35 4.75 4.75 4.77
query36 1.14 1.06 1.07
query37 0.06 0.05 0.05
query38 0.04 0.03 0.03
query39 0.02 0.02 0.02
query40 0.16 0.14 0.13
query41 0.07 0.01 0.02
query42 0.03 0.01 0.02
query43 0.03 0.02 0.02
Total cold run time: 106.14 s
Total hot run time: 31.2 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](group_commit) GroupCommitBlockSink shoud not use load_block_queue when creating load task fail [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31416:
URL: https://github.com/apache/doris/pull/31416#issuecomment-1968108709
<details>
<summary>TPC-DS: <b>Total hot run time: 169078 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0cf076e8a50a197b3f26d1b18a20dac9890013c4, data reload: false
query1 920 335 330 330
query2 6543 1726 1859 1726
query3 6697 213 212 212
query4 23581 20486 20509 20486
query5 4249 374 365 365
query6 266 165 164 164
query7 4603 292 293 292
query8 260 201 201 201
query9 8486 2213 2204 2204
query10 418 221 219 219
query11 14615 14188 14198 14188
query12 134 80 81 80
query13 1647 437 432 432
query14 8529 6391 6519 6391
query15 209 169 172 169
query16 7088 257 254 254
query17 1036 505 504 504
query18 1901 261 275 261
query19 201 157 156 156
query20 86 80 83 80
query21 207 128 115 115
query22 4691 4596 4499 4499
query23 30525 29823 29913 29823
query24 11758 3115 3093 3093
query25 647 356 344 344
query26 1878 152 159 152
query27 3027 310 322 310
query28 6992 1776 1768 1768
query29 1251 560 556 556
query30 286 133 140 133
query31 858 691 692 691
query32 98 59 58 58
query33 718 231 226 226
query34 1037 476 484 476
query35 840 744 741 741
query36 978 829 885 829
query37 186 59 60 59
query38 3095 3022 3003 3003
query39 1313 1266 1243 1243
query40 275 102 100 100
query41 37 36 35 35
query42 106 95 94 94
query43 463 492 438 438
query44 1071 679 688 679
query45 189 177 171 171
query46 1046 811 777 777
query47 1517 1438 1401 1401
query48 409 364 336 336
query49 1200 286 278 278
query50 776 374 366 366
query51 4345 4272 4326 4272
query52 101 89 93 89
query53 336 264 264 264
query54 289 231 229 229
query55 85 90 80 80
query56 220 195 203 195
query57 989 877 895 877
query58 216 192 192 192
query59 2239 2251 2103 2103
query60 243 223 210 210
query61 86 87 91 87
query62 595 365 364 364
query63 285 256 253 253
query64 6508 2986 3109 2986
query65 3223 3214 3182 3182
query66 1444 317 309 309
query67 14370 14202 14249 14202
query68 5026 546 559 546
query69 538 390 378 378
query70 1218 1229 1177 1177
query71 356 252 245 245
query72 6262 2847 2630 2630
query73 707 316 318 316
query74 6377 6009 5986 5986
query75 3063 2412 2392 2392
query76 2884 1044 1138 1044
query77 350 238 233 233
query78 9053 8578 8525 8525
query79 1005 540 519 519
query80 619 368 347 347
query81 455 195 198 195
query82 669 81 80 80
query83 238 119 120 119
query84 279 77 74 74
query85 954 347 345 345
query86 324 263 298 263
query87 3235 3113 3078 3078
query88 2718 2337 2299 2299
query89 390 324 327 324
query90 2014 162 166 162
query91 152 123 141 123
query92 55 47 46 46
query93 1037 500 491 491
query94 1097 170 174 170
query95 432 333 340 333
query96 575 268 262 262
query97 4210 4163 4146 4146
query98 216 204 198 198
query99 1017 651 630 630
Total cold run time: 262042 ms
Total hot run time: 169078 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](group_commit) GroupCommitBlockSink shoud not use load_block_queue when creating load task fail [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31416:
URL: https://github.com/apache/doris/pull/31416#issuecomment-1963915020
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](group_commit) GroupCommitBlockSink shoud not use load_block_queue when creating load task fail [doris]
Posted by "hust-hhb (via GitHub)" <gi...@apache.org>.
hust-hhb commented on PR #31416:
URL: https://github.com/apache/doris/pull/31416#issuecomment-1963681485
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](group_commit) GroupCommitBlockSink shoud not use load_block_queue when creating load task fail [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31416:
URL: https://github.com/apache/doris/pull/31416#issuecomment-1968092208
TeamCity be ut coverage result:
Function Coverage: 35.69% (8547/23951)
Line Coverage: 27.49% (69376/252402)
Region Coverage: 26.65% (35980/134999)
Branch Coverage: 23.45% (18387/78394)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0cf076e8a50a197b3f26d1b18a20dac9890013c4_0cf076e8a50a197b3f26d1b18a20dac9890013c4/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](group_commit) GroupCommitBlockSink shoud not use load_block_queue when creating load task fail [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31416:
URL: https://github.com/apache/doris/pull/31416#issuecomment-1968117416
<details>
<summary>ClickBench: <b>Total hot run time: 33.04 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0cf076e8a50a197b3f26d1b18a20dac9890013c4, data reload: false
query1 0.04 0.04 0.03
query2 0.06 0.02 0.02
query3 0.23 0.06 0.06
query4 1.68 0.10 0.10
query5 0.52 0.52 0.51
query6 1.30 0.67 0.66
query7 0.02 0.01 0.02
query8 0.04 0.03 0.03
query9 0.55 0.51 0.51
query10 0.58 0.55 0.56
query11 0.13 0.10 0.10
query12 0.12 0.10 0.10
query13 0.62 0.62 0.62
query14 0.77 0.80 0.80
query15 0.85 0.82 0.81
query16 0.39 0.39 0.37
query17 0.98 0.95 0.97
query18 0.25 0.25 0.26
query19 1.79 1.70 1.68
query20 0.02 0.01 0.01
query21 15.42 0.60 0.65
query22 3.47 4.64 3.19
query23 17.40 1.03 0.97
query24 1.98 0.38 0.56
query25 0.54 0.09 0.06
query26 0.17 0.14 0.16
query27 0.05 0.04 0.04
query28 12.13 0.85 0.86
query29 12.67 3.46 3.39
query30 0.59 0.53 0.50
query31 2.79 0.35 0.36
query32 3.37 0.47 0.48
query33 3.16 3.20 3.18
query34 15.36 4.76 4.72
query35 4.76 4.73 4.72
query36 1.13 1.05 1.06
query37 0.06 0.05 0.05
query38 0.04 0.03 0.03
query39 0.02 0.02 0.01
query40 0.15 0.13 0.14
query41 0.07 0.02 0.01
query42 0.02 0.01 0.02
query43 0.02 0.02 0.02
Total cold run time: 106.31 s
Total hot run time: 33.04 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](group_commit) GroupCommitBlockSink shoud not use load_block_queue when creating load task fail [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31416:
URL: https://github.com/apache/doris/pull/31416#issuecomment-1968986866
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](group_commit) GroupCommitBlockSink shoud not use load_block_queue when creating load task fail [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #31416:
URL: https://github.com/apache/doris/pull/31416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org