You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/06/09 15:37:48 UTC

[GitHub] [systemds] sebwrede commented on a change in pull request #1303: [SYSTEMDS-2994+2991] CLA Workload Analyzer and Workload Representation

sebwrede commented on a change in pull request #1303:
URL: https://github.com/apache/systemds/pull/1303#discussion_r648435211



##########
File path: src/main/java/org/apache/sysds/runtime/compress/CompressedMatrixBlockFactory.java
##########
@@ -88,6 +89,10 @@ private CompressedMatrixBlockFactory(MatrixBlock mb, int k, CompressionSettings
 		return compress(mb, k, new CompressionSettingsBuilder().create());
 	}
 
+	public static Pair<MatrixBlock, CompressionStatistics> compress(MatrixBlock mb, int k, WTreeRoot root){
+		return compress(mb, k, new CompressionSettingsBuilder().create());
+	}

Review comment:
       You are not using root in this method. Is this on purpose? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org