You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Jeff Hagelberg <jn...@us.ibm.com> on 2017/02/23 01:51:01 UTC
Review Request 56963: DSL queries returns wrong object when filter
traverses edges
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56963/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-1589
https://issues.apache.org/jira/browse/ATLAS-1589
Repository: atlas
Description
-------
In Atlas 0.7, the following DSL query returns hive_table entities whose db.name=\u2019default\u2019.
api/atlas/discovery/search/dsl?limit=25&query=hive_table+db.name%3D%27default%27
However, with the latest Atlas in master, the query returns the hive_db entity, instead of hive_table entities.
Diffs
-----
repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 2863aca1a1bfa7cd200230b314ddb9954266fe87
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java ffda9849e9632bff6764aed70c76a2f50f493d0d
Diff: https://reviews.apache.org/r/56963/diff/
Testing
-------
Ran repository tests, everything passed on Windows except the expected hbase tests. Running full test suite on Linux.
Thanks,
Jeff Hagelberg
Re: Review Request 56963: DSL queries returns wrong object when filter
traverses edges
Posted by Jeff Hagelberg <jn...@us.ibm.com>.
> On Feb. 23, 2017, 2:28 a.m., Suma Shivaprasad wrote:
> > Ship It!
I'm seeing a couple new test failures in webapp with this fix. I'll investigate those tomorrow and keep you updated.
- Jeff
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56963/#review166467
-----------------------------------------------------------
On Feb. 23, 2017, 1:51 a.m., Jeff Hagelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56963/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2017, 1:51 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1589
> https://issues.apache.org/jira/browse/ATLAS-1589
>
>
> Repository: atlas
>
>
> Description
> -------
>
> In Atlas 0.7, the following DSL query returns hive_table entities whose db.name=\u2019default\u2019.
> api/atlas/discovery/search/dsl?limit=25&query=hive_table+db.name%3D%27default%27
>
> However, with the latest Atlas in master, the query returns the hive_db entity, instead of hive_table entities.
>
>
> Diffs
> -----
>
> repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 2863aca1a1bfa7cd200230b314ddb9954266fe87
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java ffda9849e9632bff6764aed70c76a2f50f493d0d
>
> Diff: https://reviews.apache.org/r/56963/diff/
>
>
> Testing
> -------
>
> Ran repository tests, everything passed on Windows except the expected hbase tests. Running full test suite on Linux.
>
>
> Thanks,
>
> Jeff Hagelberg
>
>
Re: Review Request 56963: DSL queries returns wrong object when filter
traverses edges
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56963/#review166467
-----------------------------------------------------------
Ship it!
Ship It!
- Suma Shivaprasad
On Feb. 23, 2017, 1:51 a.m., Jeff Hagelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56963/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2017, 1:51 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1589
> https://issues.apache.org/jira/browse/ATLAS-1589
>
>
> Repository: atlas
>
>
> Description
> -------
>
> In Atlas 0.7, the following DSL query returns hive_table entities whose db.name=\u2019default\u2019.
> api/atlas/discovery/search/dsl?limit=25&query=hive_table+db.name%3D%27default%27
>
> However, with the latest Atlas in master, the query returns the hive_db entity, instead of hive_table entities.
>
>
> Diffs
> -----
>
> repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 2863aca1a1bfa7cd200230b314ddb9954266fe87
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java ffda9849e9632bff6764aed70c76a2f50f493d0d
>
> Diff: https://reviews.apache.org/r/56963/diff/
>
>
> Testing
> -------
>
> Ran repository tests, everything passed on Windows except the expected hbase tests. Running full test suite on Linux.
>
>
> Thanks,
>
> Jeff Hagelberg
>
>
Re: Review Request 56963: DSL queries returns wrong object when filter
traverses edges
Posted by Jeff Hagelberg <jn...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56963/
-----------------------------------------------------------
(Updated Feb. 23, 2017, 5:16 p.m.)
Review request for atlas.
Changes
-------
Addressed defect in GremlinQueryOptimizer exposed by these changes.
Bugs: ATLAS-1589
https://issues.apache.org/jira/browse/ATLAS-1589
Repository: atlas
Description
-------
In Atlas 0.7, the following DSL query returns hive_table entities whose db.name=\u2019default\u2019.
api/atlas/discovery/search/dsl?limit=25&query=hive_table+db.name%3D%27default%27
However, with the latest Atlas in master, the query returns the hive_db entity, instead of hive_table entities.
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java 798d9099f8999c98ac14b6060179add76e5a2ff4
repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java add7e07006190247112eeba1ca85d62b6f5c2a08
repository/src/main/java/org/apache/atlas/gremlin/GremlinExpressionFactory.java c2fdf092d2078749a0d43d5c55be5d87fd24fc4e
repository/src/main/java/org/apache/atlas/gremlin/optimizer/ExpandOrsOptimization.java ba6059a32e9ca2b36dc121ae4d8c209aa567bddc
repository/src/main/java/org/apache/atlas/gremlin/optimizer/RepeatExpressionFinder.java PRE-CREATION
repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 2863aca1a1bfa7cd200230b314ddb9954266fe87
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java ffda9849e9632bff6764aed70c76a2f50f493d0d
Diff: https://reviews.apache.org/r/56963/diff/
Testing
-------
Ran repository tests, everything passed on Windows except the expected hbase tests. Running full test suite on Linux.
Thanks,
Jeff Hagelberg