You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "toaditi (via GitHub)" <gi...@apache.org> on 2026/05/15 14:50:35 UTC

[PR] Improved: Sync developers.tpl.php template with merged HTML changes from #15 [ofbiz-site]

toaditi opened a new pull request, #16:
URL: https://github.com/apache/ofbiz-site/pull/16

   ## Summary
   Follow-up to #15 (review feedback from @ashishvijaywargiya).
   
   PR #15 was merged but updated only `developers.html` directly. Per the [site README](https://github.com/apache/ofbiz-site/blob/master/README.md), edits must be made to the PHP templates under `template/page/` and the HTML must be regenerated with `./php2html.sh`. This PR applies the same edits to `template/page/developers.tpl.php` so the template (source of truth) matches the already-merged HTML.
   
   ## What's in this PR
   - Updates `template/page/developers.tpl.php` to mirror the content changes from #15:
     - New "Initialize Gradle Wrapper" section with `init-gradle-wrapper` / `./gradle/init-gradle-wrapper.sh` instructions
     - JDK 17 noted for trunk (JDK 11 retained for release 18.12), plus `$JAVA_HOME`, PowerShell ≥ 7.1.3, and "no spaces in install path" notes
     - Sidebar nav entry for the new section
     - "Building the Trunk" reordered before "Building Release 18.12"; start/run heading reworded to "trunk or 18.12"
   
   ## Why no HTML diff
   Running `./php2html.sh` against the updated template produces an HTML output identical to the already-merged `developers.html`. Verified locally:
   
   ```
   $ ./php2html.sh
   $ git diff --stat developers.html
   (no diff)
   ```
   
   So no HTML changes are included in this commit — the existing HTML and the updated template are now in sync.
   
   ## Test plan
   - [ ] Reviewer can run `./php2html.sh` and confirm `developers.html` is unchanged.
   - [ ] Verify `template/page/developers.tpl.php` content matches the rendered page on https://ofbiz.apache.org/developers.html.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improved: Sync developers.tpl.php template with merged HTML changes from #15 [ofbiz-site]

Posted by "jacopoc (via GitHub)" <gi...@apache.org>.
jacopoc commented on PR #16:
URL: https://github.com/apache/ofbiz-site/pull/16#issuecomment-4495556643

   @ashishvijaywargiya Since PR #15 by @toaditi has been merged, the developers.html page is now out of sync with its template. Could you please review and merge this pull request to complete and align the previously committed work? Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improved: Sync developers.tpl.php template with merged HTML changes from #15 [ofbiz-site]

Posted by "jacopoc (via GitHub)" <gi...@apache.org>.
jacopoc commented on code in PR #16:
URL: https://github.com/apache/ofbiz-site/pull/16#discussion_r3249116329


##########
template/page/developers.tpl.php:
##########
@@ -66,26 +70,40 @@
 
     </div>
             </section>
+      <section  id="DevGradle" class="slice row clearfix">
+              <div class="span10">
+                <h2>Initialize Gradle Wrapper</h2>
+                <div class="divider"><span></span></div>
+                <p>The Gradle wrapper is no longer bundled with the ofbiz-framework trunk source. Before running any <code>gradlew</code> command you must download the wrapper from the OFBiz top-level directory.</p>
+                <p>Run the following command for Unix-like OS</p>
+                <code>./gradle/init-gradle-wrapper.sh</code><p></p>
+                <p>Run the following command for MS Windows</p>
+                <code>init-gradle-wrapper</code>
+                <p></p>
+                <p><strong>NOTE:</strong> On Windows, if you encounter an error such as "Powershell is not recognized as an internal or external command, operable program or batch file", follow the advice at <a href="https://s.apache.org/vdcv8" target="external">https://s.apache.org/vdcv8</a>. If you run into problems, check the execution policy of PowerShell (see <a href="https://s.apache.org/urnju" target="external">https://s.apache.org/urnju</a>). By setting the execution policy to "unrestricted", you will be prompted to run the script once you run the <code>init-gradle-wrapper</code> command.</p>
+                <p><strong>NOTE:</strong> This step is only required once per checkout. Existing release branches (such as release18.12) ship the Gradle wrapper inside the repository and do not require this step.</p>

Review Comment:
   This is no longer true since release24.09



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improved: Sync developers.tpl.php template with merged HTML changes from #15 [ofbiz-site]

Posted by "ashishvijaywargiya (via GitHub)" <gi...@apache.org>.
ashishvijaywargiya commented on PR #16:
URL: https://github.com/apache/ofbiz-site/pull/16#issuecomment-4708924120

   Thank you @golja! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improved: Sync developers.tpl.php template with merged HTML changes from #15 [ofbiz-site]

Posted by "ashishvijaywargiya (via GitHub)" <gi...@apache.org>.
ashishvijaywargiya merged PR #16:
URL: https://github.com/apache/ofbiz-site/pull/16


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improved: Sync developers.tpl.php template with merged HTML changes from #15 [ofbiz-site]

Posted by "ashishvijaywargiya (via GitHub)" <gi...@apache.org>.
ashishvijaywargiya commented on PR #16:
URL: https://github.com/apache/ofbiz-site/pull/16#issuecomment-4497909393

   > @ashishvijaywargiya Since PR #15 by @toaditi has been merged, the developers.html page is now out of sync with its template. Could you please review and merge this pull request to complete and align the previously committed work? Thank you.
   
   Done @jacopoc, Thank you. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improved: Sync developers.tpl.php template with merged HTML changes from #15 [ofbiz-site]

Posted by "golja (via GitHub)" <gi...@apache.org>.
golja commented on PR #16:
URL: https://github.com/apache/ofbiz-site/pull/16#issuecomment-4680002013

   Hi @ashishvijaywargiya, hi @toaditi, 
   the commit "Simplify note on Gradle wrapper setup" 1e0250540c8915f9aab306434a30cc11d08336ab introduced a discrepancy between the developers.tpl.php template and developers.html. This issue has been fixed with PR #23 
   Have a nice day!
   Anahita


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org