You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/02/16 15:26:20 UTC
[GitHub] [superset] geido opened a new pull request #18752: [WIP]: fix: Bar chart order
geido opened a new pull request #18752:
URL: https://github.com/apache/superset/pull/18752
### SUMMARY
The goal of this PR is to fix the order of the Bar chart
### BEFORE
https://user-images.githubusercontent.com/60598000/154296688-96327e55-73d1-42f6-a41e-7137fce73b8b.mp4
### AFTER
https://user-images.githubusercontent.com/60598000/154297218-6815a418-793c-49a2-b66b-08b6abaf981c.mp4
### TESTING INSTRUCTIONS
1. Open the sample Total Sales per Market (Grouped by Genre) Bar chart
2. Add a sort by metric
3. Make sure the order is correct
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa commented on pull request #18752: fix: Bar chart order
Posted by GitBox <gi...@apache.org>.
jinghua-qa commented on pull request #18752:
URL: https://github.com/apache/superset/pull/18752#issuecomment-1044192332
I found an issue that the when i put different sort by values, the order still stay the same. For example, i use sort by sum(na_sales )and sum(eu_sales), the series are in the same order, and it is not in the order of what i selected.
<img width="1792" alt="Screen Shot 2022-02-18 at 12 53 02 AM" src="https://user-images.githubusercontent.com/81597121/154652107-fd8535a2-cd51-4029-8ed4-787a1ce953de.png">
<img width="1792" alt="Screen Shot 2022-02-18 at 12 53 45 AM" src="https://user-images.githubusercontent.com/81597121/154652128-d1f9a053-b944-4eb4-b978-5530975dac12.png">
I think the current behavior on master is making more sense, when i select sort by sum(na_sales), the bar series show in order sum.
For example sort by sum(na_sales)
<img width="1787" alt="Screen Shot 2022-02-18 at 1 11 17 AM" src="https://user-images.githubusercontent.com/81597121/154652798-206f7a7d-e07a-48b7-8e1b-0ee49f897871.png">
<img width="1792" alt="Screen Shot 2022-02-18 at 1 13 08 AM" src="https://user-images.githubusercontent.com/81597121/154653073-03114a52-9326-4d07-b0d7-402407ce3ddd.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #18752: fix: Bar chart order
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #18752:
URL: https://github.com/apache/superset/pull/18752#issuecomment-1044927916
Ok I am closing this PR as this is irrelevant. The actual issue is happening on the Time-series Bar Chart V2. We will move the discussion forward and open another PR for that. Thanks @jinghua-qa !!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #18752: fix: Bar chart order
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #18752:
URL: https://github.com/apache/superset/pull/18752#issuecomment-1042893193
# [Codecov](https://codecov.io/gh/apache/superset/pull/18752?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18752](https://codecov.io/gh/apache/superset/pull/18752?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cc7eb12) into [master](https://codecov.io/gh/apache/superset/commit/57c4d0f9a42d875d701e94044a5e0eee550d0ab7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (57c4d0f) will **decrease** coverage by `0.01%`.
> The diff coverage is `72.72%`.
> :exclamation: Current head cc7eb12 differs from pull request most recent head 3e9d252. Consider uploading reports for the commit 3e9d252 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/18752?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18752 +/- ##
==========================================
- Coverage 66.32% 66.30% -0.02%
==========================================
Files 1620 1620
Lines 63061 63098 +37
Branches 6368 6372 +4
==========================================
+ Hits 41824 41840 +16
- Misses 19579 19601 +22
+ Partials 1658 1657 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.24% <65.38%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/18752?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...s/legacy-plugin-chart-country-map/src/countries.ts](https://codecov.io/gh/apache/superset/pull/18752/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9jb3VudHJpZXMudHM=) | `100.00% <ø> (ø)` | |
| [...nd/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js](https://codecov.io/gh/apache/superset/pull/18752/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL05WRDNWaXMuanM=) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-preset-chart-nvd3/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/18752/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL3RyYW5zZm9ybVByb3BzLmpz) | `6.66% <ø> (ø)` | |
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/18752/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...board/components/nativeFilters/FilterBar/index.tsx](https://codecov.io/gh/apache/superset/pull/18752/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL2luZGV4LnRzeA==) | `69.82% <ø> (ø)` | |
| [...d/src/explore/components/PropertiesModal/index.tsx](https://codecov.io/gh/apache/superset/pull/18752/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Qcm9wZXJ0aWVzTW9kYWwvaW5kZXgudHN4) | `70.00% <ø> (+1.66%)` | :arrow_up: |
| [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/superset/pull/18752/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (ø)` | |
| [...frontend/src/views/CRUD/alert/AlertReportModal.tsx](https://codecov.io/gh/apache/superset/pull/18752/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRSZXBvcnRNb2RhbC50c3g=) | `52.23% <0.00%> (ø)` | |
| [superset/initialization/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/18752/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvaW5pdGlhbGl6YXRpb24vX19pbml0X18ucHk=) | `90.65% <ø> (+0.45%)` | :arrow_up: |
| [superset/reports/api.py](https://codecov.io/gh/apache/superset/pull/18752/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVwb3J0cy9hcGkucHk=) | `89.84% <ø> (ø)` | |
| ... and [14 more](https://codecov.io/gh/apache/superset/pull/18752/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/18752?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/18752?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [57c4d0f...3e9d252](https://codecov.io/gh/apache/superset/pull/18752?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #18752: fix: Bar chart order
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18752:
URL: https://github.com/apache/superset/pull/18752#issuecomment-1043229504
@geido Ephemeral environment spinning up at http://54.201.25.248:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #18752: fix: Bar chart order
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #18752:
URL: https://github.com/apache/superset/pull/18752#issuecomment-1044344835
@jinghua-qa I think there is a bit of confusion around the original issue. I agree with you that my method here isn't following the order in the data panel and that looks incorrect. Is there an actual problem that you are identifying with the sorting on master right now, or am I trying to fix a problem by creating one? 🤦
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido closed pull request #18752: fix: Bar chart order
Posted by GitBox <gi...@apache.org>.
geido closed pull request #18752:
URL: https://github.com/apache/superset/pull/18752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #18752: fix: Bar chart order
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #18752:
URL: https://github.com/apache/superset/pull/18752#issuecomment-1043159601
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #18752: fix: Bar chart order
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18752:
URL: https://github.com/apache/superset/pull/18752#issuecomment-1044928467
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org