You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Jason Dere <jd...@hortonworks.com> on 2014/11/07 02:53:37 UTC
Review Request 27715: HIVE-8745 Joins on decimal keys return different
results whether they are run as reduce join or map join
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27715/
-----------------------------------------------------------
Review request for hive, Gunther Hagleitner, Matt McCline, Sergio Pena, and Xuefu Zhang.
Bugs: HIVE-8745
https://issues.apache.org/jira/browse/HIVE-8745
Repository: hive-git
Description
-------
Revert HIVE-7373
Diffs
-----
common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java bd3e997
common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java 0bb84e1
common/src/test/org/apache/hadoop/hive/common/type/TestDecimal128.java 0786cca
common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java 959989a
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestDecimalUtil.java e0ca6fb
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTypeCasts.java 0802e3b
ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java 831ef8c
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java ce578a0
ql/src/test/queries/clientpositive/decimal_join2.q PRE-CREATION
ql/src/test/results/clientpositive/alter_partition_change_col.q.out 148bff4
ql/src/test/results/clientpositive/avro_decimal.q.out 921a418
ql/src/test/results/clientpositive/avro_decimal_native.q.out 60b4ccc
ql/src/test/results/clientpositive/char_pad_convert.q.out 63568af
ql/src/test/results/clientpositive/decimal_2.q.out 759ecf4
ql/src/test/results/clientpositive/decimal_3.q.out acaae65
ql/src/test/results/clientpositive/decimal_4.q.out a31d27a
ql/src/test/results/clientpositive/decimal_5.q.out 6df5097
ql/src/test/results/clientpositive/decimal_6.q.out 2bbd48a
ql/src/test/results/clientpositive/decimal_join2.q.out PRE-CREATION
ql/src/test/results/clientpositive/decimal_precision.q.out 94c63cb
ql/src/test/results/clientpositive/decimal_trailing.q.out c6991fd
ql/src/test/results/clientpositive/decimal_udf.q.out 6bd876a
ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out 359d4ac
ql/src/test/results/clientpositive/parquet_decimal.q.out 5767c57
ql/src/test/results/clientpositive/parquet_decimal1.q.out 0f71b1e
ql/src/test/results/clientpositive/serde_regex.q.out 65eef4f
ql/src/test/results/clientpositive/tez/mapjoin_decimal.q.out a2f677d
ql/src/test/results/clientpositive/tez/update_all_types.q.out f1353d0
ql/src/test/results/clientpositive/tez/vector_between_in.q.out ad8c4c0
ql/src/test/results/clientpositive/tez/vector_data_types.q.out 3f38a45
ql/src/test/results/clientpositive/tez/vector_decimal_2.q.out af9459f
ql/src/test/results/clientpositive/tez/vector_decimal_3.q.out 7987d08
ql/src/test/results/clientpositive/tez/vector_decimal_4.q.out 483ae1f
ql/src/test/results/clientpositive/tez/vector_decimal_5.q.out 01b5f42
ql/src/test/results/clientpositive/tez/vector_decimal_6.q.out 7ecd500
ql/src/test/results/clientpositive/tez/vector_decimal_aggregate.q.out e4b2c56
ql/src/test/results/clientpositive/tez/vector_decimal_cast.q.out e2fe3a2
ql/src/test/results/clientpositive/tez/vector_decimal_expressions.q.out 7faa630
ql/src/test/results/clientpositive/tez/vector_decimal_mapjoin.q.out 6a5ccc6
ql/src/test/results/clientpositive/tez/vector_decimal_precision.q.out d155623
ql/src/test/results/clientpositive/tez/vector_decimal_trailing.q.out cb0b5a2
ql/src/test/results/clientpositive/tez/vector_decimal_udf.q.out 8e847f6
ql/src/test/results/clientpositive/tez/vector_reduce_groupby_decimal.q.out 14acfc5
ql/src/test/results/clientpositive/udf_case.q.out 29905ab
ql/src/test/results/clientpositive/udf_when.q.out 696d7b0
ql/src/test/results/clientpositive/update_all_types.q.out f1353d0
ql/src/test/results/clientpositive/vector_aggregate_9.q.out c0fe295
ql/src/test/results/clientpositive/vector_between_in.q.out e21dd85
ql/src/test/results/clientpositive/vector_data_types.q.out 07d58ed
ql/src/test/results/clientpositive/vector_decimal_2.q.out d273810
ql/src/test/results/clientpositive/vector_decimal_3.q.out e982e1b
ql/src/test/results/clientpositive/vector_decimal_4.q.out 483ae1f
ql/src/test/results/clientpositive/vector_decimal_5.q.out 01b5f42
ql/src/test/results/clientpositive/vector_decimal_6.q.out 7ecd500
ql/src/test/results/clientpositive/vector_decimal_aggregate.q.out 7f2cd53
ql/src/test/results/clientpositive/vector_decimal_cast.q.out d489046
ql/src/test/results/clientpositive/vector_decimal_expressions.q.out 2c15b9a
ql/src/test/results/clientpositive/vector_decimal_mapjoin.q.out 193e6f7
ql/src/test/results/clientpositive/vector_decimal_precision.q.out 8789864
ql/src/test/results/clientpositive/vector_decimal_round_2.q.out 482f536
ql/src/test/results/clientpositive/vector_decimal_trailing.q.out cb0b5a2
ql/src/test/results/clientpositive/vector_decimal_udf.q.out 24a87c5
ql/src/test/results/clientpositive/vector_reduce_groupby_decimal.q.out 2343508
ql/src/test/results/clientpositive/windowing_decimal.q.out 194a916
ql/src/test/results/clientpositive/windowing_navfn.q.out 4256640
ql/src/test/results/clientpositive/windowing_rank.q.out 67975f3
serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java 73ae2d9
Diff: https://reviews.apache.org/r/27715/diff/
Testing
-------
Thanks,
Jason Dere
Re: Review Request 27715: HIVE-8745 Joins on decimal keys return
different results whether they are run as reduce join or map join
Posted by Matt McCline <mm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27715/#review60288
-----------------------------------------------------------
Ship it!
Ship It!
- Matt McCline
On Nov. 7, 2014, 1:53 a.m., Jason Dere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27715/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2014, 1:53 a.m.)
>
>
> Review request for hive, Gunther Hagleitner, Matt McCline, Sergio Pena, and Xuefu Zhang.
>
>
> Bugs: HIVE-8745
> https://issues.apache.org/jira/browse/HIVE-8745
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Revert HIVE-7373
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java bd3e997
> common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java 0bb84e1
> common/src/test/org/apache/hadoop/hive/common/type/TestDecimal128.java 0786cca
> common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java 959989a
> ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestDecimalUtil.java e0ca6fb
> ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTypeCasts.java 0802e3b
> ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java 831ef8c
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java ce578a0
> ql/src/test/queries/clientpositive/decimal_join2.q PRE-CREATION
> ql/src/test/results/clientpositive/alter_partition_change_col.q.out 148bff4
> ql/src/test/results/clientpositive/avro_decimal.q.out 921a418
> ql/src/test/results/clientpositive/avro_decimal_native.q.out 60b4ccc
> ql/src/test/results/clientpositive/char_pad_convert.q.out 63568af
> ql/src/test/results/clientpositive/decimal_2.q.out 759ecf4
> ql/src/test/results/clientpositive/decimal_3.q.out acaae65
> ql/src/test/results/clientpositive/decimal_4.q.out a31d27a
> ql/src/test/results/clientpositive/decimal_5.q.out 6df5097
> ql/src/test/results/clientpositive/decimal_6.q.out 2bbd48a
> ql/src/test/results/clientpositive/decimal_join2.q.out PRE-CREATION
> ql/src/test/results/clientpositive/decimal_precision.q.out 94c63cb
> ql/src/test/results/clientpositive/decimal_trailing.q.out c6991fd
> ql/src/test/results/clientpositive/decimal_udf.q.out 6bd876a
> ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out 359d4ac
> ql/src/test/results/clientpositive/parquet_decimal.q.out 5767c57
> ql/src/test/results/clientpositive/parquet_decimal1.q.out 0f71b1e
> ql/src/test/results/clientpositive/serde_regex.q.out 65eef4f
> ql/src/test/results/clientpositive/tez/mapjoin_decimal.q.out a2f677d
> ql/src/test/results/clientpositive/tez/update_all_types.q.out f1353d0
> ql/src/test/results/clientpositive/tez/vector_between_in.q.out ad8c4c0
> ql/src/test/results/clientpositive/tez/vector_data_types.q.out 3f38a45
> ql/src/test/results/clientpositive/tez/vector_decimal_2.q.out af9459f
> ql/src/test/results/clientpositive/tez/vector_decimal_3.q.out 7987d08
> ql/src/test/results/clientpositive/tez/vector_decimal_4.q.out 483ae1f
> ql/src/test/results/clientpositive/tez/vector_decimal_5.q.out 01b5f42
> ql/src/test/results/clientpositive/tez/vector_decimal_6.q.out 7ecd500
> ql/src/test/results/clientpositive/tez/vector_decimal_aggregate.q.out e4b2c56
> ql/src/test/results/clientpositive/tez/vector_decimal_cast.q.out e2fe3a2
> ql/src/test/results/clientpositive/tez/vector_decimal_expressions.q.out 7faa630
> ql/src/test/results/clientpositive/tez/vector_decimal_mapjoin.q.out 6a5ccc6
> ql/src/test/results/clientpositive/tez/vector_decimal_precision.q.out d155623
> ql/src/test/results/clientpositive/tez/vector_decimal_trailing.q.out cb0b5a2
> ql/src/test/results/clientpositive/tez/vector_decimal_udf.q.out 8e847f6
> ql/src/test/results/clientpositive/tez/vector_reduce_groupby_decimal.q.out 14acfc5
> ql/src/test/results/clientpositive/udf_case.q.out 29905ab
> ql/src/test/results/clientpositive/udf_when.q.out 696d7b0
> ql/src/test/results/clientpositive/update_all_types.q.out f1353d0
> ql/src/test/results/clientpositive/vector_aggregate_9.q.out c0fe295
> ql/src/test/results/clientpositive/vector_between_in.q.out e21dd85
> ql/src/test/results/clientpositive/vector_data_types.q.out 07d58ed
> ql/src/test/results/clientpositive/vector_decimal_2.q.out d273810
> ql/src/test/results/clientpositive/vector_decimal_3.q.out e982e1b
> ql/src/test/results/clientpositive/vector_decimal_4.q.out 483ae1f
> ql/src/test/results/clientpositive/vector_decimal_5.q.out 01b5f42
> ql/src/test/results/clientpositive/vector_decimal_6.q.out 7ecd500
> ql/src/test/results/clientpositive/vector_decimal_aggregate.q.out 7f2cd53
> ql/src/test/results/clientpositive/vector_decimal_cast.q.out d489046
> ql/src/test/results/clientpositive/vector_decimal_expressions.q.out 2c15b9a
> ql/src/test/results/clientpositive/vector_decimal_mapjoin.q.out 193e6f7
> ql/src/test/results/clientpositive/vector_decimal_precision.q.out 8789864
> ql/src/test/results/clientpositive/vector_decimal_round_2.q.out 482f536
> ql/src/test/results/clientpositive/vector_decimal_trailing.q.out cb0b5a2
> ql/src/test/results/clientpositive/vector_decimal_udf.q.out 24a87c5
> ql/src/test/results/clientpositive/vector_reduce_groupby_decimal.q.out 2343508
> ql/src/test/results/clientpositive/windowing_decimal.q.out 194a916
> ql/src/test/results/clientpositive/windowing_navfn.q.out 4256640
> ql/src/test/results/clientpositive/windowing_rank.q.out 67975f3
> serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java 73ae2d9
>
> Diff: https://reviews.apache.org/r/27715/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Dere
>
>