You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2020/11/16 13:25:26 UTC
[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30
zhaorenhai@hotmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16725
Change subject: IMPALA-10329 Change apt install retry times to 30
......................................................................
IMPALA-10329 Change apt install retry times to 30
Change apt install retry times to 30 in bootstrap_system.sh
Because this always timeout recently.
Change-Id: I790750da36ad53c87a830dfab6803a1862490daf
---
M bin/bootstrap_system.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/16725/1
--
To view, visit http://gerrit.cloudera.org:8080/16725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I790750da36ad53c87a830dfab6803a1862490daf
Gerrit-Change-Number: 16725
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 )
Change subject: IMPALA-10329 Change apt install retry times to 30
......................................................................
Patch Set 2:
Hi, Jim, as your suggest, I add the wait solution.
--
To view, visit http://gerrit.cloudera.org:8080/16725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I790750da36ad53c87a830dfab6803a1862490daf
Gerrit-Change-Number: 16725
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Comment-Date: Thu, 19 Nov 2020 03:41:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 )
Change subject: IMPALA-10329 Change apt install retry times to 30
......................................................................
Patch Set 3:
Don't output to the console.
And I think this solution is same with 'changeing for loop to while true', just different checking lock solution.
--
To view, visit http://gerrit.cloudera.org:8080/16725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I790750da36ad53c87a830dfab6803a1862490daf
Gerrit-Change-Number: 16725
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Comment-Date: Thu, 19 Nov 2020 03:58:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 )
Change subject: IMPALA-10329 Change apt install retry times to 30
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/7685/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I790750da36ad53c87a830dfab6803a1862490daf
Gerrit-Change-Number: 16725
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Comment-Date: Thu, 19 Nov 2020 04:10:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 )
Change subject: IMPALA-10329 Change apt install retry times to 30
......................................................................
Patch Set 3:
For 'I find the two solutions different, as apt-get can fail for reasons other than another process holding the lock. This solution reduces the number of scenarios in which a build spins indefinitely, which is a result that should be avoided in terms of CI/CD ergonomics and economics.'
If another process holding the lock, current solution will also spins indefinitely.
--
To view, visit http://gerrit.cloudera.org:8080/16725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I790750da36ad53c87a830dfab6803a1862490daf
Gerrit-Change-Number: 16725
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Comment-Date: Thu, 19 Nov 2020 05:05:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 )
Change subject: IMPALA-10329 Change apt install retry times to 30
......................................................................
Patch Set 3:
> for 'why should it be done', no reason, just don't output to the
> console, I already tested, adding it or not don't impact the logic.
In that case, let's not redirect. I think that's more the style of the rest of the script.
--
To view, visit http://gerrit.cloudera.org:8080/16725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I790750da36ad53c87a830dfab6803a1862490daf
Gerrit-Change-Number: 16725
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Comment-Date: Thu, 19 Nov 2020 16:17:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 )
Change subject: IMPALA-10329 Change apt install retry times to 30
......................................................................
Patch Set 3:
Sorry, Jim, my develop environment is recreated, so I create a new commit on here: http://gerrit.cloudera.org:8080/16751
And I will abandon this.
--
To view, visit http://gerrit.cloudera.org:8080/16725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I790750da36ad53c87a830dfab6803a1862490daf
Gerrit-Change-Number: 16725
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Comment-Date: Fri, 20 Nov 2020 02:07:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has abandoned this change. ( http://gerrit.cloudera.org:8080/16725 )
Change subject: IMPALA-10329 Change apt install retry times to 30
......................................................................
Abandoned
duplicate
--
To view, visit http://gerrit.cloudera.org:8080/16725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I790750da36ad53c87a830dfab6803a1862490daf
Gerrit-Change-Number: 16725
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 )
Change subject: IMPALA-10329 Change apt install retry times to 30
......................................................................
Patch Set 3:
> Don't output to the console.
Yes, I understand what it does. My question is "why should it be done?"
--
To view, visit http://gerrit.cloudera.org:8080/16725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I790750da36ad53c87a830dfab6803a1862490daf
Gerrit-Change-Number: 16725
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Comment-Date: Thu, 19 Nov 2020 04:38:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 )
Change subject: IMPALA-10329 Change apt install retry times to 30
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/7655/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I790750da36ad53c87a830dfab6803a1862490daf
Gerrit-Change-Number: 16725
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Nov 2020 13:47:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/16725 )
Change subject: IMPALA-10329 Change apt install retry times to 30
......................................................................
IMPALA-10329 Change apt install retry times to 30
Change apt install retry times to 30 in bootstrap_system.sh,
Because this always timeout recently.
And add solution for waiting the apt's lock-frontend.
Change-Id: I790750da36ad53c87a830dfab6803a1862490daf
---
M bin/bootstrap_system.sh
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/16725/3
--
To view, visit http://gerrit.cloudera.org:8080/16725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I790750da36ad53c87a830dfab6803a1862490daf
Gerrit-Change-Number: 16725
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 )
Change subject: IMPALA-10329 Change apt install retry times to 30
......................................................................
Patch Set 1:
I saw these errors, thanks for taking a look!
In my experience, these things happen when a new VM is starting and getting updates from the distro maintainer.
Is there a way we can wait on the dpkg lock? I'm concerned that increasing the retry times just "kicks the can down the road", so to speak.
--
To view, visit http://gerrit.cloudera.org:8080/16725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I790750da36ad53c87a830dfab6803a1862490daf
Gerrit-Change-Number: 16725
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Comment-Date: Mon, 16 Nov 2020 14:25:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 )
Change subject: IMPALA-10329 Change apt install retry times to 30
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16725/2/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:
http://gerrit.cloudera.org:8080/#/c/16725/2/bin/bootstrap_system.sh@212
PS2, Line 212: >/dev/null 2>&1
Looks good! One question - what is the rationale for redirecting stdout and stderr here?
--
To view, visit http://gerrit.cloudera.org:8080/16725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I790750da36ad53c87a830dfab6803a1862490daf
Gerrit-Change-Number: 16725
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Comment-Date: Thu, 19 Nov 2020 03:51:13 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 )
Change subject: IMPALA-10329 Change apt install retry times to 30
......................................................................
Patch Set 1:
> Hello, Jim, maybe we change the 'for' loop to 'while true'?
I see the logic in that. We can just get started when the system is ready!
But what happens if there's a problem other than this one that we can just wait out? Then the build would keep going for hours just failing at apt-get, yes?
Maybe we should look around for what the best practices are for this kind of use case. I think I may have seen something on askubuntu.com.
--
To view, visit http://gerrit.cloudera.org:8080/16725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I790750da36ad53c87a830dfab6803a1862490daf
Gerrit-Change-Number: 16725
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Comment-Date: Tue, 17 Nov 2020 04:37:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 )
Change subject: IMPALA-10329 Change apt install retry times to 30
......................................................................
Patch Set 3:
> And I think this solution is same with 'changeing for loop to while
> true', just different checking lock solution.
Sorry, I missed this part of your message.
I find the two solutions different, as apt-get can fail for reasons other than another process holding the lock. This solution reduces the number of scenarios in which a build spins indefinitely, which is a result that should be avoided in terms of CI/CD ergonomics and economics.
--
To view, visit http://gerrit.cloudera.org:8080/16725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I790750da36ad53c87a830dfab6803a1862490daf
Gerrit-Change-Number: 16725
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Comment-Date: Thu, 19 Nov 2020 04:47:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/16725 )
Change subject: IMPALA-10329 Change apt install retry times to 30
......................................................................
IMPALA-10329 Change apt install retry times to 30
Change apt install retry times to 30 in bootstrap_system.sh,
Because this always timeout recently.
And add solution for waiting the apt's lock-frontend.
Change-Id: I790750da36ad53c87a830dfab6803a1862490daf
---
M bin/bootstrap_system.sh
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/16725/2
--
To view, visit http://gerrit.cloudera.org:8080/16725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I790750da36ad53c87a830dfab6803a1862490daf
Gerrit-Change-Number: 16725
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 )
Change subject: IMPALA-10329 Change apt install retry times to 30
......................................................................
Patch Set 1:
> Hello Jim, this from askubuntu.com https://askubuntu.com/questions/15433/unable-to-lock-the-administration-directory-var-lib-dpkg-is-another-process
> I think removing the lock file and killing the process are not the
> good choice. Any other suggestion?
Yes, I agree!
What do you think about the various solutions on this question:
https://askubuntu.com/questions/132059/how-to-make-a-package-manager-wait-if-another-instance-of-apt-is-running
--
To view, visit http://gerrit.cloudera.org:8080/16725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I790750da36ad53c87a830dfab6803a1862490daf
Gerrit-Change-Number: 16725
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Comment-Date: Wed, 18 Nov 2020 03:19:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 )
Change subject: IMPALA-10329 Change apt install retry times to 30
......................................................................
Patch Set 3:
for 'why should it be done', no reason, just don't output to the console, I already tested, adding it or not don't impact the logic.
--
To view, visit http://gerrit.cloudera.org:8080/16725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I790750da36ad53c87a830dfab6803a1862490daf
Gerrit-Change-Number: 16725
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Comment-Date: Thu, 19 Nov 2020 05:03:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 )
Change subject: IMPALA-10329 Change apt install retry times to 30
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/7684/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I790750da36ad53c87a830dfab6803a1862490daf
Gerrit-Change-Number: 16725
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Comment-Date: Thu, 19 Nov 2020 04:02:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 )
Change subject: IMPALA-10329 Change apt install retry times to 30
......................................................................
Patch Set 1:
Hello Jim, this from askubuntu.com https://askubuntu.com/questions/15433/unable-to-lock-the-administration-directory-var-lib-dpkg-is-another-process
I think removing the lock file and killing the process are not the good choice. Any other suggestion?
--
To view, visit http://gerrit.cloudera.org:8080/16725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I790750da36ad53c87a830dfab6803a1862490daf
Gerrit-Change-Number: 16725
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Comment-Date: Wed, 18 Nov 2020 02:51:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 )
Change subject: IMPALA-10329 Change apt install retry times to 30
......................................................................
Patch Set 1:
Hello, Jim, maybe we change the 'for' loop to 'while true'?
--
To view, visit http://gerrit.cloudera.org:8080/16725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I790750da36ad53c87a830dfab6803a1862490daf
Gerrit-Change-Number: 16725
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Comment-Date: Tue, 17 Nov 2020 03:53:17 +0000
Gerrit-HasComments: No