You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/06 03:28:38 UTC

[GitHub] [spark] dilipbiswal commented on a change in pull request #24532: [SPARK-27596][SQL] The JDBC 'query' option doesn't work for Oracle database

dilipbiswal commented on a change in pull request #24532: [SPARK-27596][SQL] The JDBC 'query' option doesn't work for Oracle database
URL: https://github.com/apache/spark/pull/24532#discussion_r281055485
 
 

 ##########
 File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
 ##########
 @@ -485,4 +485,32 @@ class OracleIntegrationSuite extends DockerJDBCIntegrationSuite with SharedSQLCo
     }
     assert(df2.collect.toSet === expectedResult)
   }
+
+  test("query JDBC option") {
 
 Review comment:
   @gatorsmile I did the following steps to run the oracle tests.
   1) I pulled  christophesurmont/oracle-xe-11g 
   2) I set the environment variable ORACLE_DOCKER_IMAGE_NAME to the above image name
   3) I put the jdbc driver in maven directory
   4) Then ran the test

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org