[jira] [Commented] (GEARPUMP-278) Default value skipped for START_CLOCK on ClockService

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEARPUMP-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875239#comment-15875239 ] 

ASF GitHub Bot commented on GEARPUMP-278:
-----------------------------------------

GitHub user manuzhang opened a pull request:

    https://github.com/apache/incubator-gearpump/pull/154

    [GEARPUMP-278] Check for null before casting stored start clock

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the commit message is formatted like:
       `[GEARPUMP-<Jira issue #>] Meaningful description of pull request` 
     - [ ] Make sure tests pass via `sbt clean test`.
     - [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/manuzhang/incubator-gearpump app_data_store

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-gearpump/pull/154.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #154
    
----
commit ee6e11933c89d7aa76db7f3881029a08e9d609e7
Author: manuzhang <ow...@gmail.com>
Date:   2017-02-21T02:11:37Z

    [GEARPUMP-278] Check for null before casting stored start clock

----


> Default value skipped for START_CLOCK on ClockService
> -----------------------------------------------------
>
>                 Key: GEARPUMP-278
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-278
>             Project: Apache Gearpump
>          Issue Type: Bug
>    Affects Versions: 0.8.2
>            Reporter: Manu Zhang
>            Assignee: Manu Zhang
>
> The cause is when we get {{START_CLOCK}} from {{AppDataStore}}, it is converted to {{TimeStamp}} or {{Long}}. If we haven't stored a previous value, then {{null}} is expected. That's why we do {{Option(clock).getOrElse(0L)}}. In fact, {{0}} is returned when {{null}} is converted to {{Long}}, which makes the default value useless.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)