You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/15 16:42:14 UTC

[GitHub] [spark] viirya commented on a change in pull request #29759: [SPARK-32481][SQL][TESTS][FOLLOW-UP] Skip the test if trash directory cannot be created

viirya commented on a change in pull request #29759:
URL: https://github.com/apache/spark/pull/29759#discussion_r488810057



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
##########
@@ -3118,6 +3118,7 @@ abstract class DDLSuite extends QueryTest with SQLTestUtils {
         val fs = tablePath.getFileSystem(hadoopConf)
         val trashCurrent = new Path(fs.getHomeDirectory, ".Trash/Current")
         val trashPath = Path.mergePaths(trashCurrent, tablePath)
+        assume(fs.mkdirs(trashPath) && fs.delete(trashPath, false))

Review comment:
       Can we show a message when the assume fails?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org