[GitHub] [hbase-operator-tools] joshelser commented on a change in pull request #55: HBASE-24039

[GitBox <gi...@apache.org>]

joshelser commented on a change in pull request #55: HBASE-24039 
URL: https://github.com/apache/hbase-operator-tools/pull/55#discussion_r406534504
 
 

 ##########
 File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java
 ##########
 @@ -133,6 +143,19 @@ void checkHBCKSupport(ClusterConnection connection, String cmd, String ... suppo
     }
   }
 
+  void checkFunctionSupported(ClusterConnection connection, String cmd) throws IOException {
+    if (skipCheck) {
+      LOG.info("Skipped {} command version check; 'skip' set", cmd);
+      return;
+    }
+    List<Method> methods = Arrays.asList(connection.getHbck().getClass().getDeclaredMethods());
 
 Review comment:
   This is only checking what is defined in `Hbck` per the local environment. This might differ that the cluster's version.
   
   e.g. a user has their personal computer with HBase 2.2.0 on it, but their cluster they're fixing has 2.2.2 on it.
   
   I think this is OK to start with, but we might want to push some sort of RPC to get the available Hbck methods from the Master itself (when the master, of course, is up) as a future improvement.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services