You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/06/06 09:53:47 UTC

[GitHub] [dubbo-go] watermelo opened a new pull request #588: Ftr: add comment for metadata

watermelo opened a new pull request #588:
URL: https://github.com/apache/dubbo-go/pull/588


   <!--  Thanks for sending a pull request! 
   -->
   
   **What this PR does**:
   add comment for metadata
   
   **Which issue(s) this PR fixes**:
   <!--
   *Automatically closes linked issue when PR is merged.
   Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
   _If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
   -->
   Fixes #
   
   **Special notes for your reviewer**:
   
   **Does this PR introduce a user-facing change?**:
   <!--
   If no, just write "NONE" in the release-note block below.
   If yes, a release note is required:
   Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
   -->
   ```release-note
   
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #588: Mod: add comment for metadata

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #588:
URL: https://github.com/apache/dubbo-go/pull/588#issuecomment-640026782


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=h1) Report
   > Merging [#588](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/4af26b99cdcea223122bec0e90767bd56fad99f8&el=desc) will **increase** coverage by `0.85%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/588/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #588      +/-   ##
   ===========================================
   + Coverage    66.43%   67.28%   +0.85%     
   ===========================================
     Files          184      188       +4     
     Lines         9712     9849     +137     
   ===========================================
   + Hits          6452     6627     +175     
   + Misses        2620     2570      -50     
   - Partials       640      652      +12     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `57.69% <0.00%> (-13.47%)` | :arrow_down: |
   | [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `52.83% <0.00%> (-3.25%)` | :arrow_down: |
   | [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0.00%> (-2.16%)` | :arrow_down: |
   | [config/base\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y29uZmlnL2Jhc2VfY29uZmlnLmdv) | `64.14% <0.00%> (ø)` | |
   | [config/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y29uZmlnL2dyYWNlZnVsX3NodXRkb3duLmdv) | `58.62% <0.00%> (ø)` | |
   | [cluster/loadbalance/random.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9yYW5kb20uZ28=) | `100.00% <0.00%> (ø)` | |
   | [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `71.42% <0.00%> (ø)` | |
   | [cluster/loadbalance/round\_robin.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9yb3VuZF9yb2Jpbi5nbw==) | `88.70% <0.00%> (ø)` | |
   | [cluster/loadbalance/least\_active.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9sZWFzdF9hY3RpdmUuZ28=) | `91.30% <0.00%> (ø)` | |
   | [cluster/cluster\_impl/mock\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvbW9ja19jbHVzdGVyLmdv) | `0.00% <0.00%> (ø)` | |
   | ... and [33 more](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=footer). Last update [4af26b9...51405f6](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks merged pull request #588: Mod: add comment for metadata

Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #588:
URL: https://github.com/apache/dubbo-go/pull/588


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] zouyx commented on a change in pull request #588: Mod: add comment for metadata

Posted by GitBox <gi...@apache.org>.
zouyx commented on a change in pull request #588:
URL: https://github.com/apache/dubbo-go/pull/588#discussion_r436429988



##########
File path: metadata/identifier/service_metadata_identifier.go
##########
@@ -27,12 +27,12 @@ type ServiceMetadataIdentifier struct {
 	BaseMetadataIdentifier
 }
 
-// getIdentifierKey...
+// getIdentifierKey gets metadata identifier key by @mdi.protocol and @mdi.revision
 func (mdi *ServiceMetadataIdentifier) getIdentifierKey(params ...string) string {
-	return mdi.BaseMetadataIdentifier.getIdentifierKey(mdi.protocol + constant.KEY_REVISON_PREFIX + mdi.revision)
+	return mdi.BaseMetadataIdentifier.getIdentifierKey(mdi.protocol, constant.KEY_REVISON_PREFIX, mdi.revision)

Review comment:
       I think should not change `+` to `,` 
   
   When
   `
   protocol="a"
   revision="b"
   `
   
   In `BaseServiceMetadataIdentifier.getIdentifierKey` use `+` , result is `arevisionb`.
   
   In `BaseServiceMetadataIdentifier.getIdentifierKey` use `,` , result is `a:revision:b`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] watermelo commented on a change in pull request #588: Ftr: add comment for metadata

Posted by GitBox <gi...@apache.org>.
watermelo commented on a change in pull request #588:
URL: https://github.com/apache/dubbo-go/pull/588#discussion_r436255662



##########
File path: metadata/identifier/base_metadata_identifier.go
##########
@@ -47,7 +46,7 @@ func joinParams(joinChar string, params []string) string {
 	return joinedStr
 }
 
-// getIdentifierKey...
+// getIdentifierKey gets metadata identifier key by @params

Review comment:
       I didn't find its usage, Need big-old help.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] watermelo commented on pull request #588: Ftr: add comment for metadata

Posted by GitBox <gi...@apache.org>.
watermelo commented on pull request #588:
URL: https://github.com/apache/dubbo-go/pull/588#issuecomment-640039975


   #570 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #588: Mod: add comment for metadata

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #588:
URL: https://github.com/apache/dubbo-go/pull/588#issuecomment-640026782


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=h1) Report
   > Merging [#588](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/4af26b99cdcea223122bec0e90767bd56fad99f8&el=desc) will **increase** coverage by `0.21%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/588/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #588      +/-   ##
   ===========================================
   + Coverage    66.43%   66.65%   +0.21%     
   ===========================================
     Files          184      185       +1     
     Lines         9712     9749      +37     
   ===========================================
   + Hits          6452     6498      +46     
   + Misses        2620     2619       -1     
   + Partials       640      632       -8     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
   | [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `63.03% <0.00%> (-6.07%)` | :arrow_down: |
   | [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `67.30% <0.00%> (-3.85%)` | :arrow_down: |
   | [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `52.83% <0.00%> (-3.25%)` | :arrow_down: |
   | [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `75.00% <0.00%> (-1.82%)` | :arrow_down: |
   | [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
   | [config/base\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y29uZmlnL2Jhc2VfY29uZmlnLmdv) | `64.14% <0.00%> (ø)` | |
   | [config/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y29uZmlnL2dyYWNlZnVsX3NodXRkb3duLmdv) | `58.62% <0.00%> (ø)` | |
   | [cluster/loadbalance/random.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9yYW5kb20uZ28=) | `100.00% <0.00%> (ø)` | |
   | [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `71.42% <0.00%> (ø)` | |
   | ... and [19 more](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=footer). Last update [4af26b9...51405f6](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #588: Mod: add comment for metadata

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #588:
URL: https://github.com/apache/dubbo-go/pull/588#discussion_r437161892



##########
File path: metadata/identifier/base_metadata_identifier.go
##########
@@ -25,19 +25,21 @@ import (
 	"github.com/apache/dubbo-go/common/constant"
 )
 
+// BaseMetadataIdentifier defined for describe the Metadata base identify
 type BaseMetadataIdentifier interface {
 	getFilePathKey(params ...string) string
 	getIdentifierKey(params ...string) string
 }
 
+// BaseMetadataIdentifier is the base implement of BaseMetadataIdentifier interface
 type BaseServiceMetadataIdentifier struct {
 	serviceInterface string
 	version          string
 	group            string
 	side             string
 }
 
-// joinParams...
+// joinParams will join the specified char in slice, and build as string

Review comment:
       'build as string' --> return a string

##########
File path: metadata/identifier/base_metadata_identifier.go
##########
@@ -25,19 +25,21 @@ import (
 	"github.com/apache/dubbo-go/common/constant"
 )
 
+// BaseMetadataIdentifier defined for describe the Metadata base identify

Review comment:
       describe --> description

##########
File path: metadata/identifier/subscribe_metadata_identifier.go
##########
@@ -17,17 +17,18 @@
 
 package identifier
 
+// SubscriberMetadataIdentifier is inherit baseMetaIdentifier with service params: Revision
 type SubscriberMetadataIdentifier struct {
 	revision string
 	BaseMetadataIdentifier
 }
 
-// getIdentifierKey...
+// GetIdentifierKey will return string format as service:Version:Group:Side:Revision

Review comment:
       getIdentifierKey's return string format is "service:Version:Group:Side:Revision"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #588: Mod: add comment for metadata

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #588:
URL: https://github.com/apache/dubbo-go/pull/588#issuecomment-640026782


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=h1) Report
   > Merging [#588](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/4af26b99cdcea223122bec0e90767bd56fad99f8&el=desc) will **increase** coverage by `1.10%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/588/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #588      +/-   ##
   ===========================================
   + Coverage    66.43%   67.53%   +1.10%     
   ===========================================
     Files          184      188       +4     
     Lines         9712     9852     +140     
   ===========================================
   + Hits          6452     6654     +202     
   + Misses        2620     2546      -74     
   - Partials       640      652      +12     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [cluster/directory/base\_directory.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y2x1c3Rlci9kaXJlY3RvcnkvYmFzZV9kaXJlY3RvcnkuZ28=) | `56.81% <0.00%> (-9.10%)` | :arrow_down: |
   | [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `67.30% <0.00%> (-3.85%)` | :arrow_down: |
   | [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `52.83% <0.00%> (-3.25%)` | :arrow_down: |
   | [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `70.83% <0.00%> (-1.64%)` | :arrow_down: |
   | [cluster/cluster\_impl/failover\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbG92ZXJfY2x1c3Rlcl9pbnZva2VyLmdv) | `71.15% <0.00%> (-1.19%)` | :arrow_down: |
   | [cluster/cluster\_impl/forking\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZm9ya2luZ19jbHVzdGVyX2ludm9rZXIuZ28=) | `58.33% <0.00%> (-0.21%)` | :arrow_down: |
   | [config/base\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y29uZmlnL2Jhc2VfY29uZmlnLmdv) | `64.14% <0.00%> (ø)` | |
   | [config/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y29uZmlnL2dyYWNlZnVsX3NodXRkb3duLmdv) | `58.62% <0.00%> (ø)` | |
   | [cluster/loadbalance/random.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9yYW5kb20uZ28=) | `100.00% <0.00%> (ø)` | |
   | [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `71.42% <0.00%> (ø)` | |
   | ... and [38 more](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=footer). Last update [4af26b9...92a019d](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #588: Mod: add comment for metadata

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #588:
URL: https://github.com/apache/dubbo-go/pull/588#issuecomment-640026782


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=h1) Report
   > Merging [#588](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/4af26b99cdcea223122bec0e90767bd56fad99f8&el=desc) will **increase** coverage by `0.85%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/588/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #588      +/-   ##
   ===========================================
   + Coverage    66.43%   67.28%   +0.85%     
   ===========================================
     Files          184      188       +4     
     Lines         9712     9849     +137     
   ===========================================
   + Hits          6452     6627     +175     
   + Misses        2620     2570      -50     
   - Partials       640      652      +12     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `57.69% <0.00%> (-13.47%)` | :arrow_down: |
   | [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `52.83% <0.00%> (-3.25%)` | :arrow_down: |
   | [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0.00%> (-2.16%)` | :arrow_down: |
   | [config/base\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y29uZmlnL2Jhc2VfY29uZmlnLmdv) | `64.14% <0.00%> (ø)` | |
   | [config/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y29uZmlnL2dyYWNlZnVsX3NodXRkb3duLmdv) | `58.62% <0.00%> (ø)` | |
   | [cluster/loadbalance/random.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9yYW5kb20uZ28=) | `100.00% <0.00%> (ø)` | |
   | [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `71.42% <0.00%> (ø)` | |
   | [cluster/loadbalance/round\_robin.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9yb3VuZF9yb2Jpbi5nbw==) | `88.70% <0.00%> (ø)` | |
   | [cluster/loadbalance/least\_active.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9sZWFzdF9hY3RpdmUuZ28=) | `91.30% <0.00%> (ø)` | |
   | [cluster/cluster\_impl/mock\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvbW9ja19jbHVzdGVyLmdv) | `0.00% <0.00%> (ø)` | |
   | ... and [33 more](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=footer). Last update [4af26b9...b90c86f](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter commented on pull request #588: Ftr: add comment for metadata

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #588:
URL: https://github.com/apache/dubbo-go/pull/588#issuecomment-640026782


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=h1) Report
   > Merging [#588](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/4af26b99cdcea223122bec0e90767bd56fad99f8&el=desc) will **increase** coverage by `0.21%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/588/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #588      +/-   ##
   ===========================================
   + Coverage    66.43%   66.65%   +0.21%     
   ===========================================
     Files          184      185       +1     
     Lines         9712     9749      +37     
   ===========================================
   + Hits          6452     6498      +46     
   + Misses        2620     2619       -1     
   + Partials       640      632       -8     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
   | [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `63.03% <0.00%> (-6.07%)` | :arrow_down: |
   | [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `67.30% <0.00%> (-3.85%)` | :arrow_down: |
   | [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `52.83% <0.00%> (-3.25%)` | :arrow_down: |
   | [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `75.00% <0.00%> (-1.82%)` | :arrow_down: |
   | [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
   | [config/base\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y29uZmlnL2Jhc2VfY29uZmlnLmdv) | `64.14% <0.00%> (ø)` | |
   | [config/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y29uZmlnL2dyYWNlZnVsX3NodXRkb3duLmdv) | `58.62% <0.00%> (ø)` | |
   | [cluster/loadbalance/random.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9yYW5kb20uZ28=) | `100.00% <0.00%> (ø)` | |
   | [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `71.42% <0.00%> (ø)` | |
   | ... and [19 more](https://codecov.io/gh/apache/dubbo-go/pull/588/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=footer). Last update [4af26b9...f4400ef](https://codecov.io/gh/apache/dubbo-go/pull/588?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #588: Mod: add comment for metadata

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #588:
URL: https://github.com/apache/dubbo-go/pull/588#issuecomment-640026782






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org