You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Astro-Han (via GitHub)" <gi...@apache.org> on 2026/10/16 05:32:24 UTC
[PR] fix(ci): record marked in the packaged dependency ledger [maka]
Astro-Han opened a new pull request, #6129:
URL: https://github.com/apache/maka/pull/6129
## Summary
Main CI stops at `check:artifact-budget` because the ledger introduced in #5455 omits `marked@18.0.11`, which #5969 already added as a production dependency of `@maka/core` for Host-side Markdown image parsing. Record that installed package instance in the existing ledger.
Refs #5455, #5969.
## Verification
- Linux x64 container, Node 24 and npm 11.19.0, clean `npm ci --ignore-scripts`: reproduced the main failure with only `+ node_modules/marked@18.0.11`.
- Regenerated the ledger on Linux x64 with the existing `--write` command and verified it exactly matches this one-line change. `npm run check:artifact-budget` then passes with 242 package instances.
- Existing artifact-budget and production-closure tests: 14 passed. No test changes are needed; the existing production check fails without this ledger entry.
- `npm run format:check`, `npm run lint`, and `git diff --check` passed.
- Build and typecheck were not run for this JSON-only ledger update. Dependency lifecycle scripts were skipped because this check reads the installed dependency tree.
## AI use
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope: Codex investigated the CI failure, updated the ledger, and ran verification.
## Checklist
- [x] Tests cover the change and fail without it
- [x] Lint, format and affected suites pass locally; typecheck is not applicable to this JSON-only change
Does this PR entail a change in behavior?
- [ ] Yes — described under Summary above
- [x] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(desktop): preserve cached replies and repair CI gates [maka]
Posted by "me2seeks (via GitHub)" <gi...@apache.org>.
me2seeks merged PR #6129:
URL: https://github.com/apache/maka/pull/6129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(desktop): preserve cached replies and repair CI gates [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han commented on code in PR #6129:
URL: https://github.com/apache/maka/pull/6129#discussion_r4291895345
##########
apps/desktop/src/main/session-local-service.ts:
##########
@@ -529,11 +534,10 @@ export class DesktopSessionLocalService {
const pending = this.#snapshots.has(key);
this.#snapshots.set(key, { target, snapshot });
if (pending) return;
- const revision = this.store.revision;
setImmediate(() => {
const latest = this.#snapshots.get(key);
this.#snapshots.delete(key);
- if (!latest || !this.#current(latest.target) || revision !== this.store.revision) return;
+ if (!latest || !this.#current(latest.target)) return;
Review Comment:
[P2] Cancel pending cache writes for Sessions removed by catalog reconciliation
The new `removeSession` method covers explicit deletion, but `#startCatalogRefresh` still calls `store.saveCatalog` directly (line 455). That store method removes absent, non-locally-created Sessions through its own `removeSession` (session-local-store.ts:347), leaving their entries in `#snapshots`. Without the revision check here, a previously queued `setImmediate` then writes the deleted transcript back.
I reproduced this with the real service and SQLite: seed two cached Sessions, begin `service.catalog()` with a deferred `listSessions`, schedule transcript writes, then resolve the catalog with only the other Session before the immediate runs. The missing Session is removed from `store.sessions`, yet `service.readTranscript` returns its reply and the transcript remains after reopening SQLite. The actual merge-base service rejects that stale write. Explicit deletion and authority purge pass.
Before `saveCatalog`, route each absent old Session without a local creation intent through `this.removeSession(target, id)`, so deletion also cancels the queued write. Alternatively, expose the removed IDs from catalog reconciliation and synchronously cancel those entries. A regression should drive this deferred catalog path, reopen SQLite, and assert the removed transcript is absent while a retained Session's pending cache still persists; restoring the global revision fence would incorrectly discard the latter again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(desktop): preserve cached replies and repair CI gates [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han commented on code in PR #6129:
URL: https://github.com/apache/maka/pull/6129#discussion_r4293732719
##########
apps/desktop/src/main/session-local-service.ts:
##########
@@ -529,11 +534,10 @@ export class DesktopSessionLocalService {
const pending = this.#snapshots.has(key);
this.#snapshots.set(key, { target, snapshot });
if (pending) return;
- const revision = this.store.revision;
setImmediate(() => {
const latest = this.#snapshots.get(key);
this.#snapshots.delete(key);
- if (!latest || !this.#current(latest.target) || revision !== this.store.revision) return;
+ if (!latest || !this.#current(latest.target)) return;
Review Comment:
Automated follow-up (Codex): I fixed this in fe1172397. `saveCatalog` now returns the Session IDs actually removed by its transaction; the service cancels only those pending snapshots after commit. The deletion rule remains in the store.
The new regression drives a deferred catalog refresh with simultaneous removed/retained Session writes, then reopens SQLite. It fails on the reviewed head and now confirms that removed history stays absent while the retained reply persists. All 82 Session-local/preload tests, Desktop build/typecheck, formatting and lint pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org