You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/04/29 11:13:31 UTC
Review Request 46827: Replaced CHECK with CHECK_READY.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46827/
-----------------------------------------------------------
Review request for mesos and Alexander Rukletsov.
Repository: mesos
Description
-------
Also removed some unused header includes.
Diffs
-----
src/zookeeper/contender.cpp 4b1cc654cb96d3fd87c5f36c93a8ee1e170bea77
Diff: https://reviews.apache.org/r/46827/diff/
Testing
-------
make check
Thanks,
Neil Conway
Re: Review Request 46827: Replaced CHECK with CHECK_READY.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46827/#review131167
-----------------------------------------------------------
Patch looks great!
Reviews applied: [46827]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 29, 2016, 2:08 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46827/
> -----------------------------------------------------------
>
> (Updated April 29, 2016, 2:08 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Also removed some unused header includes.
>
>
> Diffs
> -----
>
> src/zookeeper/contender.cpp 4b1cc654cb96d3fd87c5f36c93a8ee1e170bea77
>
> Diff: https://reviews.apache.org/r/46827/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 46827: Replaced CHECK with CHECK_READY.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46827/
-----------------------------------------------------------
(Updated April 29, 2016, 2:08 p.m.)
Review request for mesos and Alexander Rukletsov.
Repository: mesos
Description
-------
Also removed some unused header includes.
Diffs
-----
src/zookeeper/contender.cpp 4b1cc654cb96d3fd87c5f36c93a8ee1e170bea77
Diff: https://reviews.apache.org/r/46827/diff/
Testing
-------
make check
Thanks,
Neil Conway
Re: Review Request 46827: Replaced CHECK with CHECK_READY.
Posted by Neil Conway <ne...@gmail.com>.
> On April 29, 2016, 9:29 a.m., Alexander Rukletsov wrote:
> > It would be great to implement `CHECK_NREADY`, `CHECK_NDISCARDED`, then we could have replaced `CHECK(!candidacy.isDiscarded());` for consistency. Do you want to do it here or follow up with another patch?
Seems reasonable to me, but I'd prefer to do this as a separate patch.
- Neil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46827/#review131066
-----------------------------------------------------------
On April 29, 2016, 9:13 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46827/
> -----------------------------------------------------------
>
> (Updated April 29, 2016, 9:13 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Also removed some unused header includes.
>
>
> Diffs
> -----
>
> src/zookeeper/contender.cpp 4b1cc654cb96d3fd87c5f36c93a8ee1e170bea77
>
> Diff: https://reviews.apache.org/r/46827/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 46827: Replaced CHECK with CHECK_READY.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46827/#review131066
-----------------------------------------------------------
It would be great to implement `CHECK_NREADY`, `CHECK_NDISCARDED`, then we could have replaced `CHECK(!candidacy.isDiscarded());` for consistency. Do you want to do it here or follow up with another patch?
- Alexander Rukletsov
On April 29, 2016, 9:13 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46827/
> -----------------------------------------------------------
>
> (Updated April 29, 2016, 9:13 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Also removed some unused header includes.
>
>
> Diffs
> -----
>
> src/zookeeper/contender.cpp 4b1cc654cb96d3fd87c5f36c93a8ee1e170bea77
>
> Diff: https://reviews.apache.org/r/46827/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 46827: Replaced CHECK with CHECK_READY.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46827/#review131084
-----------------------------------------------------------
Patch looks great!
Reviews applied: [46826, 46827]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 29, 2016, 9:13 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46827/
> -----------------------------------------------------------
>
> (Updated April 29, 2016, 9:13 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Also removed some unused header includes.
>
>
> Diffs
> -----
>
> src/zookeeper/contender.cpp 4b1cc654cb96d3fd87c5f36c93a8ee1e170bea77
>
> Diff: https://reviews.apache.org/r/46827/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Neil Conway
>
>