You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by nakomis <gi...@git.apache.org> on 2016/01/21 17:41:28 UTC
[GitHub] incubator-brooklyn pull request: Uses externally accessible addres...
GitHub user nakomis opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1168
Uses externally accessible address for main uri of controller
Previously, if deploying to BYON AWS instances, the internal IP address was being displayed in the main.uri for the ControlledDynamicWebAppCluster
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nakomis/incubator-brooklyn fix/abstract-controller-main-ui
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/1168.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1168
----
commit 978d33d11e4348e19b3f61bf5a03a1f5c177f351
Author: Martin Harris <gi...@nakomis.com>
Date: 2016-01-21T16:40:35Z
Uses externally accessible address for main uri of controller
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Uses externally accessible addres...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1168#issuecomment-175205042
(plus another test failure fix at #1174)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Uses externally accessible addres...
Posted by nakomis <gi...@git.apache.org>.
Github user nakomis commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1168#issuecomment-173865090
Test failure appears unrelated, and JmxFeedTest passes locally
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Uses externally accessible addres...
Posted by nakomis <gi...@git.apache.org>.
Github user nakomis closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1168
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Uses externally accessible addres...
Posted by nakomis <gi...@git.apache.org>.
Github user nakomis commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1168#issuecomment-173630816
@sjcorbett Good catch, had pushed some code I hadn't intended to
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Uses externally accessible addres...
Posted by nakomis <gi...@git.apache.org>.
Github user nakomis commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1168#issuecomment-186160816
/bump @sjcorbett @grkvlt @aledsage Any input on @ahgittin's comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Uses externally accessible addres...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1168#issuecomment-177059968
ugly failure this time. not one i've come across. probably nondet. @nakomix you're not having luck!
```
org.apache.brooklyn.AssemblyTest.checkBrooklynCoreFeature
Failing for the past 1 build (Since Unstable#2472 )
Took 5.5 sec.
Error Message
gave up waiting for service org.apache.karaf.features.BootFinished
Stacktrace
org.ops4j.pax.swissbox.tracker.ServiceLookupException: gave up waiting for service org.apache.karaf.features.BootFinished
at org.ops4j.pax.swissbox.tracker.ServiceLookup.getService(ServiceLookup.java:199)
at org.ops4j.pax.swissbox.tracker.ServiceLookup.getService(ServiceLookup.java:136)
at org.ops4j.pax.exam.inject.internal.ServiceInjector.injectField(ServiceInjector.java:89)
at org.ops4j.pax.exam.inject.internal.ServiceInjector.injectDeclaredFields(ServiceInjector.java:69)
at org.ops4j.pax.exam.inject.internal.ServiceInjector.injectFields(ServiceInjector.java:61)
at org.ops4j.pax.exam.invoker.junit.internal.ContainerTestRunner.createTest(ContainerTestRunner.java:61)
at org.junit.runners.BlockJUnit4ClassRunner$1.runReflectiveCall(BlockJUnit4ClassRunner.java:266)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Uses externally accessible addres...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1168#issuecomment-173898355
@nakomis agree failure unrelated, have snuck an attempt to fix this in at #1171 btw
this behaviour change seems reasonable as we normally want a load-balancer to be accessible. however this might not always be the case and it does set up further inconsistencies in when `main_uri` is the subnet address vs main address. @grkvlt in particular in clocker is this going to cause an issue, i.e. might it combine the public IP with the private port? /cc @aledsage
we should set up some guidelines about when public v private ip's are used, and how to configure
as a quick win if we need to the `inferUrl(true/false)` call in this PR could be configurable via a config key, e.g. `PREFER_ADVERTISING_PUBLIC_IP`. but that feels ugly.
if it doesn't cause an issue in clocker i'm happy to merge and live with inconsistency for now, but let's be thinking about how to cleanly handle the public/private ambiguity!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Uses externally accessible addres...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1168#discussion_r50426620
--- Diff: brooklyn-library/software/webapp/src/main/java/org/apache/brooklyn/entity/proxy/AbstractControllerImpl.java ---
@@ -283,7 +283,7 @@ protected String inferUrl(boolean requireManagementAccessible) {
}
protected String inferUrl() {
- return inferUrl(false);
+ return inferUrl();
--- End diff --
Infinite loop?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Uses externally accessible addres...
Posted by nakomis <gi...@git.apache.org>.
GitHub user nakomis reopened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1168
Uses externally accessible address for main uri of controller
Previously, if deploying to BYON AWS instances, the internal IP address was being displayed in the main.uri for the ControlledDynamicWebAppCluster
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nakomis/incubator-brooklyn fix/abstract-controller-main-ui
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/1168.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1168
----
commit c91d7ebbc3e62f5f3b2f9e2da883df1f84957f2c
Author: Martin Harris <gi...@nakomis.com>
Date: 2016-01-21T16:40:35Z
Uses externally accessible address for main uri of controller
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Uses externally accessible addres...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1168#issuecomment-177060034
@nakomis could you spearhead the others incl @sjcorbett @aledsage @grkvlt to determine what we want to do wrt public/private?
i don't think we can merge this until we've got some guidelines.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---