svn commit: r1884455 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDDocument.java

[le...@apache.org]

Author: lehmi
Date: Tue Dec 15 11:49:13 2020
New Revision: 1884455

URL: http://svn.apache.org/viewvc?rev=1884455&view=rev
Log:
PDFBOX-4952: fix condition for the usage of a xreference stream

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDDocument.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDDocument.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDDocument.java?rev=1884455&r1=1884454&r2=1884455&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDDocument.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDDocument.java Tue Dec 15 11:49:13 2020
@@ -942,10 +942,10 @@ public class PDDocument implements Close
      *
      * @param output The stream to write to. It will be closed when done. It is recommended to wrap it in a
      * {@link java.io.BufferedOutputStream}, unless it is already buffered.
-     * @param parameters The parameters for the document's compression.
+     * @param compressParameters The parameters for the document's compression.
      * @throws IOException if the output could not be written
      */
-    public void save(OutputStream output, CompressParameters parameters)
+    public void save(OutputStream output, CompressParameters compressParameters)
             throws IOException
     {
         if (document.isClosed())
@@ -954,7 +954,8 @@ public class PDDocument implements Close
         }
 
         // object stream compression requires a cross reference stream.
-        document.setIsXRefStream(parameters != null);
+        document.setIsXRefStream(compressParameters != null //
+                && CompressParameters.NO_COMPRESSION != compressParameters);
         // subset designated fonts
         for (PDFont font : fontsToSubset)
         {
@@ -963,7 +964,7 @@ public class PDDocument implements Close
         fontsToSubset.clear();
 
         // save PDF
-        try (COSWriter writer = new COSWriter(output, parameters))
+        try (COSWriter writer = new COSWriter(output, compressParameters))
         {
             writer.write(this);
         }