[GitHub] reminisce commented on a change in pull request #9942: add SameType as default type inference function in imperative mode

[GitBox <gi...@apache.org>]

reminisce commented on a change in pull request #9942: add SameType as default type inference function in imperative mode
URL: https://github.com/apache/incubator-mxnet/pull/9942#discussion_r171664073
 
 

 ##########
 File path: src/imperative/imperative_utils.h
 ##########
 @@ -120,9 +120,13 @@ inline void SetShapeType(const Context& ctx,
   for (auto& i : outputs) {
     out_types.push_back(i->dtype());
   }
-  CHECK(infertype.count(attrs.op))
-    << "Operator " << attrs.op->name << " is missing FInferType attribute";
-  CHECK(infertype[attrs.op](attrs, &in_types, &out_types));
+  bool infer_type_success;
 
 Review comment:
   nit: initialize the variable with `false`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services