You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/13 09:44:07 UTC

[GitHub] [pulsar] RobertIndie opened a new pull request, #17612: [fix][cpp] Revert OpenSSL version in rpm and deb package

RobertIndie opened a new pull request, #17612:
URL: https://github.com/apache/pulsar/pull/17612

   <!--
   ### Contribution Checklist
     
     - PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*. 
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   -->
   
   
   ### Motivation
   
   See https://github.com/apache/pulsar/pull/17538#issuecomment-1244898721
   This issue has blocked the master branch. Revert the OepnSSL version in rpm and deb package to unblock the master until we find the root cause and give a fix.
   
   ### Modifications
   
   * Revert OpenSSL version from 111n to 110j in rpm and deb package.
   
   
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
   
   - [x] `doc-not-needed` 
   (Please explain why)
   
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] lhotari commented on pull request #17612: [fix][cpp] Revert OpenSSL version in rpm and deb package

Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #17612:
URL: https://github.com/apache/pulsar/pull/17612#issuecomment-1245203592

   I made another attempt in #17613 which fixes the invalid linking configuration.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] lhotari commented on pull request #17612: [fix][cpp] Revert OpenSSL version in rpm and deb package

Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #17612:
URL: https://github.com/apache/pulsar/pull/17612#issuecomment-1245242584

   Replaced with #17614


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] lhotari commented on pull request #17612: [fix][cpp] Revert OpenSSL version in rpm and deb package

Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #17612:
URL: https://github.com/apache/pulsar/pull/17612#issuecomment-1245194812

   > Actually I found the root cause is the ABI compatibility change of libopenssl and the link order issue in debian:9 image. At the moment, I'm verifying the change locally currently and going to push a new PR to replace this revert soon.
   
   It's possible to get the libcurl compilation to pass, but I'm just wondering what the purpose of it is in the first place.
   The solution in the Dockerfile has a mistake since it's not adding /usr/local/ssl/lib to ld.so.conf . This would be a way to achieve that:
   ```
   echo /usr/local/ssl/lib >> /etc/ld.so.conf.d/ssl.conf && ldconfig -v
   ```
   With this change, the compilation would pass, but I'm not sure if it would be the correct solution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] lhotari closed pull request #17612: [fix][cpp] Revert OpenSSL version in rpm and deb package

Posted by GitBox <gi...@apache.org>.
lhotari closed pull request #17612: [fix][cpp] Revert OpenSSL version in rpm and deb package
URL: https://github.com/apache/pulsar/pull/17612


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org