You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org> on 2008/04/16 06:30:21 UTC
[jira] Created: (HADOOP-3263) job history browser throws exception
if job name or user name is null.
job history browser throws exception if job name or user name is null.
----------------------------------------------------------------------
Key: HADOOP-3263
URL: https://issues.apache.org/jira/browse/HADOOP-3263
Project: Hadoop Core
Issue Type: Bug
Components: mapred
Affects Versions: 0.17.0
Reporter: Amareshwari Sriramadasu
Assignee: Amareshwari Sriramadasu
Priority: Blocker
Fix For: 0.17.0
Job history browser throws exception if job name or user name is null. Instead it should print a null string for user/job name if they are null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3263) job history browser throws exception
if job name or user name is null.
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-3263:
----------------------------------
Attachment: HADOOP-3263_20080416.patch
Removed the unused MAX_FILENAME_SIZE variable too...
> job history browser throws exception if job name or user name is null.
> ----------------------------------------------------------------------
>
> Key: HADOOP-3263
> URL: https://issues.apache.org/jira/browse/HADOOP-3263
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.17.0
> Reporter: Amareshwari Sriramadasu
> Assignee: Arun C Murthy
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: HADOOP-3263_20080416.patch, HADOOP-3263_20080416.patch, patch-3263.txt
>
>
> Job history browser throws exception if job name or user name is null. Instead it should print a null string for user/job name if they are null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3263) job history browser throws exception
if job name or user name is null.
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-3263:
----------------------------------
Attachment: (was: HADOOP-3263_20080416.patch)
> job history browser throws exception if job name or user name is null.
> ----------------------------------------------------------------------
>
> Key: HADOOP-3263
> URL: https://issues.apache.org/jira/browse/HADOOP-3263
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.17.0
> Reporter: Amareshwari Sriramadasu
> Assignee: Arun C Murthy
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: HADOOP-3263_20080416.patch, HADOOP-3263_20080416.patch, patch-3263.txt
>
>
> Job history browser throws exception if job name or user name is null. Instead it should print a null string for user/job name if they are null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3263) job history browser throws
exception if job name or user name is null.
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589734#action_12589734 ]
Owen O'Malley commented on HADOOP-3263:
---------------------------------------
+1
> job history browser throws exception if job name or user name is null.
> ----------------------------------------------------------------------
>
> Key: HADOOP-3263
> URL: https://issues.apache.org/jira/browse/HADOOP-3263
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.17.0
> Reporter: Amareshwari Sriramadasu
> Assignee: Arun C Murthy
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: HADOOP-3263_20080416.patch, HADOOP-3263_20080416.patch, patch-3263.txt
>
>
> Job history browser throws exception if job name or user name is null. Instead it should print a null string for user/job name if they are null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3263) job history browser throws exception
if job name or user name is null.
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-3263:
----------------------------------
Attachment: HADOOP-3263_20080416.patch
Proposed fix...
> job history browser throws exception if job name or user name is null.
> ----------------------------------------------------------------------
>
> Key: HADOOP-3263
> URL: https://issues.apache.org/jira/browse/HADOOP-3263
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.17.0
> Reporter: Amareshwari Sriramadasu
> Assignee: Arun C Murthy
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: HADOOP-3263_20080416.patch, patch-3263.txt
>
>
> Job history browser throws exception if job name or user name is null. Instead it should print a null string for user/job name if they are null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3263) job history browser throws exception
if job name or user name is null.
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-3263:
----------------------------------
Attachment: HADOOP-3263_20080416.patch
> job history browser throws exception if job name or user name is null.
> ----------------------------------------------------------------------
>
> Key: HADOOP-3263
> URL: https://issues.apache.org/jira/browse/HADOOP-3263
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.17.0
> Reporter: Amareshwari Sriramadasu
> Assignee: Arun C Murthy
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: HADOOP-3263_20080416.patch, HADOOP-3263_20080416.patch, patch-3263.txt
>
>
> Job history browser throws exception if job name or user name is null. Instead it should print a null string for user/job name if they are null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3263) job history browser throws
exception if job name or user name is null.
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589659#action_12589659 ]
Arun C Murthy commented on HADOOP-3263:
---------------------------------------
Sigh, I guess you are right.
However, i just checked: the filename is around 80 characters not including the jobname, so please get rid of the truncation too in JobHistory.java.
> job history browser throws exception if job name or user name is null.
> ----------------------------------------------------------------------
>
> Key: HADOOP-3263
> URL: https://issues.apache.org/jira/browse/HADOOP-3263
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.17.0
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: patch-3263.txt
>
>
> Job history browser throws exception if job name or user name is null. Instead it should print a null string for user/job name if they are null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3263) job history browser throws exception
if job name or user name is null.
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-3263:
----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this.
> job history browser throws exception if job name or user name is null.
> ----------------------------------------------------------------------
>
> Key: HADOOP-3263
> URL: https://issues.apache.org/jira/browse/HADOOP-3263
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.17.0
> Reporter: Amareshwari Sriramadasu
> Assignee: Arun C Murthy
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: HADOOP-3263_20080416.patch, HADOOP-3263_20080416.patch, patch-3263.txt
>
>
> Job history browser throws exception if job name or user name is null. Instead it should print a null string for user/job name if they are null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3263) job history browser throws exception
if job name or user name is null.
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-3263:
----------------------------------
Status: Open (was: Patch Available)
Amareshwari, can u please regenerate this patch - it won't apply to trunk anymore.
Also, rather than all the non-null checks in jobhistory.jsp it will be simpler to use the string 'null' for jobname/username if they are null in JobHistory.java... then we won't have to change jobhistory.jsp at all.
> job history browser throws exception if job name or user name is null.
> ----------------------------------------------------------------------
>
> Key: HADOOP-3263
> URL: https://issues.apache.org/jira/browse/HADOOP-3263
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.17.0
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: patch-3263.txt
>
>
> Job history browser throws exception if job name or user name is null. Instead it should print a null string for user/job name if they are null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3263) job history browser throws exception
if job name or user name is null.
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-3263:
----------------------------------
Status: Patch Available (was: Open)
> job history browser throws exception if job name or user name is null.
> ----------------------------------------------------------------------
>
> Key: HADOOP-3263
> URL: https://issues.apache.org/jira/browse/HADOOP-3263
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.17.0
> Reporter: Amareshwari Sriramadasu
> Assignee: Arun C Murthy
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: HADOOP-3263_20080416.patch, patch-3263.txt
>
>
> Job history browser throws exception if job name or user name is null. Instead it should print a null string for user/job name if they are null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3263) job history browser throws
exception if job name or user name is null.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589988#action_12589988 ]
Hudson commented on HADOOP-3263:
--------------------------------
Integrated in Hadoop-trunk #463 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/463/])
> job history browser throws exception if job name or user name is null.
> ----------------------------------------------------------------------
>
> Key: HADOOP-3263
> URL: https://issues.apache.org/jira/browse/HADOOP-3263
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.17.0
> Reporter: Amareshwari Sriramadasu
> Assignee: Arun C Murthy
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: HADOOP-3263_20080416.patch, HADOOP-3263_20080416.patch, patch-3263.txt
>
>
> Job history browser throws exception if job name or user name is null. Instead it should print a null string for user/job name if they are null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3263) job history browser throws exception
if job name or user name is null.
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-3263:
--------------------------------------------
Status: Patch Available (was: Open)
> job history browser throws exception if job name or user name is null.
> ----------------------------------------------------------------------
>
> Key: HADOOP-3263
> URL: https://issues.apache.org/jira/browse/HADOOP-3263
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.17.0
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: patch-3263.txt
>
>
> Job history browser throws exception if job name or user name is null. Instead it should print a null string for user/job name if they are null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3263) job history browser throws
exception if job name or user name is null.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589729#action_12589729 ]
Hadoop QA commented on HADOOP-3263:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12380325/HADOOP-3263_20080416.patch
against trunk revision 645773.
@author +1. The patch does not contain any @author tags.
tests included -1. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler warnings.
release audit +1. The applied patch does not generate any new release audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2256/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2256/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2256/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2256/console
This message is automatically generated.
> job history browser throws exception if job name or user name is null.
> ----------------------------------------------------------------------
>
> Key: HADOOP-3263
> URL: https://issues.apache.org/jira/browse/HADOOP-3263
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.17.0
> Reporter: Amareshwari Sriramadasu
> Assignee: Arun C Murthy
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: HADOOP-3263_20080416.patch, patch-3263.txt
>
>
> Job history browser throws exception if job name or user name is null. Instead it should print a null string for user/job name if they are null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3263) job history browser throws
exception if job name or user name is null.
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589652#action_12589652 ]
Amareshwari Sriramadasu commented on HADOOP-3263:
-------------------------------------------------
Doing not-null check in jobhistory.jsp makes more sense than jobHistory.java, since jobHistory.java can truncate the filename (if it exceeds max_file_name_size) and jsp file should take care of that.
> job history browser throws exception if job name or user name is null.
> ----------------------------------------------------------------------
>
> Key: HADOOP-3263
> URL: https://issues.apache.org/jira/browse/HADOOP-3263
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.17.0
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: patch-3263.txt
>
>
> Job history browser throws exception if job name or user name is null. Instead it should print a null string for user/job name if they are null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-3263) job history browser throws exception
if job name or user name is null.
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy reassigned HADOOP-3263:
-------------------------------------
Assignee: Arun C Murthy (was: Amareshwari Sriramadasu)
> job history browser throws exception if job name or user name is null.
> ----------------------------------------------------------------------
>
> Key: HADOOP-3263
> URL: https://issues.apache.org/jira/browse/HADOOP-3263
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.17.0
> Reporter: Amareshwari Sriramadasu
> Assignee: Arun C Murthy
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: HADOOP-3263_20080416.patch, patch-3263.txt
>
>
> Job history browser throws exception if job name or user name is null. Instead it should print a null string for user/job name if they are null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3263) job history browser throws exception
if job name or user name is null.
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-3263:
--------------------------------------------
Attachment: patch-3263.txt
patch fixing the exception in browser for null user/job name.
> job history browser throws exception if job name or user name is null.
> ----------------------------------------------------------------------
>
> Key: HADOOP-3263
> URL: https://issues.apache.org/jira/browse/HADOOP-3263
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.17.0
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: patch-3263.txt
>
>
> Job history browser throws exception if job name or user name is null. Instead it should print a null string for user/job name if they are null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3263) job history browser throws
exception if job name or user name is null.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589494#action_12589494 ]
Hadoop QA commented on HADOOP-3263:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12380248/patch-3263.txt
against trunk revision 645773.
@author +1. The patch does not contain any @author tags.
tests included -1. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler warnings.
release audit +1. The applied patch does not generate any new release audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2251/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2251/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2251/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2251/console
This message is automatically generated.
> job history browser throws exception if job name or user name is null.
> ----------------------------------------------------------------------
>
> Key: HADOOP-3263
> URL: https://issues.apache.org/jira/browse/HADOOP-3263
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.17.0
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: patch-3263.txt
>
>
> Job history browser throws exception if job name or user name is null. Instead it should print a null string for user/job name if they are null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.