[GitHub] [pinot] vvivekiyer commented on a diff in pull request #9868: Support disabling dictionary at runtime for an existing column

[GitBox <gi...@apache.org>]

vvivekiyer commented on code in PR #9868:
URL: https://github.com/apache/pinot/pull/9868#discussion_r1035610565


##########
pinot-core/src/test/java/org/apache/pinot/queries/ForwardIndexHandlerReloadQueriesTest.java:
##########
@@ -480,6 +490,47 @@ public void testSelectWithAggregationQueriesWithReload()
         }));
     List<Object[]> beforeResultRows3 = resultTable.getRows();
 
+    // TEST4
+    query = "SELECT MAX(ARRAYLENGTH(column6)) from testTable LIMIT 10";
+    brokerResponseNative = getBrokerResponse(query);
+    assertTrue(brokerResponseNative.getProcessingExceptions() == null
+        || brokerResponseNative.getProcessingExceptions().size() == 0);
+    resultTable = brokerResponseNative.getResultTable();
+    assertEquals(brokerResponseNative.getNumRowsResultSet(), 1);
+    assertEquals(brokerResponseNative.getTotalDocs(), 400_000L);
+    assertEquals(brokerResponseNative.getNumDocsScanned(), 400_000L);
+    assertEquals(brokerResponseNative.getNumSegmentsProcessed(), 4L);
+    assertEquals(brokerResponseNative.getNumSegmentsMatched(), 4L);
+    assertEquals(brokerResponseNative.getNumEntriesScannedPostFilter(), 400000);
+    assertEquals(brokerResponseNative.getNumEntriesScannedInFilter(), 0L);
+    assertNotNull(brokerResponseNative.getProcessingExceptions());
+    assertEquals(brokerResponseNative.getProcessingExceptions().size(), 0);
+    assertEquals(resultTable.getDataSchema(), new DataSchema(new String[]{"max(arraylength(column6))"},
+        new DataSchema.ColumnDataType[]{DataSchema.ColumnDataType.DOUBLE}));
+    List<Object[]> beforeResultRows4 = resultTable.getRows();
+
+    // TEST5
+    query = "SELECT column1, max(column1), sum(column10) from testTable WHERE column6 = 1001 GROUP BY "

Review Comment:
   Yes. We do compare that the  query results exactly match before and after reload. 
   
   The list of operations is documented in L726
   
   >    * column1 -> change compression.
   >    * column6 -> disable dictionary
   >    * column9 -> disable dictionary
   >    * column3 -> Enable dictionary.
   >    * column2 -> Enable dictionary. Add inverted index.
   >    * column7 -> Enable dictionary. Add inverted index.
   >    * column10 -> Enable dictionary.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org