[jira] [Commented] (TAP5-2548) Upgrade embedded Jetty and Tomcat versions

["Thiago H. de Paula Figueiredo (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375709#comment-15375709 ] 

Thiago H. de Paula Figueiredo commented on TAP5-2548:
-----------------------------------------------------

Hello, [~jkemnade]!

I don't think that, in this case, a class in the test JAR, isn't worth the backward compatibility over the confusion. So, IMHO, just go ahead and rename the files and mention it in the release notes.

Thanks for looking into this!

Cheers!

> Upgrade embedded Jetty and Tomcat versions
> ------------------------------------------
>
>                 Key: TAP5-2548
>                 URL: https://issues.apache.org/jira/browse/TAP5-2548
>             Project: Tapestry 5
>          Issue Type: Dependency upgrade
>          Components: tapestry-runner
>            Reporter: Jochen Kemnade
>              Labels: desired_for_5.5, patch
>         Attachments: 0001-TAP5-2548-upgrade-embedded-Tomcat-and-Jetty-versions.patch
>
>
> Since we are switching to Servlet 3.0 for Tapestry 5.5, we should upgrade the embedded server versions.
> Unfortunately the runner classes contain the servlet container versions in their class names (Jetty7Runner and Tomcat6Runner). This means we can either stay backward compatible and confuse users (e.g. start Jetty 8 from Jetty7Runner) or rename the classes and break backward compatibility. I prefer the latter.
> Thoughts?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)