You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Daniel Becker (Code Review)" <ge...@cloudera.org> on 2022/12/14 13:25:07 UTC

[Impala-ASF-CR] IMPALA-11799: Fix example of the hs2 fp format shell option

Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19359


Change subject: IMPALA-11799: Fix example of the hs2_fp_format shell option
......................................................................

IMPALA-11799: Fix example of the hs2_fp_format shell option

IMPALA-10660 introduced the "hs2_fp_format" shell option. In the help
section describing the query option it states:

  Use '%16G' to match Beeswax protocol's floating-point output format

However, '%16G' is not accepted by the shell:

  bin/impala-shell.sh --hs2_fp_format='%16G'
  Invalid floating point format specification: %16G

This commit changes the example to '16G'.

Change-Id: If53e69b495dfeb8d6d65878eff9580c5e12f793d
---
M shell/option_parser.py
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/19359/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If53e69b495dfeb8d6d65878eff9580c5e12f793d
Gerrit-Change-Number: 19359
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>

[Impala-ASF-CR] IMPALA-11799: Fix example of the hs2 fp format shell option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19359 )

Change subject: IMPALA-11799: Fix example of the hs2_fp_format shell option
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12031/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If53e69b495dfeb8d6d65878eff9580c5e12f793d
Gerrit-Change-Number: 19359
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Dec 2022 13:45:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11799: Fix example of the hs2 fp format shell option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19359 )

Change subject: IMPALA-11799: Fix example of the hs2_fp_format shell option
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If53e69b495dfeb8d6d65878eff9580c5e12f793d
Gerrit-Change-Number: 19359
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 03 Jan 2023 15:31:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11799: Fix example of the hs2 fp format shell option

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19359 )

Change subject: IMPALA-11799: Fix example of the hs2_fp_format shell option
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If53e69b495dfeb8d6d65878eff9580c5e12f793d
Gerrit-Change-Number: 19359
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Dec 2022 14:09:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11799: Fix example of the hs2 fp format shell option

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19359 )

Change subject: IMPALA-11799: Fix example of the hs2_fp_format shell option
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If53e69b495dfeb8d6d65878eff9580c5e12f793d
Gerrit-Change-Number: 19359
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 03 Jan 2023 05:12:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11799: Fix example of the hs2 fp format shell option

Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/19359 )

Change subject: IMPALA-11799: Fix example of the hs2_fp_format shell option
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If53e69b495dfeb8d6d65878eff9580c5e12f793d
Gerrit-Change-Number: 19359
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 02 Jan 2023 14:51:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11799: Fix example of the hs2 fp format shell option

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19359 )

Change subject: IMPALA-11799: Fix example of the hs2_fp_format shell option
......................................................................

IMPALA-11799: Fix example of the hs2_fp_format shell option

IMPALA-10660 introduced the "hs2_fp_format" shell option. In the help
section describing the query option it states:

  Use '%16G' to match Beeswax protocol's floating-point output format

However, '%16G' is not accepted by the shell:

  bin/impala-shell.sh --hs2_fp_format='%16G'
  Invalid floating point format specification: %16G

This commit changes the example to '16G'.

Also corrected the name of the option in
shell/impala_shell_config_defaults.py from 'fp_format_specification' to
'hs2_fp_format'.

Change-Id: If53e69b495dfeb8d6d65878eff9580c5e12f793d
---
M shell/impala_shell_config_defaults.py
M shell/option_parser.py
2 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/19359/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If53e69b495dfeb8d6d65878eff9580c5e12f793d
Gerrit-Change-Number: 19359
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-11799: Fix example of the hs2 fp format shell option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19359 )

Change subject: IMPALA-11799: Fix example of the hs2_fp_format shell option
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8940/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/19359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If53e69b495dfeb8d6d65878eff9580c5e12f793d
Gerrit-Change-Number: 19359
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 03 Jan 2023 10:24:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11799: Fix example of the hs2 fp format shell option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19359 )

Change subject: IMPALA-11799: Fix example of the hs2_fp_format shell option
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If53e69b495dfeb8d6d65878eff9580c5e12f793d
Gerrit-Change-Number: 19359
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 03 Jan 2023 05:12:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11799: Fix example of the hs2 fp format shell option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19359 )

Change subject: IMPALA-11799: Fix example of the hs2_fp_format shell option
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8937/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/19359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If53e69b495dfeb8d6d65878eff9580c5e12f793d
Gerrit-Change-Number: 19359
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 03 Jan 2023 05:12:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11799: Fix example of the hs2 fp format shell option

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19359 )

Change subject: IMPALA-11799: Fix example of the hs2_fp_format shell option
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19359/1/shell/impala_shell_config_defaults.py
File shell/impala_shell_config_defaults.py:

http://gerrit.cloudera.org:8080/#/c/19359/1/shell/impala_shell_config_defaults.py@61
PS1, Line 61: fp_format_specification
Should this be 'hs2_fp_format'?



-- 
To view, visit http://gerrit.cloudera.org:8080/19359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If53e69b495dfeb8d6d65878eff9580c5e12f793d
Gerrit-Change-Number: 19359
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 19 Dec 2022 08:48:49 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11799: Fix example of the hs2 fp format shell option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19359 )

Change subject: IMPALA-11799: Fix example of the hs2_fp_format shell option
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12077/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If53e69b495dfeb8d6d65878eff9580c5e12f793d
Gerrit-Change-Number: 19359
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 02 Jan 2023 10:56:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11799: Fix example of the hs2 fp format shell option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19359 )

Change subject: IMPALA-11799: Fix example of the hs2_fp_format shell option
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8937/


-- 
To view, visit http://gerrit.cloudera.org:8080/19359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If53e69b495dfeb8d6d65878eff9580c5e12f793d
Gerrit-Change-Number: 19359
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 03 Jan 2023 10:20:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11799: Fix example of the hs2 fp format shell option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19359 )

Change subject: IMPALA-11799: Fix example of the hs2_fp_format shell option
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8939/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/19359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If53e69b495dfeb8d6d65878eff9580c5e12f793d
Gerrit-Change-Number: 19359
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 03 Jan 2023 09:27:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11799: Fix example of the hs2 fp format shell option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19359 )

Change subject: IMPALA-11799: Fix example of the hs2_fp_format shell option
......................................................................

IMPALA-11799: Fix example of the hs2_fp_format shell option

IMPALA-10660 introduced the "hs2_fp_format" shell option. In the help
section describing the query option it states:

  Use '%16G' to match Beeswax protocol's floating-point output format

However, '%16G' is not accepted by the shell:

  bin/impala-shell.sh --hs2_fp_format='%16G'
  Invalid floating point format specification: %16G

This commit changes the example to '16G'.

Also corrected the name of the option in
shell/impala_shell_config_defaults.py from 'fp_format_specification' to
'hs2_fp_format'.

Change-Id: If53e69b495dfeb8d6d65878eff9580c5e12f793d
Reviewed-on: http://gerrit.cloudera.org:8080/19359
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M shell/impala_shell_config_defaults.py
M shell/option_parser.py
2 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/19359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If53e69b495dfeb8d6d65878eff9580c5e12f793d
Gerrit-Change-Number: 19359
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>