You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cayenne.apache.org by GitBox <gi...@apache.org> on 2022/11/14 12:13:55 UTC

[GitHub] [cayenne] stariy95 commented on a diff in pull request #535: CAY-2774 Overriding service ordering in DI List causes DIRuntimeExcep…

stariy95 commented on code in PR #535:
URL: https://github.com/apache/cayenne/pull/535#discussion_r1021447579


##########
cayenne-di/src/main/java/org/apache/cayenne/di/spi/DIGraph.java:
##########
@@ -68,6 +68,7 @@ public void addAll(Collection<V> vertexes) {
 	public void add(V from, V to) {
 		this.add(from);
 		this.add(to);
+		neighbors.get(to).remove(from);

Review Comment:
   This change breaks Module providers circular dependency check, see `ModuleLoader.loadModules()`. An easy fix could be just add option to the `DIGraph` use different logic in List creation and in modules loading.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cayenne.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org