You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "junichi11 (via GitHub)" <gi...@apache.org> on 2023/08/23 12:25:34 UTC
[GitHub] [netbeans] junichi11 commented on a diff in pull request #6241: PHP: Improved validation when creating a line breakpoint
junichi11 commented on code in PR #6241:
URL: https://github.com/apache/netbeans/pull/6241#discussion_r1302938235
##########
php/php.dbgp/src/org/netbeans/modules/php/dbgp/ui/DbgpLineBreakpointCustomizerPanel.java:
##########
@@ -184,6 +202,28 @@ public Controller getController() {
return controller;
}
+ private static int findNumLines(FileObject file) {
+ DataObject dataObject;
+ try {
+ dataObject = DataObject.find(file);
+ } catch (DataObjectNotFoundException ex) {
+ LOGGER.log(Level.WARNING, "Can''t find DataObject for {0}", file.getPath()); // NOI18N
Review Comment:
IMHO, maybe, we should not translate it. If translated, we may not understand what it means when we receive an issue with a log... e.g. ”データオブジェクトがみつかりません”
##########
php/php.dbgp/src/org/netbeans/modules/php/dbgp/ui/DbgpLineBreakpointCustomizerPanel.java:
##########
@@ -184,6 +202,28 @@ public Controller getController() {
return controller;
}
+ private static int findNumLines(FileObject file) {
+ DataObject dataObject;
+ try {
+ dataObject = DataObject.find(file);
+ } catch (DataObjectNotFoundException ex) {
+ LOGGER.log(Level.WARNING, "Can''t find DataObject for {0}", file.getPath()); // NOI18N
Review Comment:
IMHO, maybe, we should not translate it. If translated, we may not understand what it means when we receive an issue with a log... e.g. ”データオブジェクトがみつかりません”
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists