You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2022/11/25 12:53:13 UTC
[GitHub] [jena] afs opened a new pull request, #1638: GH-1629: Calculate starting set for unbound paths
afs opened a new pull request, #1638:
URL: https://github.com/apache/jena/pull/1638
GitHub issue resolved #
Pull request Description:
This PR provide `PathLib.calcStartingSet` which rewrites old name `PathLib.determineUngroundedStartingSet`.
This function recursive tries to determine a starting set for paths with unbound variables at both ends.
This includes `(:p|:q)` and `:p+`.
TestPathQuery is a place to test path evaluation by using queries.
----
- [ ] Tests are included.
- [x] Commits have been squashed to remove intermediate development commit messages.
- [x] Key commit messages start with the issue number (GH-xxxx or JENA-xxxx)
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the [Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html).
----
See the [Apache Jena "Contributing" guide](https://github.com/apache/jena/blob/main/CONTRIBUTING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #1638: GH-1629: Calculate starting set for unbound paths
Posted by GitBox <gi...@apache.org>.
afs commented on PR #1638:
URL: https://github.com/apache/jena/pull/1638#issuecomment-1327912851
@SimonBin @LorenzBuehmann
This item 2 in #1629 - better starting for P_Alt and others.
I would be grateful if you'd test this out with your use cases and data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] SimonBin commented on pull request #1638: GH-1629: Calculate starting set for unbound paths
Posted by GitBox <gi...@apache.org>.
SimonBin commented on PR #1638:
URL: https://github.com/apache/jena/pull/1638#issuecomment-1332571273
we plan on testing this give us some time :sweat_smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #1638: GH-1629: Calculate starting set for unbound paths
Posted by GitBox <gi...@apache.org>.
afs commented on PR #1638:
URL: https://github.com/apache/jena/pull/1638#issuecomment-1334494197
Rebased to current main branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] rvesse merged pull request #1638: GH-1629: Calculate starting set for unbound paths
Posted by GitBox <gi...@apache.org>.
rvesse merged PR #1638:
URL: https://github.com/apache/jena/pull/1638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] LorenzBuehmann commented on pull request #1638: GH-1629: Calculate starting set for unbound paths
Posted by GitBox <gi...@apache.org>.
LorenzBuehmann commented on PR #1638:
URL: https://github.com/apache/jena/pull/1638#issuecomment-1344093385
I deployed tested latest Jena with your PR and can confirm that it works as expected on our Wikidata endpoint - it does consider alt paths as well as combinations of different path operators. It respects the query limit as well due to the lazy iterator usage now.
If I should test any more, let me now.
Thank you very much for this huge improvement w.r.t. property paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #1638: GH-1629: Calculate starting set for unbound paths
Posted by GitBox <gi...@apache.org>.
afs commented on PR #1638:
URL: https://github.com/apache/jena/pull/1638#issuecomment-1332012010
[Elsewhere](https://github.com/apache/jena/discussions/1639#discussioncomment-4272140)
> I'd be happy to test it.
@LorenzBuehmann
If you can find some time, this is the most important issue to test.
This is for 4.7.0. The default is to merge it.
It does not complete work on paths but it is important. We will be making progress and have a common base for further work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org