You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by DmitryBe <gi...@git.apache.org> on 2018/06/08 04:03:29 UTC

[GitHub] flink pull request #6141: flink-metrics-datadog: beautify metric name by exc...

GitHub user DmitryBe opened a pull request:

    https://github.com/apache/flink/pull/6141

    flink-metrics-datadog: beautify metric name by excluding host_name, tm_id, and task|job_manager values from metric name and providing them as tags

    this allows to aggregate values by using tags in datadog

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DmitryBe/flink master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6141.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6141
    
----
commit 72adcfc0be04dc98863916676cc964e3bce17372
Author: Dmitry B <dm...@...>
Date:   2018-06-08T03:58:32Z

    exclude host_name, job|task_manager name and tm_id from metric name; this values are provided as a tags

----


---

[GitHub] flink pull request #6141: flink-metrics-datadog: beautify metric name by exc...

Posted by DmitryBe <gi...@git.apache.org>.

Github user DmitryBe closed the pull request at:

    https://github.com/apache/flink/pull/6141


---

[GitHub] flink issue #6141: flink-metrics-datadog: beautify metric name by excluding ...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/6141
  
    -1
    
    This is achievable by configuring scope formats as described in the [documentation](https://ci.apache.org/projects/flink/flink-docs-master/monitoring/metrics.html#system-scope).


---

[GitHub] flink issue #6141: flink-metrics-datadog: beautify metric name by excluding ...

Posted by medcv <gi...@git.apache.org>.

Github user medcv commented on the issue:

    https://github.com/apache/flink/pull/6141
  
    @DmitryBe Thank you! is there a Jira ticket associate to this? I suggest add Jira ticket and update PR title according the Contribution guideline 



---