You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Ignasi Barrera <no...@github.com> on 2013/10/04 10:16:12 UTC
[jclouds-chef] JCLOUDS-335: Properly deserialize the
deleteDatabagItem response (#30)
/cc @noorul
You can merge this Pull Request by running:
git pull https://github.com/nacx/jclouds-chef 335-deleteitem
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-chef/pull/30
-- Commit Summary --
* JCLOUDS-335: Properly deserialize the deleteDatabagItem response
-- File Changes --
M core/src/main/java/org/jclouds/chef/ChefApi.java (2)
M core/src/test/java/org/jclouds/chef/ChefApiTest.java (4)
M core/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java (10)
-- Patch Links --
https://github.com/jclouds/jclouds-chef/pull/30.patch
https://github.com/jclouds/jclouds-chef/pull/30.diff
Re: [jclouds-chef] JCLOUDS-335: Properly deserialize the
deleteDatabagItem response (#30)
Posted by Andrew Phillips <no...@github.com>.
+1 - looks good to me. Is this now the "right" way of doing things, or a workaround for a current bug in the Chef API itself? If the latter, perhaps worth documenting that we might need to change it back?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/30#issuecomment-25695914
Re: [jclouds-chef] JCLOUDS-335: Properly deserialize the
deleteDatabagItem response (#30)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-chef-pull-requests #75](https://jclouds.ci.cloudbees.com/job/jclouds-chef-pull-requests/75/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/30#issuecomment-25682833
Re: [jclouds-chef] JCLOUDS-335: Properly deserialize the
deleteDatabagItem response (#30)
Posted by Ignasi Barrera <no...@github.com>.
@noorul, improved the assertion and squashed. Give it a try if you can!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/30#issuecomment-25684600
Re: [jclouds-chef] JCLOUDS-335: Properly deserialize the
deleteDatabagItem response (#30)
Posted by Ignasi Barrera <no...@github.com>.
I'm not sure if this is an issue in the Chef API, as it behaves the same way since Chef 10. Perhaps this has gone unnoticed since then, but given that the API behavior has not changed I tend to think this is an issue in our side. If we had built the API by looking at the real responses instead of taking the docs as an example, this issue should have not appeared.
Anyway, let's see what Chef ninjas have to say in the thread @noorul has opened in the ML and then document this accordingly.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/30#issuecomment-25698855
Re: [jclouds-chef] JCLOUDS-335: Properly deserialize the
deleteDatabagItem response (#30)
Posted by Noorul Islam K M <no...@github.com>.
@nacx My tests pass.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/30#issuecomment-25685926
Re: [jclouds-chef] JCLOUDS-335: Properly deserialize the
deleteDatabagItem response (#30)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-chef-pull-requests #76](https://jclouds.ci.cloudbees.com/job/jclouds-chef-pull-requests/76/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/30#issuecomment-25684435
Re: [jclouds-chef] JCLOUDS-335: Properly deserialize the
deleteDatabagItem response (#30)
Posted by Ignasi Barrera <no...@github.com>.
Thx! I've also run the live tests against a Chef 10, Chef 11 and Enterprise Chef and all tests are passing.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/30#issuecomment-25687757
Re: [jclouds-chef] JCLOUDS-335: Properly deserialize the
deleteDatabagItem response (#30)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-chef-pull-requests #77](https://jclouds.ci.cloudbees.com/job/jclouds-chef-pull-requests/77/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/30#issuecomment-25684580