You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fredy Wijaya (Code Review)" <ge...@cloudera.org> on 2018/07/18 04:42:32 UTC
[Impala-ASF-CR] IMPALA-7314: Doc generation should fail on error
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10976
Change subject: IMPALA-7314: Doc generation should fail on error
......................................................................
IMPALA-7314: Doc generation should fail on error
This patch updates the doc generation to fail when there is an error.
dita does not exit with non-zero exit code when there is an error. The
patch checks for [ERROR] in the dita output and fails if it encounters
one.
Testing:
- Manually tested by injecting failures
Change-Id: Ic452aa282a3f2a761e3b04a7460e0d86bc51d721
---
M docs/.gitignore
M docs/Makefile
A docs/build-doc.sh
3 files changed, 39 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/10976/1
--
To view, visit http://gerrit.cloudera.org:8080/10976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic452aa282a3f2a761e3b04a7460e0d86bc51d721
Gerrit-Change-Number: 10976
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] IMPALA-7314: Doc generation should fail on error
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10976 )
Change subject: IMPALA-7314: Doc generation should fail on error
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/351/
--
To view, visit http://gerrit.cloudera.org:8080/10976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic452aa282a3f2a761e3b04a7460e0d86bc51d721
Gerrit-Change-Number: 10976
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Jul 2018 23:26:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7314: Doc generation should fail on error
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10976 )
Change subject: IMPALA-7314: Doc generation should fail on error
......................................................................
IMPALA-7314: Doc generation should fail on error
This patch updates the doc generation to fail when there is an error.
dita does not exit with non-zero exit code when there is an error. The
patch checks for [ERROR] in the dita output and fails if it encounters
one.
Testing:
- Manually tested by injecting failures
Change-Id: Ic452aa282a3f2a761e3b04a7460e0d86bc51d721
Reviewed-on: http://gerrit.cloudera.org:8080/10976
Reviewed-by: Alex Rodoni <ar...@cloudera.com>
Reviewed-by: Michael Brown <mi...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/.gitignore
M docs/Makefile
A docs/build-doc.sh
3 files changed, 39 insertions(+), 2 deletions(-)
Approvals:
Alex Rodoni: Looks good to me, but someone else must approve
Michael Brown: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic452aa282a3f2a761e3b04a7460e0d86bc51d721
Gerrit-Change-Number: 10976
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7314: Doc generation should fail on error
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10976 )
Change subject: IMPALA-7314: Doc generation should fail on error
......................................................................
IMPALA-7314: Doc generation should fail on error
This patch updates the doc generation to fail when there is an error.
dita does not exit with non-zero exit code when there is an error. The
patch checks for [ERROR] in the dita output and fails if it encounters
one.
Testing:
- Manually tested by injecting failures
Change-Id: Ic452aa282a3f2a761e3b04a7460e0d86bc51d721
---
M docs/.gitignore
M docs/Makefile
A docs/build-doc.sh
3 files changed, 39 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/10976/2
--
To view, visit http://gerrit.cloudera.org:8080/10976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic452aa282a3f2a761e3b04a7460e0d86bc51d721
Gerrit-Change-Number: 10976
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] IMPALA-7314: Doc generation should fail on error
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10976 )
Change subject: IMPALA-7314: Doc generation should fail on error
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/10976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic452aa282a3f2a761e3b04a7460e0d86bc51d721
Gerrit-Change-Number: 10976
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Jul 2018 22:24:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7314: Doc generation should fail on error
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10976 )
Change subject: IMPALA-7314: Doc generation should fail on error
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic452aa282a3f2a761e3b04a7460e0d86bc51d721
Gerrit-Change-Number: 10976
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Jul 2018 23:32:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7314: Doc generation should fail on error
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10976 )
Change subject: IMPALA-7314: Doc generation should fail on error
......................................................................
Patch Set 2: Code-Review+1
Please make sure Alex understands and agrees with the workflow changes.
--
To view, visit http://gerrit.cloudera.org:8080/10976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic452aa282a3f2a761e3b04a7460e0d86bc51d721
Gerrit-Change-Number: 10976
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Jul 2018 22:16:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7314: Doc generation should fail on error
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10976 )
Change subject: IMPALA-7314: Doc generation should fail on error
......................................................................
Patch Set 2: Code-Review+2
I'm happy to promote my +1. For docs, use https://jenkins.impala.io/job/gerrit-docs-submit/build
--
To view, visit http://gerrit.cloudera.org:8080/10976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic452aa282a3f2a761e3b04a7460e0d86bc51d721
Gerrit-Change-Number: 10976
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Jul 2018 23:25:08 +0000
Gerrit-HasComments: No