[GitHub] [jackrabbit-oak] thomasmueller commented on a change in pull request #369: OAK-9573: Make TraverseWithSort strategy the default while indexing

[GitBox <gi...@apache.org>]

thomasmueller commented on a change in pull request #369:
URL: https://github.com/apache/jackrabbit-oak/pull/369#discussion_r707969239



##########
File path: oak-run-commons/src/test/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileStoreTest.java
##########
@@ -191,6 +201,7 @@ public void resumePreviousUnfinishedDownload() throws Exception {
         List<String> sortedPaths = TestUtils.sortPaths(paths);
         assertEquals(paths.size(), nsetf.getTotalProvidedDocCount());
         assertEquals(sortedPaths, entryPaths);
+        System.clearProperty(OAK_INDEXER_SORT_STRATEGY_TYPE);

Review comment:
       Could you add "try ... finally" please?

##########
File path: oak-run-commons/src/test/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileStoreTest.java
##########
@@ -139,6 +147,7 @@ public void parallelDownload() throws Exception {
         List<String> sortedPaths = TestUtils.sortPaths(paths);
 
         assertEquals(sortedPaths, entryPaths);
+        System.clearProperty(OAK_INDEXER_SORT_STRATEGY_TYPE);

Review comment:
       Could you add "try ... finally" please?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org