[GitHub] drcrallen edited a comment on issue #6942: Shade Guava manually

[GitBox <gi...@apache.org>]

drcrallen edited a comment on issue #6942: Shade Guava manually
URL: https://github.com/apache/incubator-druid/issues/6942#issuecomment-465662283
 
 
   One of the challenges I've faced with shading is that it becomes very hard to figure out which version of a library is actually deployed in a production cluster. With reflection (or full classloader isolation), the jars are kept separate and it is easier to debug exactly which version things are coming from. With shading you loose the version information, and can accidentally shade (or neglect to shade) things which should not have (or should have) been shaded.
   
   In such scenarios tracking down which version of what libs are getting pulled into which dependencies at what point in the build and deploy process is a huge pain. It is much easier to go "Oh, I see version X.Y.Z and X.Q.R in the `lib` dir, those must have a conflict" and then work out how to make them play nice together.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org