You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/09/01 17:21:56 UTC
[GitHub] [couchdb-fauxton] garrensmith commented on a change in pull request #1292: Feat/news security info
garrensmith commented on a change in pull request #1292:
URL: https://github.com/apache/couchdb-fauxton/pull/1292#discussion_r481308073
##########
File path: app/addons/news/components.js
##########
@@ -11,14 +11,78 @@
// the License.
import React from "react";
+import Cookies from 'universal-cookie';
+const cookies = new Cookies();
-const NewsPage = () => {
+function LoadNewsButton(props) {
Review comment:
Can you make this a fat arrows function. `const LoadNewsButton => ({showNews, isChecked}`
##########
File path: app/addons/news/components.js
##########
@@ -11,14 +11,78 @@
// the License.
import React from "react";
+import Cookies from 'universal-cookie';
Review comment:
I'm not sure about adding a new dependancy to manage this? What about rather using localstorage to store this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org