You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2015/11/25 16:07:48 UTC
[GitHub] couchdb-fauxton pull request: build: simplify & fix
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/582
build: simplify & fix
- remove git checkouts, fauxton never used git checkout and they
add complexity
- fix async code: an async function call returns undefined, fix
done(local && remote)
- fix async code: as async callbacks do not return move the
done-callback to the point where all async operations are
finished to avoid possible race conditions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton build-async
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/582.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #582
----
commit cc433cf05caaa38153ea894767e5c5a4fa633ebb
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-11-25T15:05:16Z
build: simplify & fix
- remove git checkouts, fauxton never used git checkout and they
add complexity
- fix async code: an async function call returns undefined, fix
done(local && remote)
- fix async code: as async callbacks do not return move the
done-callback to the point where all async operations are
finished to avoid possible race conditions
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: build: simplify & fix
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/582#issuecomment-159646599
+1 works on my machine
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: build: simplify & fix
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/582
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: build: simplify & fix
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/582#issuecomment-159945245
merged as 6d6dbdd366e1a42b1bd7298baf4ee4dd598dc2fd
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---