[jira] [Commented] (HADOOP-19587) S3A Analytics-Accelerator: Add support SSE-C

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-19587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18005242#comment-18005242 ] 

ASF GitHub Bot commented on HADOOP-19587:
-----------------------------------------

mukund-thakur commented on code in PR #7738:
URL: https://github.com/apache/hadoop/pull/7738#discussion_r2205717828


##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/streams/AnalyticsStream.java:
##########
@@ -205,6 +209,12 @@ private OpenStreamInformation buildOpenStreamInformation(ObjectReadParameters pa
           .etag(parameters.getObjectAttributes().getETag()).build());
     }
 
+    if(parameters.getEncryptionSecrets().getEncryptionMethod() == S3AEncryptionMethods.SSE_C) {

Review Comment:
   Why don't I see the condition for other encryption methods like SSE_KMS etc? 





> S3A Analytics-Accelerator: Add support SSE-C
> --------------------------------------------
>
>                 Key: HADOOP-19587
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19587
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Ahmar Suhail
>            Priority: Major
>
> Pass down SSE-C key to AAL so it can be attached while making the GET request.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org